public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Subject: Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type
Date: Mon, 6 Feb 2017 11:42:35 +0530
Message-ID: <CAKKotZTV6eW5RkC2DuSW8TjZz5sEv8Qk47EABvYth07yORb12w@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQoJHp2uae=Zuee87FzHFs1cg0kKgEpp8baTn7t1VeSrg@mail.gmail.com>
References: <CAKKotZQm+_1amWAvuH3n-hYVdi98pykAz1PRy2fcnYkoi6PzNQ@mail.gmail.com>
<CA+OCxox0BPEd+7iUznLvPkyohOf7ur+c8uov3MPXur3O2JGdCg@mail.gmail.com>
<CAKKotZQmuH7Vm8on6BL9Bdv96wY53mpcFx5Nz_B5iEna6JhoSg@mail.gmail.com>
<CA+OCxow47n8-xX-+docKe8vBhL_+=-UYQ4XkrnY2sD-yAzLabA@mail.gmail.com>
<CAKKotZSt-ypD=nu7YGrpSGJ5BWvAUNBzFpAhUAv-21DXoO4pyw@mail.gmail.com>
<CA+OCxowUKoSpsKfyAj7-xtvC83KFaKi1C-xtzajPX3vfQFpM0A@mail.gmail.com>
<CA+OCxoz2i3rmquJELdjsdNgvPrYax5T5fNggxSk1M3ahkrxOrA@mail.gmail.com>
<CAKKotZQoJHp2uae=Zuee87FzHFs1cg0kKgEpp8baTn7t1VeSrg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Dave,
Please find a fix for the same, attribute length was set to False instead
of None.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Feb 6, 2017 at 11:18 AM, Murtuza Zabuawala <
[email protected]> wrote:
> Sure, Checking.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Sat, Feb 4, 2017 at 7:34 PM, Dave Page <[email protected]> wrote:
>
>> Hi Murtuza,
>>
>> I clearly neglected to run the regression tests with this patch, and
>> unfortunately it looks like it broke them. Can you look at this ASAP
>> please?
>>
>> runTest (pgadmin.browser.server_groups.servers.databases.schemas.
>> tables.column.tests.test_column_add.ColumnAddTestCase)
>> This function will add column under table node. (Add table Node URL)
>> ... 2017-02-04 14:43:55,191: ERROR pgadmin: Failed to execute query
>> (execute_scalar) for the server #4 - DB:test_db_9e176 (Query-id:
>> 4792242):
>> Error Message:ERROR: syntax error at or near "False"
>> LINE 2: ADD COLUMN test_column_add_f0d5d char(False);
>> ^
>> FAIL
>>
>> As far as I can see, the app works fine - it's only the test that
>> broke (probably because the application uses type name aliases (e.g.
>> character) rather than the base type name that the test is using
>> ("char").
>>
>> Thanks.
>>
>> On Fri, Feb 3, 2017 at 1:52 PM, Dave Page <[email protected]> wrote:
>> > Thanks - patch applied.
>> >
>> > On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala
>> > <[email protected]> wrote:
>> >> Hi,
>> >>
>> >> Please find updates patch for the same.
>> >> RM#2076
>> >>
>> >> --
>> >> Regards,
>> >> Murtuza Zabuawala
>> >> EnterpriseDB: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> On Wed, Feb 1, 2017 at 3:08 PM, Dave Page <[email protected]> wrote:
>> >>>
>> >>> Hi
>> >>>
>> >>> On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala
>> >>> <[email protected]> wrote:
>> >>> > Hi Dave,
>> >>> >
>> >>> > PFA updated patch.
>> >>>
>> >>> This seems to display "timestamp(0) with[out] timezone" columns
>> >>> correctly in both the properties panel and dialog now, but the size is
>> >>> still ignored if I try to add a new column through the table or column
>> >>> dialogue.
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>> >
>> > EnterpriseDB UK: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/tests/test_column_add.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/tests/test_column_add.py
index 25542d7..fb2bbe7 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/tests/test_column_add.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/tests/test_column_add.py
@@ -55,7 +55,7 @@ class ColumnAddTestCase(BaseTestGenerator):
"attacl": [],
"is_primary_key": False,
"attnotnull": False,
- "attlen": False,
+ "attlen": None,
"attprecision": None,
"attoptions": [],
"seclabels": []
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[text/plain] fix_attlen_column.diff (800B, 3-fix_attlen_column.diff)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/tests/test_column_add.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/tests/test_column_add.py
index 25542d7..fb2bbe7 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/tests/test_column_add.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/tests/test_column_add.py
@@ -55,7 +55,7 @@ class ColumnAddTestCase(BaseTestGenerator):
"attacl": [],
"is_primary_key": False,
"attnotnull": False,
- "attlen": False,
+ "attlen": None,
"attprecision": None,
"attoptions": [],
"seclabels": []
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type
In-Reply-To: <CAKKotZTV6eW5RkC2DuSW8TjZz5sEv8Qk47EABvYth07yORb12w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox