public inbox for [email protected]
help / color / mirror / Atom feedFrom: Priyanka Shendge <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Kanchan Mohitey <[email protected]>
Subject: Re: Database child node: Cast node patch
Date: Wed, 5 Oct 2016 12:01:57 +0530
Message-ID: <CAKmZXFSRt8CUps0ZcmhhHKBhMDAxWyFsS0ufa_5oj5BE32KFwg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyNR_mzGEEUqVXSPdvR-KFU91DoSg9hkyVX31SqVLJV3w@mail.gmail.com>
References: <CAKmZXFTmr2DphVBEKR-bGHQVK2MHZHUea0fhxiWGDwWfVHy+Bg@mail.gmail.com>
<CA+OCxozZVXSNV1wkHn5Ef-hkvukh+s+QXV-6UbRs4YR7EgjWcw@mail.gmail.com>
<CAKmZXFTv6rOMoktLiw-wWNaNzH6N0Z-3DxJm9+N5b5h6Q6y_8g@mail.gmail.com>
<CA+OCxoyNR_mzGEEUqVXSPdvR-KFU91DoSg9hkyVX31SqVLJV3w@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On 4 October 2016 at 19:36, Dave Page <[email protected]> wrote:
> Hi
>
> On Tue, Oct 4, 2016 at 9:01 AM, Priyanka Shendge
> <[email protected]> wrote:
> > I applied this patch on clean machine and executed testsuite only for
> "cast"
> > node, i did not face any issue.
> > When i tried to execute testsuite for all nodes, i get same output as you
> > mentioned above e-mail. (As few variable name
> > have changed later on in test_utils.py file and those are yet to change
> in
> > server and database API cases. So while importing
> > those variables its throwing import error.) Also, me and Navnath have
> > verified that this output is not related to setup.py changes.
> > (7175929cab984e070d15eb13625ab50459edf9ca)
> >
> > Could you please try running testsuite only for cast node (python
> > regression/runtests.py --pkg browser.server_groups.servers.
> databases.casts)
> > and let me know if there are any issues.
>
> No, I don't see the issue if I only run the cast tests.
>
Correct.
>
> I'm not sure how this helps though - I still see the problem if I run
> all tests with the patch applied. If I revert the patch, it goes away.
> Therefore it's definitely being triggered by the cast patch, if not,
> caused by it.
>
Yes, the import errors you are getting its because "Cast" patch, as i
have changed the variables name from ../regression/__init__.py and
test_setup.py file.
In code cleanup we have removed variables(like picke_path,
advanced_config_path) from test_setup.py.
Those variables have reference to all API cases, which are need to change
(except cast).
We are integrating these changes along with new code to other API cases.
For now you can you please
ignore these errors? Once all API cases are in place there wont be any
issues seen.
Thank you.
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
--
Best,
Priyanka
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Database child node: Cast node patch
In-Reply-To: <CAKmZXFSRt8CUps0ZcmhhHKBhMDAxWyFsS0ufa_5oj5BE32KFwg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox