public inbox for [email protected]
help / color / mirror / Atom feedFrom: Priyanka Shendge <[email protected]>
To: Dave Page <[email protected]>
Cc: Navnath Gadakh <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Kanchan Mohitey <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Subject: Re: pgAdmin IV : Unittest modular patch
Date: Wed, 27 Jul 2016 20:57:33 +0530
Message-ID: <CAKmZXFTZK7NkS5Y0_kJ2D3VpVdKdL5xvS7YDzRLgEV0Ku9GGOA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowE5D0N2oq-Da+eXh4+cZMA3=GqB85-nE+YHuaACfjhbQ@mail.gmail.com>
References: <CAOAJCYrcxBN2J_3dWq0Cwc82fkugzUi3NKD4jKoTKRBot=ev8w@mail.gmail.com>
<CAOAJCYpSBXcfEC5d4Sv_=jV86m1=rKUK0tMkZFhdSHkPb=XT3A@mail.gmail.com>
<CA+OCxowW0wjpNT-o0YF1Bg9rtD6Z7sqp35ZRUgoEguVKO4OtSw@mail.gmail.com>
<CAOAJCYr1JwYK4x2wDYw2UVAZoXC5a0FQT7Yz1Y_Wn46kzPMmQg@mail.gmail.com>
<CA+OCxoxqahNgLmvQqqErQZL2JS0EaQwyXkgkzvkFtGNh0OKV6w@mail.gmail.com>
<CAOAJCYqQQ4MaudVaVwfcateuxum-W39HwRiEorhYP8zbqjxN0g@mail.gmail.com>
<CA+OCxozZVCwB4t6hXjMeHbBV8Fx1cm_Cg1tknjWyYxLFZNYsEQ@mail.gmail.com>
<CAFOhELes8Vu_VciiVu31wfaYtTuCFUReEF1mfNXB4nSMcTNrHA@mail.gmail.com>
<CAOAJCYpY=u4T38s+XqQDOky10e7A_Wb_q9bbiwhx_=eF-6i-dQ@mail.gmail.com>
<CA+OCxoxm9_f5PJVLhwrSk6bozmivv_-=o+spffXjkYk+qPDKeg@mail.gmail.com>
<CAOAJCYpcye6nQAPB8os9vZXOhAf9wEvr6rA9i4vuZLDVrRYF0g@mail.gmail.com>
<CA+OCxowE5D0N2oq-Da+eXh4+cZMA3=GqB85-nE+YHuaACfjhbQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On 27 July 2016 at 20:12, Dave Page <[email protected]> wrote:
> Ahh, that explains it. Nice catch! It's working in both server and
> desktop modes now :-).
>
Great. Thanks to Khushboo for helping Navnath in this task.
Thank you.
> On Wed, Jul 27, 2016 at 1:19 PM, Navnath Gadakh
> <[email protected]> wrote:
> > Hi Dave,
> > We have reproduced the issue you mentioned in the previous
> > email. We need to skip the login related test cases when SERVER_MODE =
> > False in the web/config_local.py.
> >
> > Please find the revised patch for the same.
> >
> > Thanks!
> >
> >
> > On Fri, Jul 22, 2016 at 9:48 PM, Dave Page <[email protected]>
> wrote:
> >> Hi
> >>
> >> On Fri, Jul 22, 2016 at 2:22 PM, Navnath Gadakh
> >> <[email protected]> wrote:
> >>> Hi Dave,
> >>>
> >>> Please find the attached patch for pgAdmin4 unittest(Support of API
> >>> testing with different servers i.e. PG and PPAS).
> >>>
> >>> This patch includes-
> >>>
> >>> Test framework support API testing with multiple server for this we
> need to
> >>> modify test_config.json(for user it’s test_config.json.in) and
> >>> test_advanced_config.json(for user it’s test_advanced_config.json.in).
> >>> Server details of PG and PPAS are included in both .in files.
> >>>
> >>> Removed the logic of logging in the test client on each test
> scenario(As
> >>> per Khushboo's comment in previous email). We need this logic in test
> cases
> >>> under ‘browser/tests/’ as for test scenarios like change password and
> >>> invalid login test cases as test client should be logged out first.
> So, as
> >>> per this the code is slightly modified in ‘browser/tests/’.
> >>
> >> OK in principle, but it doesn't seem to work:
> >>
> >> This function will add the server under default server group. (Default
> >> Server Node url) ... ok
> >>
> >> ======================================================================
> >> FAIL: runTest
> (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> >> This function checks reset password functionality. (TestCase for
> >> Validating Empty Email)
> >> ----------------------------------------------------------------------
> >> Traceback (most recent call last):
> >> File
> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_reset_password.py",
> >> line 44, in runTest
> >> 'utf-8'))
> >> AssertionError: 'Recover pgAdmin 4 Password' not found in u'<!DOCTYPE
> >> HTML PUBLIC "-//W3C//DTD HTML 3.2
> >>
> Final//EN">\n<title>Redirecting...</title>\n<h1>Redirecting...</h1>\n<p>You
> >> should be redirected automatically to target URL: <a href="/">/</a>.
> >> If not click the link.'
> >>
> >> ======================================================================
> >> FAIL: runTest
> (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> >> This function checks reset password functionality. (TestCase for
> >> Validating Invalid_Email)
> >> ----------------------------------------------------------------------
> >> Traceback (most recent call last):
> >> File
> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_reset_password.py",
> >> line 44, in runTest
> >> 'utf-8'))
> >> AssertionError: 'Recover pgAdmin 4 Password' not found in u'<!DOCTYPE
> >> HTML PUBLIC "-//W3C//DTD HTML 3.2
> >>
> Final//EN">\n<title>Redirecting...</title>\n<h1>Redirecting...</h1>\n<p>You
> >> should be redirected automatically to target URL: <a href="/">/</a>.
> >> If not click the link.'
> >>
> >> ======================================================================
> >> FAIL: runTest
> (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> >> This function checks reset password functionality. (TestCase for
> >> Validating Valid_Email)
> >> ----------------------------------------------------------------------
> >> Traceback (most recent call last):
> >> File
> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_reset_password.py",
> >> line 44, in runTest
> >> 'utf-8'))
> >> AssertionError: 'Recover pgAdmin 4 Password' not found in u'<!DOCTYPE
> >> HTML PUBLIC "-//W3C//DTD HTML 3.2
> >>
> Final//EN">\n<title>Redirecting...</title>\n<h1>Redirecting...</h1>\n<p>You
> >> should be redirected automatically to target URL: <a href="/">/</a>.
> >> If not click the link.'
> >>
> >> ----------------------------------------------------------------------
> >> Ran 26 tests in 30.109s
> >>
> >> FAILED (failures=3)
> >>
> >> It's very far from obvious what's wrong here (/reset looks just fine
> >> to me). How can we get more useful info out of the framework?
> >>
> >> --
> >> Dave Page
> >> VP, Chief Architect, Tools & Installers
> >> EnterpriseDB: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >>
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >
> >
> >
> > --
> > Thanks,
> > Navnath Gadakh
> > Software Engineer
> > EnterpriseDB Corporation
> > Mobile: +91 9975389878
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Best,
Priyanka
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
view thread (29+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgAdmin IV : Unittest modular patch
In-Reply-To: <CAKmZXFTZK7NkS5Y0_kJ2D3VpVdKdL5xvS7YDzRLgEV0Ku9GGOA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox