public inbox for [email protected]
help / color / mirror / Atom feed[patch][pgAdmin] RM6858 Types collection properties tab delete issue
3+ messages / 2 participants
[nested] [flat]
* [patch][pgAdmin] RM6858 Types collection properties tab delete issue
@ 2021-10-19 08:56 Rahul Shirsat <[email protected]>
2021-10-19 11:15 ` Re: [patch][pgAdmin] RM6858 Types collection properties tab delete issue Rahul Shirsat <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Rahul Shirsat @ 2021-10-19 08:56 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find the attached patch which resolves the Type collection delete
issue.
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM6858.patch (784B, 3-RM6858.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js
index 314c9c187..d2374b126 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js
@@ -79,9 +79,9 @@ define('pgadmin.node.type', [
yet migrated to new react schema. Once the properties for collection
is removed, remove this model */
model: pgBrowser.Node.Model.extend({
+ idAttribute: 'oid',
defaults: {
name: undefined,
- oid: undefined,
is_sys_type: false,
typtype: undefined,
},
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [patch][pgAdmin] RM6858 Types collection properties tab delete issue
2021-10-19 08:56 [patch][pgAdmin] RM6858 Types collection properties tab delete issue Rahul Shirsat <[email protected]>
@ 2021-10-19 11:15 ` Rahul Shirsat <[email protected]>
2021-10-19 11:54 ` Re: [patch][pgAdmin] RM6858 Types collection properties tab delete issue Akshay Joshi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Rahul Shirsat @ 2021-10-19 11:15 UTC (permalink / raw)
To: pgadmin-hackers
Hackers,
Please ignore the above mail. Find the updated patch attached.
On Tue, Oct 19, 2021 at 2:26 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached patch which resolves the Type collection delete
> issue.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM6858_v2.patch (2.2K, 3-RM6858_v2.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/static/js/constraints.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/static/js/constraints.js
index a3fd3030d..fa3f7e486 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/static/js/constraints.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/static/js/constraints.js
@@ -44,6 +44,7 @@ define('pgadmin.node.constraints', [
pgBrowser.add_menus([]);
},
model: pgAdmin.Browser.Node.Model.extend({
+ idAttribute: 'oid',
defaults: {
name: undefined,
oid: undefined,
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js
index 210c333d2..146e004b4 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/static/js/partition.js
@@ -319,6 +319,7 @@ function(
return getNodePartitionTableSchema(treeNodeInfo, itemNodeData, pgBrowser);
},
model: pgBrowser.Node.Model.extend({
+ idAttribute: 'oid',
defaults: {
name: undefined,
oid: undefined,
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js
index 314c9c187..d2374b126 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.js
@@ -79,9 +79,9 @@ define('pgadmin.node.type', [
yet migrated to new react schema. Once the properties for collection
is removed, remove this model */
model: pgBrowser.Node.Model.extend({
+ idAttribute: 'oid',
defaults: {
name: undefined,
- oid: undefined,
is_sys_type: false,
typtype: undefined,
},
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [patch][pgAdmin] RM6858 Types collection properties tab delete issue
2021-10-19 08:56 [patch][pgAdmin] RM6858 Types collection properties tab delete issue Rahul Shirsat <[email protected]>
2021-10-19 11:15 ` Re: [patch][pgAdmin] RM6858 Types collection properties tab delete issue Rahul Shirsat <[email protected]>
@ 2021-10-19 11:54 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Akshay Joshi @ 2021-10-19 11:54 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Thanks, the patch applied.
On Tue, Oct 19, 2021 at 4:45 PM Rahul Shirsat <
[email protected]> wrote:
> Hackers,
>
> Please ignore the above mail. Find the updated patch attached.
>
> On Tue, Oct 19, 2021 at 2:26 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which resolves the Type collection delete
>> issue.
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-10-19 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 08:56 [patch][pgAdmin] RM6858 Types collection properties tab delete issue Rahul Shirsat <[email protected]>
2021-10-19 11:15 ` Rahul Shirsat <[email protected]>
2021-10-19 11:54 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox