public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Strauch, Sheldon <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM3782] Debugger title should show connection and object details
Date: Thu, 13 Jun 2019 10:36:11 +0530
Message-ID: <CAM9w-_=VXbiMHg6RJqSxR2uVVuoBYAgjYq=1ZXG+kn0qBJis8A@mail.gmail.com> (raw)
In-Reply-To: <CAONmzmVGa5o5aRMAqELVcvfrB3TK68uWrvVSq3-Qao_3iE3wNA@mail.gmail.com>
References: <CAM9w-_nA2VQYK8=++WQ2jnhkFF0qzK+995-ako1rOKuEqC5nsw@mail.gmail.com>
<CA+OCxowox7eDXeYHDS4LmJW3ZTJmSZO8bttJpq8v5neq91bUUg@mail.gmail.com>
<CAM9w-_nVUOYDyichaV=ov6A2oU+u6MBa=OWNgxwDoOAukFKZhQ@mail.gmail.com>
<CA+OCxoy7NncSzSyRBPbbcuegTW3F9rV9UQmbZ8S=1J1pOwkpuQ@mail.gmail.com>
<CAONmzmVGa5o5aRMAqELVcvfrB3TK68uWrvVSq3-Qao_3iE3wNA@mail.gmail.com>
I have closed this RM (RM3782 <https://redmine.postgresql.org/issues/3782;)
and have added the proposed solution to RM4232
<https://redmine.postgresql.org/issues/4232;.
On Wed, Jun 12, 2019 at 8:56 PM Strauch, Sheldon <[email protected]> wrote:
> FWIW:
>
> - +1 for INDEPENDENTLY configurable tab title AND tooltip
> - I agree that in-place edit of tabs cost/benefit isn't there, unless
> someone wants a personal free-time project
>
>
> On Wed, Jun 12, 2019 at 4:44 AM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Wed, Jun 12, 2019 at 10:02 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> On Wed, Jun 12, 2019 at 1:54 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is the patch to add more information on connection details to
>>>>> debugger panel title and content title similar to Query Tool and View/Edit
>>>>> data.
>>>>> Adding the object name with arguments is not a good idea for the panel
>>>>> title, so I have kept to connection details similar to query tool. The
>>>>> content title will have all the details.
>>>>>
>>>>> Kindly review.
>>>>>
>>>>
>>>> I think not having the function name in there is a big limitation.
>>>>
>>>> With all this hacking going on, I think what we need to do is stop and
>>>> make this configurable as has been both requested by users and suggested by
>>>> us.
>>>>
>>>> I propose adding 2 preference options for each tab type. Each of these
>>>> would be a string with placeholders, one for the tab title, and one for the
>>>> tab tooltip. For example:
>>>>
>>>> - Query Tool
>>>> * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
>>>> * Tab title default: %DATABASE% on %SERVER%
>>>> * Tooltip title default: Query Tool: %DATABASE% on %USERNAME%@
>>>> %SERVER%
>>>>
>>>> - View Data
>>>> * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%,
>>>> %PORT%, %HOST%
>>>> * Tab title default: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER%
>>>> * Tooltip title default: View/Edit Data: %SCHEMA%.%TABLE%
>>>> in %DATABASE% on %USERNAME%@%SERVER%
>>>>
>>>> - Script
>>>> * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%,
>>>> %USERNAME%, %PORT%, %HOST%
>>>> * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on
>>>> %SERVER%
>>>> * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJECT%
>>>> in %DATABASE% on %USERNAME%@%SERVER%
>>>>
>>>> - Debugger
>>>> * Placeholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%,
>>>> %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
>>>> * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE% on
>>>> %SERVER%
>>>> * Tooltip title default: Debugger: %SCHEMA%.%FUNCTION_ARGS%
>>>> in %DATABASE% on %USERNAME%@%SERVER%
>>>>
>>>> Or something like that. Thoughts?
>>>>
>>> Yes, this could be a nice feature. I think tooltip title customisation
>>> is not needed, we can just set it as prefix + tab title.
>>>
>>
>> I think having it be separate is useful - you can include full
>> information there, but keep the tab minimal so as not to create huge tabs.
>> For example, the debugger tab could just be set to %FUNCTION_NOARGS%,
>> whilst the tooltip has the full string.
>>
>>
>>> Some users asked for in-place rename of tab title. I'm not sure if it is
>>> feasible to implement, but should we consider it also ?
>>>
>>
>> No - I've only seen one request for that, and it seems like a lot of work
>> for little gain.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__pgsnake.blogspot.com&d=DwMFaQ&c=lEzKI_JJ...;
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__www.enterprisedb.com&d=DwMFaQ&c=lEzKI_JJ...;
>> The Enterprise PostgreSQL Company
>>
>
>
> --
>
> Look after your data, and your database will look after you. -- Simon Riggs
>
> Sheldon E. Strauch
> *Data Architect, Data Services *
> *O* 312-676-1556
> *M* 224-723-3878
>
> *Enova International, Inc.*
> *This transmission is confidential and may be privileged or proprietary.
> If you are not the intended recipient, you are not authorized to use the
> information in this transmission in any way. Please inform the sender
> immediately if you have received this transmission in error and permanently
> delete and destroy the original and any copies of the information.*
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM3782] Debugger title should show connection and object details
In-Reply-To: <CAM9w-_=VXbiMHg6RJqSxR2uVVuoBYAgjYq=1ZXG+kn0qBJis8A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox