public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM3782] Debugger title should show connection and object details
Date: Wed, 12 Jun 2019 14:32:04 +0530
Message-ID: <CAM9w-_nVUOYDyichaV=ov6A2oU+u6MBa=OWNgxwDoOAukFKZhQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowox7eDXeYHDS4LmJW3ZTJmSZO8bttJpq8v5neq91bUUg@mail.gmail.com>
References: <CAM9w-_nA2VQYK8=++WQ2jnhkFF0qzK+995-ako1rOKuEqC5nsw@mail.gmail.com>
<CA+OCxowox7eDXeYHDS4LmJW3ZTJmSZO8bttJpq8v5neq91bUUg@mail.gmail.com>
Hi,
On Wed, Jun 12, 2019 at 1:54 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to add more information on connection details to
>> debugger panel title and content title similar to Query Tool and View/Edit
>> data.
>> Adding the object name with arguments is not a good idea for the panel
>> title, so I have kept to connection details similar to query tool. The
>> content title will have all the details.
>>
>> Kindly review.
>>
>
> I think not having the function name in there is a big limitation.
>
> With all this hacking going on, I think what we need to do is stop and
> make this configurable as has been both requested by users and suggested by
> us.
>
> I propose adding 2 preference options for each tab type. Each of these
> would be a string with placeholders, one for the tab title, and one for the
> tab tooltip. For example:
>
> - Query Tool
> * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
> * Tab title default: %DATABASE% on %SERVER%
> * Tooltip title default: Query Tool: %DATABASE% on %USERNAME%@%SERVER%
>
> - View Data
> * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%,
> %PORT%, %HOST%
> * Tab title default: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER%
> * Tooltip title default: View/Edit Data: %SCHEMA%.%TABLE% in %DATABASE%
> on %USERNAME%@%SERVER%
>
> - Script
> * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%,
> %USERNAME%, %PORT%, %HOST%
> * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on %SERVER%
> * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJECT%
> in %DATABASE% on %USERNAME%@%SERVER%
>
> - Debugger
> * Placeholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%,
> %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
> * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE% on %SERVER%
> * Tooltip title default: Debugger: %SCHEMA%.%FUNCTION_ARGS%
> in %DATABASE% on %USERNAME%@%SERVER%
>
> Or something like that. Thoughts?
>
Yes, this could be a nice feature. I think tooltip title customisation is
not needed, we can just set it as prefix + tab title. Some users asked for
in-place rename of tab title. I'm not sure if it is feasible to implement,
but should we consider it also ?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM3782] Debugger title should show connection and object details
In-Reply-To: <CAM9w-_nVUOYDyichaV=ov6A2oU+u6MBa=OWNgxwDoOAukFKZhQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox