public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Nagesh Dhope <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
Date: Thu, 26 Mar 2020 10:23:23 +0530
Message-ID: <CAM9w-_k2LJh7Cf2ycX+mOdn0kutea0Yy8EBLryza7HyepXkiZA@mail.gmail.com> (raw)
In-Reply-To: <CAA3zdZo1V2-wNwQ6ghOmKrVT_sV-=hiiKiKFAnMMhuxnp3SXkg@mail.gmail.com>
References: <CAA3zdZo1V2-wNwQ6ghOmKrVT_sV-=hiiKiKFAnMMhuxnp3SXkg@mail.gmail.com>
Hi Nagesh,
I cannot see any change related to $active-border variable apart from
!default. Plus, $active-border should not be allowed to edit. It is a
structural variable and not a variable which affects theme change.
Please revert the $active-border change and send the patch.
On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope <[email protected]>
wrote:
> Hi Hackers,
>
> Please find a patch which includes
>
> 1. Use *btn-secondary* styles for all buttons in alertify dialog
> header.
> 2. Added *!default *for $active-border variable, so that it can be
> overridden if required.
> 3. Added entry for *.scss *in .editorconfig
>
> --
> Thanks,
> Nagesh
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
In-Reply-To: <CAM9w-_k2LJh7Cf2ycX+mOdn0kutea0Yy8EBLryza7HyepXkiZA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox