public inbox for [email protected]  

help / color / mirror / Atom feed
From: Aditya Toshniwal <[email protected]>
To: Sahil Harpal <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Cc: [email protected]
Subject: Re: Pgadmin4 System Stats Extension Design
Date: Fri, 25 Aug 2023 11:55:41 +0530
Message-ID: <CAM9w-_k=NBQsLpUNy8WQrfJT26OH25ZrjLhaqg8ZZHAenfKNDA@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_kEePXiF1HFu_9uLEaAWbcqX43wJpF8RQMkzXQu6QB-9w@mail.gmail.com>
References: <CAKi=nnc6Ze8QWBmSHe9YBYciWeDzMf=-rw9BgyNocFSokrpi6w@mail.gmail.com>
	<CAKi=nneuTPLMppZaAm-Y1X=4mY3UnbkbJAMCHF=Fu-2+kateRg@mail.gmail.com>
	<CAFOhELdhcYr9NBNrkEAWt_cwP77U2ANRK4xonqKA1p6WpMBdMA@mail.gmail.com>
	<CAKi=nndBjGOKD7BbUgJ94KYunRNQK+i_YkQw_F=EZsHhOT=OJg@mail.gmail.com>
	<CAKi=nneCatFu52EuHyDLPVW36LSQq-m2V0_WiDSL6tUrJsHUZw@mail.gmail.com>
	<CAM9w-_kEePXiF1HFu_9uLEaAWbcqX43wJpF8RQMkzXQu6QB-9w@mail.gmail.com>

Hi Sahil,

On Fri, Aug 25, 2023 at 11:30 AM Aditya Toshniwal <
[email protected]> wrote:

> Hi Sahil,
>
> On Thu, Aug 24, 2023 at 8:28 PM Sahil Harpal <[email protected]>
> wrote:
>
>> On Sat, 19 Aug 2023 at 16:20, Sahil Harpal <[email protected]>
>> wrote:
>>
>>> On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>>
>>>>    - Sometimes graphs start from left and then shift to right. This
>>>>    issue I have reported in my initial review too.
>>>>
>>>> For StreamingChart should I ignore it for now?
>>> On Mon, 7 Aug 2023 at 17:12, Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> OK I thought you wanted the graph to go from left to right.  Yeah, I
>>>> have seen that glitch a few times (but rare). I think you can ignore it for
>>>> now, we can look into it once we get time. It is not a priority.
>>>>
>>>
>>> Or try the solution below?
>>> On Sun, 6 Aug 2023 at 13:21, Sahil Harpal <[email protected]>
>>> wrote:
>>>
>>>> I've tried one more approach here. If our data array is full, this
>>>> graph shifting won't happen. So, if we initialize our data list with null
>>>> values, there won't be any visible shift. What do you think about this
>>>> solution?
>>>>
>>> Can you please help me with this?
>>
> Let me apply your patch and try once.
>
Can you please share the rebased patch?

>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
> <https://www.enterprisedb.com/;
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"


view thread (106+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Pgadmin4 System Stats Extension Design
  In-Reply-To: <CAM9w-_k=NBQsLpUNy8WQrfJT26OH25ZrjLhaqg8ZZHAenfKNDA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox