Re: [pgAdmin][RM6207] Update JS dependencies

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM6207] Update JS dependencies
Date: Wed, 10 Feb 2021 16:37:01 +0530
Message-ID: <CAM9w-_kHUxRmOZmT3E55gadZrOKKAy8nzM+ZkP0C6tR7T8SxHA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDe1TkDUoUd1mgjtpqAMzCTRQF8-KKxa0Kr+8aqrJ_0w6w@mail.gmail.com>
References: <CAM9w-_kn5C3YBQW9F2cOHgHq=DprNEi1eN-JL2Cfkdc-auUDuw@mail.gmail.com>
	<CANxoLDeAACqnFHf=kRxXSej5VdnvoUziZON27LTjVQnDdPcHWw@mail.gmail.com>
	<CAM9w-_mmAdrVf+SAoEp_uKu6K3oM5RcHaYh1bHF31e_2vhLf8Q@mail.gmail.com>
	<CANxoLDfQbPJ68HkzXx+8rpGCHuvnh35n-iy8a_3e+YR-P5gDyQ@mail.gmail.com>
	<CAM9w-_n5K2L=oL8Dy+DVnrra-7YpYY=ScUvq75BKMPr6Vxd5LQ@mail.gmail.com>
	<CANxoLDe1TkDUoUd1mgjtpqAMzCTRQF8-KKxa0Kr+8aqrJ_0w6w@mail.gmail.com>

Hi,

The preview images for the themes are not visible after this. Please find
the attached patch to fix.

On Wed, Feb 10, 2021 at 1:47 PM Akshay Joshi <[email protected]>
wrote:

> Thanks, patch applied.
>
> On Wed, Feb 10, 2021 at 1:37 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi,
>>
>> The imagemin-gifsicle package is used to compress gif images. The latest
>> version of imagemin-gifsicle requires the binaries to be built from source,
>> which has a big dependency of dh-autoreconf.
>> pgAdmin has very few gifs. Instead of installing dh-autoreconf, I've
>> removed imagemin-gifsicle from package.json since the cost of installing
>> dh-autoreconf is more than the output of compressing gif.
>> Attached is the patch.
>>
>>
>> On Wed, Feb 10, 2021 at 12:51 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Wed, Feb 10, 2021 at 12:08 PM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Aditya
>>>>>
>>>>> One jasmine test is failing, please fix that and resend the patch.
>>>>>
>>>> It was failing because of a side effect of some other test case. Fixed.
>>>>
>>>> Please review.
>>>>
>>>>>
>>>>> On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached is the patch to update the JS dependencies to latest.
>>>>>> Changes include:
>>>>>> 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking
>>>>>> changes, so updated multiple webpack plugins and changed the config
>>>>>> accordingly.
>>>>>> 2) Replaced iconfont-webpack-plugin with a more maintained
>>>>>>  webfonts-loader.
>>>>>> 3)  Replaced deprecated babel-eslint with @babel/eslint-parser
>>>>>> 4)  Replaced optimize-css-assets-webpack-plugin with a more
>>>>>> maintained css-minimizer-webpack-plugin
>>>>>> 5) Updated all other JS packages and made the required code changes.
>>>>>>
>>>>>> Note, there is an update available for slickgrid and I tried to
>>>>>> update it. But it was not working as expected. So without wasting time,
>>>>>> I've not updated slickgrid, and can be updated as a separate task.
>>>>>>
>>>>>> Please review.
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>>>>> <http://edbpostgres.com;
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>> *pgAdmin Hacker | Principal Software Architect*
>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>>> <http://edbpostgres.com;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM6207.img.patch (372B, 3-RM6207.img.patch)
  download | inline diff:
diff --git a/web/webpack.config.js b/web/webpack.config.js
index 2f6cbc70c..e9a9d9e0f 100644
--- a/web/webpack.config.js
+++ b/web/webpack.config.js
@@ -69,7 +69,7 @@ const copyFiles = new CopyPlugin({
     pgadminThemesJson,
     {
       from: './pgadmin/static/scss/resources/**/*.png',
-      to: outputPath + '/img',
+      to: 'img/[name].[ext]',
     },
   ],
 });

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM6207] Update JS dependencies
  In-Reply-To: <CAM9w-_kHUxRmOZmT3E55gadZrOKKAy8nzM+ZkP0C6tR7T8SxHA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox