public inbox for [email protected]
help / color / mirror / Atom feedRequire sugeestion for #1235
16+ messages / 4 participants
[nested] [flat]
* Require sugeestion for #1235
@ 2025-01-30 10:33 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Yogesh Mahajan @ 2025-01-30 10:33 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
For issue #1235 <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query
Tool - Open file should open file in a new tab, here are two the options to
set preference for opening file.
1.Provide split button beside Open file button -
[image: Screenshot 2025-01-24 at 9.02.27 PM.png]
Pros -
a.Provides an easy way to set up the preference.
Cons -
a.One more addition of icon.
2.Provide option with save button dropdown -
[image: Screenshot 2025-01-30 at 2.51.10 PM.png]
Pros -
a.No need to add a split button for the open icon.
Cons -
a.Open operation is listed under save options.
3.Combine all file operations menu in single dropdown -
[image: Screenshot 2025-01-30 at 4.00.29 PM.png]
Pros -
a.All file related options are clubbed together like most of the editors.
b.Allows to add more file operations with the same dropdown.(Like Open
recent - however this is out of scope of this issue.)
Cons -
c.Can't think of any.
Could you please share your suggestions?
Thanks,
Yogesh Mahajan
EnterpriseDB
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
@ 2025-02-07 05:56 ` Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Yogesh Mahajan @ 2025-02-07 05:56 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
Could you please provide your feedback/suggestions?
Thanks,
Yogesh Mahajan
EnterpriseDB
On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
[email protected]> wrote:
> Hi,
>
> For issue #1235 <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query
> Tool - Open file should open file in a new tab, here are two the options to
> set preference for opening file.
> 1.Provide split button beside Open file button -
> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
> Pros -
> a.Provides an easy way to set up the preference.
> Cons -
> a.One more addition of icon.
>
>
> 2.Provide option with save button dropdown -
> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
> Pros -
> a.No need to add a split button for the open icon.
> Cons -
> a.Open operation is listed under save options.
>
>
> 3.Combine all file operations menu in single dropdown -
> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>
> Pros -
> a.All file related options are clubbed together like most of the editors.
> b.Allows to add more file operations with the same dropdown.(Like Open
> recent - however this is out of scope of this issue.)
> Cons -
> c.Can't think of any.
>
> Could you please share your suggestions?
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
@ 2025-02-07 06:30 ` Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Aditya Toshniwal @ 2025-02-07 06:30 UTC (permalink / raw)
To: Yogesh Mahajan <[email protected]>; +Cc: pgadmin-hackers
Hi Yogesh,
I am in favor of the "Combine all file operations menu in single dropdown"
solution. It is more in-line with menus of other editors and is more
intuitive.
On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
[email protected]> wrote:
> Hi,
>
> Could you please provide your feedback/suggestions?
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
> [email protected]> wrote:
>
>> Hi,
>>
>> For issue #1235 <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query
>> Tool - Open file should open file in a new tab, here are two the options to
>> set preference for opening file.
>> 1.Provide split button beside Open file button -
>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>> Pros -
>> a.Provides an easy way to set up the preference.
>> Cons -
>> a.One more addition of icon.
>>
>>
>> 2.Provide option with save button dropdown -
>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>> Pros -
>> a.No need to add a split button for the open icon.
>> Cons -
>> a.Open operation is listed under save options.
>>
>>
>> 3.Combine all file operations menu in single dropdown -
>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>
>> Pros -
>> a.All file related options are clubbed together like most of the editors.
>> b.Allows to add more file operations with the same dropdown.(Like Open
>> recent - however this is out of scope of this issue.)
>> Cons -
>> c.Can't think of any.
>>
>> Could you please share your suggestions?
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
@ 2025-02-07 06:42 ` Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Usman Khan @ 2025-02-07 06:42 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: Yogesh Mahajan <[email protected]>; pgadmin-hackers
Hi Yogesh,
I am in favour of the third option you pointed out above but in that case I
suggest changing the icon accordingly as the current icon usually gives
clue about 'file-opening' operation.
Thanks
On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Yogesh,
>
> I am in favor of the "Combine all file operations menu in single dropdown"
> solution. It is more in-line with menus of other editors and is more
> intuitive.
>
> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
> [email protected]> wrote:
>
>> Hi,
>>
>> Could you please provide your feedback/suggestions?
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> For issue #1235 <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query
>>> Tool - Open file should open file in a new tab, here are two the options to
>>> set preference for opening file.
>>> 1.Provide split button beside Open file button -
>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>> Pros -
>>> a.Provides an easy way to set up the preference.
>>> Cons -
>>> a.One more addition of icon.
>>>
>>>
>>> 2.Provide option with save button dropdown -
>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>> Pros -
>>> a.No need to add a split button for the open icon.
>>> Cons -
>>> a.Open operation is listed under save options.
>>>
>>>
>>> 3.Combine all file operations menu in single dropdown -
>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>
>>> Pros -
>>> a.All file related options are clubbed together like most of the editors.
>>> b.Allows to add more file operations with the same dropdown.(Like Open
>>> recent - however this is out of scope of this issue.)
>>> Cons -
>>> c.Can't think of any.
>>>
>>> Could you please share your suggestions?
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
> <https://www.enterprisedb.com/;
> "Don't Complain about Heat, Plant a TREE"
>
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
@ 2025-02-12 10:43 ` Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Yogesh Mahajan @ 2025-02-12 10:43 UTC (permalink / raw)
To: pgadmin-hackers; +Cc: Aditya Toshniwal <[email protected]>; Usman Khan <[email protected]>
Dave/Team,
I think, major votes are on the design #3 - Combine all file operations
menu in single dropdown.
Thanks,
Yogesh Mahajan
EnterpriseDB
On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <[email protected]> wrote:
> Hi Yogesh,
>
> I am in favour of the third option you pointed out above but in that case
> I suggest changing the icon accordingly as the current icon usually gives
> clue about 'file-opening' operation.
>
> Thanks
>
> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Yogesh,
>>
>> I am in favor of the "Combine all file operations menu in single
>> dropdown" solution. It is more in-line with menus of other editors and is
>> more intuitive.
>>
>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Could you please provide your feedback/suggestions?
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>>
>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> For issue #1235 <https://github.com/pgadmin-org/pgadmin4/issues/1235;
>>>> - Query Tool - Open file should open file in a new tab, here are two
>>>> the options to set preference for opening file.
>>>> 1.Provide split button beside Open file button -
>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>> Pros -
>>>> a.Provides an easy way to set up the preference.
>>>> Cons -
>>>> a.One more addition of icon.
>>>>
>>>>
>>>> 2.Provide option with save button dropdown -
>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>> Pros -
>>>> a.No need to add a split button for the open icon.
>>>> Cons -
>>>> a.Open operation is listed under save options.
>>>>
>>>>
>>>> 3.Combine all file operations menu in single dropdown -
>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>
>>>> Pros -
>>>> a.All file related options are clubbed together like most of the
>>>> editors.
>>>> b.Allows to add more file operations with the same dropdown.(Like Open
>>>> recent - however this is out of scope of this issue.)
>>>> Cons -
>>>> c.Can't think of any.
>>>>
>>>> Could you please share your suggestions?
>>>>
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> EnterpriseDB
>>>>
>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
@ 2025-02-12 11:05 ` Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Dave Page @ 2025-02-12 11:05 UTC (permalink / raw)
To: Yogesh Mahajan <[email protected]>; +Cc: pgadmin-hackers; Aditya Toshniwal <[email protected]>; Usman Khan <[email protected]>
On Wed, 12 Feb 2025 at 10:44, Yogesh Mahajan <
[email protected]> wrote:
> Dave/Team,
>
> I think, major votes are on the design #3 - Combine all file operations
> menu in single dropdown.
>
I don't recall ever seeing that design pattern. Do you have any examples?
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <[email protected]> wrote:
>
>> Hi Yogesh,
>>
>> I am in favour of the third option you pointed out above but in that case
>> I suggest changing the icon accordingly as the current icon usually gives
>> clue about 'file-opening' operation.
>>
>> Thanks
>>
>> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Yogesh,
>>>
>>> I am in favor of the "Combine all file operations menu in single
>>> dropdown" solution. It is more in-line with menus of other editors and is
>>> more intuitive.
>>>
>>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> Could you please provide your feedback/suggestions?
>>>>
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> EnterpriseDB
>>>>
>>>>
>>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> For issue #1235 <https://github.com/pgadmin-org/pgadmin4/issues/1235;
>>>>> - Query Tool - Open file should open file in a new tab, here are two
>>>>> the options to set preference for opening file.
>>>>> 1.Provide split button beside Open file button -
>>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>>> Pros -
>>>>> a.Provides an easy way to set up the preference.
>>>>> Cons -
>>>>> a.One more addition of icon.
>>>>>
>>>>>
>>>>> 2.Provide option with save button dropdown -
>>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>>> Pros -
>>>>> a.No need to add a split button for the open icon.
>>>>> Cons -
>>>>> a.Open operation is listed under save options.
>>>>>
>>>>>
>>>>> 3.Combine all file operations menu in single dropdown -
>>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>>
>>>>> Pros -
>>>>> a.All file related options are clubbed together like most of the
>>>>> editors.
>>>>> b.Allows to add more file operations with the same dropdown.(Like Open
>>>>> recent - however this is out of scope of this issue.)
>>>>> Cons -
>>>>> c.Can't think of any.
>>>>>
>>>>> Could you please share your suggestions?
>>>>>
>>>>> Thanks,
>>>>> Yogesh Mahajan
>>>>> EnterpriseDB
>>>>>
>>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>> <https://www.enterprisedb.com/;
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
@ 2025-02-12 11:24 ` Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Yogesh Mahajan @ 2025-02-12 11:24 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers; Aditya Toshniwal <[email protected]>; Usman Khan <[email protected]>
Hi Dave,
Design was inspired by the File menu of different editors. Here is a
screenshot for VS code. However, the Open option here always opens the file
in a new tab.
[image: Screenshot 2025-02-12 at 4.50.59 PM.png]
Thanks,
Yogesh Mahajan
EnterpriseDB
On Wed, Feb 12, 2025 at 4:35 PM Dave Page <[email protected]> wrote:
>
>
> On Wed, 12 Feb 2025 at 10:44, Yogesh Mahajan <
> [email protected]> wrote:
>
>> Dave/Team,
>>
>> I think, major votes are on the design #3 - Combine all file operations
>> menu in single dropdown.
>>
>
> I don't recall ever seeing that design pattern. Do you have any examples?
>
>
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <[email protected]> wrote:
>>
>>> Hi Yogesh,
>>>
>>> I am in favour of the third option you pointed out above but in that
>>> case I suggest changing the icon accordingly as the current icon usually
>>> gives clue about 'file-opening' operation.
>>>
>>> Thanks
>>>
>>> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Yogesh,
>>>>
>>>> I am in favor of the "Combine all file operations menu in single
>>>> dropdown" solution. It is more in-line with menus of other editors and is
>>>> more intuitive.
>>>>
>>>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Could you please provide your feedback/suggestions?
>>>>>
>>>>> Thanks,
>>>>> Yogesh Mahajan
>>>>> EnterpriseDB
>>>>>
>>>>>
>>>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> For issue #1235 <https://github.com/pgadmin-org/pgadmin4/issues/1235;
>>>>>> - Query Tool - Open file should open file in a new tab, here are
>>>>>> two the options to set preference for opening file.
>>>>>> 1.Provide split button beside Open file button -
>>>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>>>> Pros -
>>>>>> a.Provides an easy way to set up the preference.
>>>>>> Cons -
>>>>>> a.One more addition of icon.
>>>>>>
>>>>>>
>>>>>> 2.Provide option with save button dropdown -
>>>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>>>> Pros -
>>>>>> a.No need to add a split button for the open icon.
>>>>>> Cons -
>>>>>> a.Open operation is listed under save options.
>>>>>>
>>>>>>
>>>>>> 3.Combine all file operations menu in single dropdown -
>>>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>>>
>>>>>> Pros -
>>>>>> a.All file related options are clubbed together like most of the
>>>>>> editors.
>>>>>> b.Allows to add more file operations with the same dropdown.(Like
>>>>>> Open recent - however this is out of scope of this issue.)
>>>>>> Cons -
>>>>>> c.Can't think of any.
>>>>>>
>>>>>> Could you please share your suggestions?
>>>>>>
>>>>>> Thanks,
>>>>>> Yogesh Mahajan
>>>>>> EnterpriseDB
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>> <https://www.enterprisedb.com/;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> pgEdge: https://www.pgedge.com
>
>
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-02-12 at 4.50.59 PM.png (519.9K, 6-Screenshot%202025-02-12%20at%204.50.59%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
@ 2025-02-12 12:08 ` Dave Page <[email protected]>
2025-02-12 12:19 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Dave Page @ 2025-02-12 12:08 UTC (permalink / raw)
To: Yogesh Mahajan <[email protected]>; +Cc: pgadmin-hackers; Aditya Toshniwal <[email protected]>; Usman Khan <[email protected]>
Hi
On Wed, 12 Feb 2025 at 11:25, Yogesh Mahajan <
[email protected]> wrote:
> Hi Dave,
>
> Design was inspired by the File menu of different editors. Here is a
> screenshot for VS code. However, the Open option here always opens the file
> in a new tab.
>
A File menu is quite different from a toolbar button.
>
> [image: Screenshot 2025-02-12 at 4.50.59 PM.png]
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Wed, Feb 12, 2025 at 4:35 PM Dave Page <[email protected]> wrote:
>
>>
>>
>> On Wed, 12 Feb 2025 at 10:44, Yogesh Mahajan <
>> [email protected]> wrote:
>>
>>> Dave/Team,
>>>
>>> I think, major votes are on the design #3 - Combine all file operations
>>> menu in single dropdown.
>>>
>>
>> I don't recall ever seeing that design pattern. Do you have any examples?
>>
>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>>
>>> On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <[email protected]> wrote:
>>>
>>>> Hi Yogesh,
>>>>
>>>> I am in favour of the third option you pointed out above but in that
>>>> case I suggest changing the icon accordingly as the current icon usually
>>>> gives clue about 'file-opening' operation.
>>>>
>>>> Thanks
>>>>
>>>> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Yogesh,
>>>>>
>>>>> I am in favor of the "Combine all file operations menu in single
>>>>> dropdown" solution. It is more in-line with menus of other editors and is
>>>>> more intuitive.
>>>>>
>>>>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Could you please provide your feedback/suggestions?
>>>>>>
>>>>>> Thanks,
>>>>>> Yogesh Mahajan
>>>>>> EnterpriseDB
>>>>>>
>>>>>>
>>>>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> For issue #1235
>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query Tool
>>>>>>> - Open file should open file in a new tab, here are two the options to set
>>>>>>> preference for opening file.
>>>>>>> 1.Provide split button beside Open file button -
>>>>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>>>>> Pros -
>>>>>>> a.Provides an easy way to set up the preference.
>>>>>>> Cons -
>>>>>>> a.One more addition of icon.
>>>>>>>
>>>>>>>
>>>>>>> 2.Provide option with save button dropdown -
>>>>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>>>>> Pros -
>>>>>>> a.No need to add a split button for the open icon.
>>>>>>> Cons -
>>>>>>> a.Open operation is listed under save options.
>>>>>>>
>>>>>>>
>>>>>>> 3.Combine all file operations menu in single dropdown -
>>>>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>>>>
>>>>>>> Pros -
>>>>>>> a.All file related options are clubbed together like most of the
>>>>>>> editors.
>>>>>>> b.Allows to add more file operations with the same dropdown.(Like
>>>>>>> Open recent - however this is out of scope of this issue.)
>>>>>>> Cons -
>>>>>>> c.Can't think of any.
>>>>>>>
>>>>>>> Could you please share your suggestions?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Yogesh Mahajan
>>>>>>> EnterpriseDB
>>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>> <https://www.enterprisedb.com/;
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> pgEdge: https://www.pgedge.com
>>
>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-02-12 at 4.50.59 PM.png (519.9K, 6-Screenshot%202025-02-12%20at%204.50.59%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
@ 2025-02-12 12:19 ` Yogesh Mahajan <[email protected]>
2025-02-12 13:14 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Yogesh Mahajan @ 2025-02-12 12:19 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
Can you please provide your suggestions for the design? Does #1 or #2 look
good to you?
Thanks,
Yogesh Mahajan
EnterpriseDB
On Wed, Feb 12, 2025 at 5:39 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Wed, 12 Feb 2025 at 11:25, Yogesh Mahajan <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> Design was inspired by the File menu of different editors. Here is a
>> screenshot for VS code. However, the Open option here always opens the file
>> in a new tab.
>>
>
> A File menu is quite different from a toolbar button.
>
>
>>
>> [image: Screenshot 2025-02-12 at 4.50.59 PM.png]
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Wed, Feb 12, 2025 at 4:35 PM Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Wed, 12 Feb 2025 at 10:44, Yogesh Mahajan <
>>> [email protected]> wrote:
>>>
>>>> Dave/Team,
>>>>
>>>> I think, major votes are on the design #3 - Combine all file operations
>>>> menu in single dropdown.
>>>>
>>>
>>> I don't recall ever seeing that design pattern. Do you have any examples?
>>>
>>>
>>>>
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> EnterpriseDB
>>>>
>>>>
>>>> On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <[email protected]> wrote:
>>>>
>>>>> Hi Yogesh,
>>>>>
>>>>> I am in favour of the third option you pointed out above but in that
>>>>> case I suggest changing the icon accordingly as the current icon usually
>>>>> gives clue about 'file-opening' operation.
>>>>>
>>>>> Thanks
>>>>>
>>>>> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Yogesh,
>>>>>>
>>>>>> I am in favor of the "Combine all file operations menu in single
>>>>>> dropdown" solution. It is more in-line with menus of other editors and is
>>>>>> more intuitive.
>>>>>>
>>>>>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Could you please provide your feedback/suggestions?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Yogesh Mahajan
>>>>>>> EnterpriseDB
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> For issue #1235
>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query Tool
>>>>>>>> - Open file should open file in a new tab, here are two the options to set
>>>>>>>> preference for opening file.
>>>>>>>> 1.Provide split button beside Open file button -
>>>>>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>>>>>> Pros -
>>>>>>>> a.Provides an easy way to set up the preference.
>>>>>>>> Cons -
>>>>>>>> a.One more addition of icon.
>>>>>>>>
>>>>>>>>
>>>>>>>> 2.Provide option with save button dropdown -
>>>>>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>>>>>> Pros -
>>>>>>>> a.No need to add a split button for the open icon.
>>>>>>>> Cons -
>>>>>>>> a.Open operation is listed under save options.
>>>>>>>>
>>>>>>>>
>>>>>>>> 3.Combine all file operations menu in single dropdown -
>>>>>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>>>>>
>>>>>>>> Pros -
>>>>>>>> a.All file related options are clubbed together like most of the
>>>>>>>> editors.
>>>>>>>> b.Allows to add more file operations with the same dropdown.(Like
>>>>>>>> Open recent - however this is out of scope of this issue.)
>>>>>>>> Cons -
>>>>>>>> c.Can't think of any.
>>>>>>>>
>>>>>>>> Could you please share your suggestions?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Yogesh Mahajan
>>>>>>>> EnterpriseDB
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>>> <https://www.enterprisedb.com/;
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> pgEdge: https://www.pgedge.com
>>>
>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> pgEdge: https://www.pgedge.com
>
>
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-02-12 at 4.50.59 PM.png (519.9K, 6-Screenshot%202025-02-12%20at%204.50.59%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 12:19 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
@ 2025-02-12 13:14 ` Dave Page <[email protected]>
2025-02-13 09:29 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Dave Page @ 2025-02-12 13:14 UTC (permalink / raw)
To: Yogesh Mahajan <[email protected]>; +Cc: pgadmin-hackers
On Wed, 12 Feb 2025 at 12:20, Yogesh Mahajan <
[email protected]> wrote:
> Hi Dave,
>
> Can you please provide your suggestions for the design? Does #1 or #2 look
> good to you?
>
If the menu option in #1 is toggle-able, then I'd say that is the better
option.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Wed, Feb 12, 2025 at 5:39 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Wed, 12 Feb 2025 at 11:25, Yogesh Mahajan <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> Design was inspired by the File menu of different editors. Here is a
>>> screenshot for VS code. However, the Open option here always opens the file
>>> in a new tab.
>>>
>>
>> A File menu is quite different from a toolbar button.
>>
>>
>>>
>>> [image: Screenshot 2025-02-12 at 4.50.59 PM.png]
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>>
>>> On Wed, Feb 12, 2025 at 4:35 PM Dave Page <[email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Wed, 12 Feb 2025 at 10:44, Yogesh Mahajan <
>>>> [email protected]> wrote:
>>>>
>>>>> Dave/Team,
>>>>>
>>>>> I think, major votes are on the design #3 - Combine all file
>>>>> operations menu in single dropdown.
>>>>>
>>>>
>>>> I don't recall ever seeing that design pattern. Do you have any
>>>> examples?
>>>>
>>>>
>>>>>
>>>>> Thanks,
>>>>> Yogesh Mahajan
>>>>> EnterpriseDB
>>>>>
>>>>>
>>>>> On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <[email protected]> wrote:
>>>>>
>>>>>> Hi Yogesh,
>>>>>>
>>>>>> I am in favour of the third option you pointed out above but in that
>>>>>> case I suggest changing the icon accordingly as the current icon usually
>>>>>> gives clue about 'file-opening' operation.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Yogesh,
>>>>>>>
>>>>>>> I am in favor of the "Combine all file operations menu in single
>>>>>>> dropdown" solution. It is more in-line with menus of other editors and is
>>>>>>> more intuitive.
>>>>>>>
>>>>>>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Could you please provide your feedback/suggestions?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Yogesh Mahajan
>>>>>>>> EnterpriseDB
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> For issue #1235
>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query
>>>>>>>>> Tool - Open file should open file in a new tab, here are two the options to
>>>>>>>>> set preference for opening file.
>>>>>>>>> 1.Provide split button beside Open file button -
>>>>>>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>>>>>>> Pros -
>>>>>>>>> a.Provides an easy way to set up the preference.
>>>>>>>>> Cons -
>>>>>>>>> a.One more addition of icon.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 2.Provide option with save button dropdown -
>>>>>>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>>>>>>> Pros -
>>>>>>>>> a.No need to add a split button for the open icon.
>>>>>>>>> Cons -
>>>>>>>>> a.Open operation is listed under save options.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 3.Combine all file operations menu in single dropdown -
>>>>>>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>>>>>>
>>>>>>>>> Pros -
>>>>>>>>> a.All file related options are clubbed together like most of the
>>>>>>>>> editors.
>>>>>>>>> b.Allows to add more file operations with the same dropdown.(Like
>>>>>>>>> Open recent - however this is out of scope of this issue.)
>>>>>>>>> Cons -
>>>>>>>>> c.Can't think of any.
>>>>>>>>>
>>>>>>>>> Could you please share your suggestions?
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Yogesh Mahajan
>>>>>>>>> EnterpriseDB
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Thanks,
>>>>>>> Aditya Toshniwal
>>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>>>> <https://www.enterprisedb.com/;
>>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>>
>>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> pgEdge: https://www.pgedge.com
>>>>
>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> pgEdge: https://www.pgedge.com
>>
>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-02-12 at 4.50.59 PM.png (519.9K, 6-Screenshot%202025-02-12%20at%204.50.59%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 12:19 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 13:14 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
@ 2025-02-13 09:29 ` Yogesh Mahajan <[email protected]>
2025-02-13 10:50 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Yogesh Mahajan @ 2025-02-13 09:29 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Thanks Dave. Will go with #1 design.
Thanks,
Yogesh Mahajan
EnterpriseDB
On Wed, Feb 12, 2025 at 6:44 PM Dave Page <[email protected]> wrote:
>
>
> On Wed, 12 Feb 2025 at 12:20, Yogesh Mahajan <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> Can you please provide your suggestions for the design? Does #1 or #2
>> look good to you?
>>
>
> If the menu option in #1 is toggle-able, then I'd say that is the better
> option.
>
>
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Wed, Feb 12, 2025 at 5:39 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Wed, 12 Feb 2025 at 11:25, Yogesh Mahajan <
>>> [email protected]> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Design was inspired by the File menu of different editors. Here is a
>>>> screenshot for VS code. However, the Open option here always opens the file
>>>> in a new tab.
>>>>
>>>
>>> A File menu is quite different from a toolbar button.
>>>
>>>
>>>>
>>>> [image: Screenshot 2025-02-12 at 4.50.59 PM.png]
>>>>
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> EnterpriseDB
>>>>
>>>>
>>>> On Wed, Feb 12, 2025 at 4:35 PM Dave Page <[email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Wed, 12 Feb 2025 at 10:44, Yogesh Mahajan <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Dave/Team,
>>>>>>
>>>>>> I think, major votes are on the design #3 - Combine all file
>>>>>> operations menu in single dropdown.
>>>>>>
>>>>>
>>>>> I don't recall ever seeing that design pattern. Do you have any
>>>>> examples?
>>>>>
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Yogesh Mahajan
>>>>>> EnterpriseDB
>>>>>>
>>>>>>
>>>>>> On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <[email protected]> wrote:
>>>>>>
>>>>>>> Hi Yogesh,
>>>>>>>
>>>>>>> I am in favour of the third option you pointed out above but in that
>>>>>>> case I suggest changing the icon accordingly as the current icon usually
>>>>>>> gives clue about 'file-opening' operation.
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Yogesh,
>>>>>>>>
>>>>>>>> I am in favor of the "Combine all file operations menu in single
>>>>>>>> dropdown" solution. It is more in-line with menus of other editors and is
>>>>>>>> more intuitive.
>>>>>>>>
>>>>>>>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Could you please provide your feedback/suggestions?
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Yogesh Mahajan
>>>>>>>>> EnterpriseDB
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> For issue #1235
>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query
>>>>>>>>>> Tool - Open file should open file in a new tab, here are two the options to
>>>>>>>>>> set preference for opening file.
>>>>>>>>>> 1.Provide split button beside Open file button -
>>>>>>>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>>>>>>>> Pros -
>>>>>>>>>> a.Provides an easy way to set up the preference.
>>>>>>>>>> Cons -
>>>>>>>>>> a.One more addition of icon.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 2.Provide option with save button dropdown -
>>>>>>>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>>>>>>>> Pros -
>>>>>>>>>> a.No need to add a split button for the open icon.
>>>>>>>>>> Cons -
>>>>>>>>>> a.Open operation is listed under save options.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 3.Combine all file operations menu in single dropdown -
>>>>>>>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>>>>>>>
>>>>>>>>>> Pros -
>>>>>>>>>> a.All file related options are clubbed together like most of the
>>>>>>>>>> editors.
>>>>>>>>>> b.Allows to add more file operations with the same dropdown.(Like
>>>>>>>>>> Open recent - however this is out of scope of this issue.)
>>>>>>>>>> Cons -
>>>>>>>>>> c.Can't think of any.
>>>>>>>>>>
>>>>>>>>>> Could you please share your suggestions?
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Yogesh Mahajan
>>>>>>>>>> EnterpriseDB
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Thanks,
>>>>>>>> Aditya Toshniwal
>>>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>>>>> <https://www.enterprisedb.com/;
>>>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>>>
>>>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> pgAdmin: https://www.pgadmin.org
>>>>> PostgreSQL: https://www.postgresql.org
>>>>> pgEdge: https://www.pgedge.com
>>>>>
>>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> pgEdge: https://www.pgedge.com
>>>
>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> pgEdge: https://www.pgedge.com
>
>
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-02-12 at 4.50.59 PM.png (519.9K, 6-Screenshot%202025-02-12%20at%204.50.59%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 12:19 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 13:14 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-13 09:29 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
@ 2025-02-13 10:50 ` Aditya Toshniwal <[email protected]>
2025-02-13 11:00 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Aditya Toshniwal @ 2025-02-13 10:50 UTC (permalink / raw)
To: Yogesh Mahajan <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi Yogesh/Dave,
On Thu, Feb 13, 2025 at 4:17 PM Yogesh Mahajan <
[email protected]> wrote:
> Thanks Dave. Will go with #1 design.
>
It's not entirely what Dave is suggesting. He's suggesting the split button
dropdown should have a checkmark to set the default behaviour of the button.
@Dave Page <[email protected]> In that case it will contradict with Save
and Save As. Save As here is an extension of the menu and not the
behavioural option.
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Wed, Feb 12, 2025 at 6:44 PM Dave Page <[email protected]> wrote:
>
>>
>>
>> On Wed, 12 Feb 2025 at 12:20, Yogesh Mahajan <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> Can you please provide your suggestions for the design? Does #1 or #2
>>> look good to you?
>>>
>>
>> If the menu option in #1 is toggle-able, then I'd say that is the better
>> option.
>>
>>
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>>
>>> On Wed, Feb 12, 2025 at 5:39 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Wed, 12 Feb 2025 at 11:25, Yogesh Mahajan <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> Design was inspired by the File menu of different editors. Here is a
>>>>> screenshot for VS code. However, the Open option here always opens the file
>>>>> in a new tab.
>>>>>
>>>>
>>>> A File menu is quite different from a toolbar button.
>>>>
>>>>
>>>>>
>>>>> [image: Screenshot 2025-02-12 at 4.50.59 PM.png]
>>>>>
>>>>> Thanks,
>>>>> Yogesh Mahajan
>>>>> EnterpriseDB
>>>>>
>>>>>
>>>>> On Wed, Feb 12, 2025 at 4:35 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, 12 Feb 2025 at 10:44, Yogesh Mahajan <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Dave/Team,
>>>>>>>
>>>>>>> I think, major votes are on the design #3 - Combine all file
>>>>>>> operations menu in single dropdown.
>>>>>>>
>>>>>>
>>>>>> I don't recall ever seeing that design pattern. Do you have any
>>>>>> examples?
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Yogesh Mahajan
>>>>>>> EnterpriseDB
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Yogesh,
>>>>>>>>
>>>>>>>> I am in favour of the third option you pointed out above but in
>>>>>>>> that case I suggest changing the icon accordingly as the current icon
>>>>>>>> usually gives clue about 'file-opening' operation.
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>>
>>>>>>>> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Yogesh,
>>>>>>>>>
>>>>>>>>> I am in favor of the "Combine all file operations menu in single
>>>>>>>>> dropdown" solution. It is more in-line with menus of other editors and is
>>>>>>>>> more intuitive.
>>>>>>>>>
>>>>>>>>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> Could you please provide your feedback/suggestions?
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Yogesh Mahajan
>>>>>>>>>> EnterpriseDB
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> For issue #1235
>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query
>>>>>>>>>>> Tool - Open file should open file in a new tab, here are two the options to
>>>>>>>>>>> set preference for opening file.
>>>>>>>>>>> 1.Provide split button beside Open file button -
>>>>>>>>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>>>>>>>>> Pros -
>>>>>>>>>>> a.Provides an easy way to set up the preference.
>>>>>>>>>>> Cons -
>>>>>>>>>>> a.One more addition of icon.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 2.Provide option with save button dropdown -
>>>>>>>>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>>>>>>>>> Pros -
>>>>>>>>>>> a.No need to add a split button for the open icon.
>>>>>>>>>>> Cons -
>>>>>>>>>>> a.Open operation is listed under save options.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 3.Combine all file operations menu in single dropdown -
>>>>>>>>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>>>>>>>>
>>>>>>>>>>> Pros -
>>>>>>>>>>> a.All file related options are clubbed together like most of the
>>>>>>>>>>> editors.
>>>>>>>>>>> b.Allows to add more file operations with the same
>>>>>>>>>>> dropdown.(Like Open recent - however this is out of scope of this issue.)
>>>>>>>>>>> Cons -
>>>>>>>>>>> c.Can't think of any.
>>>>>>>>>>>
>>>>>>>>>>> Could you please share your suggestions?
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Yogesh Mahajan
>>>>>>>>>>> EnterpriseDB
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Thanks,
>>>>>>>>> Aditya Toshniwal
>>>>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>>>>>> <https://www.enterprisedb.com/;
>>>>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>> pgEdge: https://www.pgedge.com
>>>>>>
>>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> pgEdge: https://www.pgedge.com
>>>>
>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> pgEdge: https://www.pgedge.com
>>
>>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-02-12 at 4.50.59 PM.png (519.9K, 6-Screenshot%202025-02-12%20at%204.50.59%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 12:19 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 13:14 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-13 09:29 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-13 10:50 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
@ 2025-02-13 11:00 ` Dave Page <[email protected]>
2025-02-13 11:24 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Dave Page @ 2025-02-13 11:00 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: Yogesh Mahajan <[email protected]>; pgadmin-hackers
On Thu, 13 Feb 2025 at 10:51, Aditya Toshniwal <
[email protected]> wrote:
> Hi Yogesh/Dave,
>
> On Thu, Feb 13, 2025 at 4:17 PM Yogesh Mahajan <
> [email protected]> wrote:
>
>> Thanks Dave. Will go with #1 design.
>>
> It's not entirely what Dave is suggesting. He's suggesting the split
> button dropdown should have a checkmark to set the default behaviour of the
> button.
> @Dave Page <[email protected]> In that case it will contradict with Save
> and Save As. Save As here is an extension of the menu and not the
> behavioural option.
>
I don't think it contradicts. Open vs. Open In new Tab is, for the most
part, a choice that most users will generally build into their workflow,
whereas Save vs. Save As choices will more commonly depend on the situation
I believe.
In other words, I'm more likely to select the Open behaviour I prefer, and
use it all the time, but the Save behaviour is dependent on what I'm doing
at the time.
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 12:19 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 13:14 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-13 09:29 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-13 10:50 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-13 11:00 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
@ 2025-02-13 11:24 ` Aditya Toshniwal <[email protected]>
2025-02-13 11:36 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Aditya Toshniwal @ 2025-02-13 11:24 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Yogesh Mahajan <[email protected]>; pgadmin-hackers
Hi Dave,
On Thu, Feb 13, 2025 at 4:30 PM Dave Page <[email protected]> wrote:
>
>
> On Thu, 13 Feb 2025 at 10:51, Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Yogesh/Dave,
>>
>> On Thu, Feb 13, 2025 at 4:17 PM Yogesh Mahajan <
>> [email protected]> wrote:
>>
>>> Thanks Dave. Will go with #1 design.
>>>
>> It's not entirely what Dave is suggesting. He's suggesting the split
>> button dropdown should have a checkmark to set the default behaviour of the
>> button.
>> @Dave Page <[email protected]> In that case it will contradict with Save
>> and Save As. Save As here is an extension of the menu and not the
>> behavioural option.
>>
>
> I don't think it contradicts. Open vs. Open In new Tab is, for the most
> part, a choice that most users will generally build into their workflow,
> whereas Save vs. Save As choices will more commonly depend on the situation
> I believe.
>
> In other words, I'm more likely to select the Open behaviour I prefer, and
> use it all the time, but the Save behaviour is dependent on what I'm doing
> at the time.
>
And what about recent files? We're going to add that as well in future.
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> pgEdge: https://www.pgedge.com
>
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 12:19 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 13:14 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-13 09:29 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-13 10:50 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-13 11:00 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-13 11:24 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
@ 2025-02-13 11:36 ` Dave Page <[email protected]>
2025-02-14 07:53 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 16+ messages in thread
From: Dave Page @ 2025-02-13 11:36 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: Yogesh Mahajan <[email protected]>; pgadmin-hackers
On Thu, 13 Feb 2025 at 11:25, Aditya Toshniwal <
[email protected]> wrote:
> Hi Dave,
>
> On Thu, Feb 13, 2025 at 4:30 PM Dave Page <[email protected]> wrote:
>
>>
>>
>> On Thu, 13 Feb 2025 at 10:51, Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Yogesh/Dave,
>>>
>>> On Thu, Feb 13, 2025 at 4:17 PM Yogesh Mahajan <
>>> [email protected]> wrote:
>>>
>>>> Thanks Dave. Will go with #1 design.
>>>>
>>> It's not entirely what Dave is suggesting. He's suggesting the split
>>> button dropdown should have a checkmark to set the default behaviour of the
>>> button.
>>> @Dave Page <[email protected]> In that case it will contradict with
>>> Save and Save As. Save As here is an extension of the menu and not the
>>> behavioural option.
>>>
>>
>> I don't think it contradicts. Open vs. Open In new Tab is, for the most
>> part, a choice that most users will generally build into their workflow,
>> whereas Save vs. Save As choices will more commonly depend on the situation
>> I believe.
>>
>> In other words, I'm more likely to select the Open behaviour I prefer,
>> and use it all the time, but the Save behaviour is dependent on what I'm
>> doing at the time.
>>
> And what about recent files? We're going to add that as well in future.
>
They can just be listed on the same menu no?
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com
^ permalink raw reply [nested|flat] 16+ messages in thread
* Re: Require sugeestion for #1235
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Re: Require sugeestion for #1235 Usman Khan <[email protected]>
2025-02-12 10:43 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 11:24 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-12 12:19 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-12 13:14 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-13 09:29 ` Re: Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-13 10:50 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-13 11:00 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
2025-02-13 11:24 ` Re: Require sugeestion for #1235 Aditya Toshniwal <[email protected]>
2025-02-13 11:36 ` Re: Require sugeestion for #1235 Dave Page <[email protected]>
@ 2025-02-14 07:53 ` Aditya Toshniwal <[email protected]>
0 siblings, 0 replies; 16+ messages in thread
From: Aditya Toshniwal @ 2025-02-14 07:53 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Yogesh Mahajan <[email protected]>; pgadmin-hackers
On Thu, Feb 13, 2025 at 5:06 PM Dave Page <[email protected]> wrote:
>
>
> On Thu, 13 Feb 2025 at 11:25, Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> On Thu, Feb 13, 2025 at 4:30 PM Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Thu, 13 Feb 2025 at 10:51, Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Yogesh/Dave,
>>>>
>>>> On Thu, Feb 13, 2025 at 4:17 PM Yogesh Mahajan <
>>>> [email protected]> wrote:
>>>>
>>>>> Thanks Dave. Will go with #1 design.
>>>>>
>>>> It's not entirely what Dave is suggesting. He's suggesting the split
>>>> button dropdown should have a checkmark to set the default behaviour of the
>>>> button.
>>>> @Dave Page <[email protected]> In that case it will contradict with
>>>> Save and Save As. Save As here is an extension of the menu and not the
>>>> behavioural option.
>>>>
>>>
>>> I don't think it contradicts. Open vs. Open In new Tab is, for the most
>>> part, a choice that most users will generally build into their workflow,
>>> whereas Save vs. Save As choices will more commonly depend on the situation
>>> I believe.
>>>
>>> In other words, I'm more likely to select the Open behaviour I prefer,
>>> and use it all the time, but the Save behaviour is dependent on what I'm
>>> doing at the time.
>>>
>> And what about recent files? We're going to add that as well in future.
>>
>
> They can just be listed on the same menu no?
>
OK.
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> pgEdge: https://www.pgedge.com
>
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"
^ permalink raw reply [nested|flat] 16+ messages in thread
end of thread, other threads:[~2025-02-14 07:53 UTC | newest]
Thread overview: 16+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-01-30 10:33 Require sugeestion for #1235 Yogesh Mahajan <[email protected]>
2025-02-07 05:56 ` Yogesh Mahajan <[email protected]>
2025-02-07 06:30 ` Aditya Toshniwal <[email protected]>
2025-02-07 06:42 ` Usman Khan <[email protected]>
2025-02-12 10:43 ` Yogesh Mahajan <[email protected]>
2025-02-12 11:05 ` Dave Page <[email protected]>
2025-02-12 11:24 ` Yogesh Mahajan <[email protected]>
2025-02-12 12:08 ` Dave Page <[email protected]>
2025-02-12 12:19 ` Yogesh Mahajan <[email protected]>
2025-02-12 13:14 ` Dave Page <[email protected]>
2025-02-13 09:29 ` Yogesh Mahajan <[email protected]>
2025-02-13 10:50 ` Aditya Toshniwal <[email protected]>
2025-02-13 11:00 ` Dave Page <[email protected]>
2025-02-13 11:24 ` Aditya Toshniwal <[email protected]>
2025-02-13 11:36 ` Dave Page <[email protected]>
2025-02-14 07:53 ` Aditya Toshniwal <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox