public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Date: Wed, 20 Nov 2019 11:58:57 +0530
Message-ID: <CAM9w-_kThLq0HY-oJYL3fcGzoNEtUbN9OdCjgnn6cvVJ2qCm0g@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDe2JeR6DNnm+7b9TsbQ113AR1AbBb2Ab-cQV_zyDTaxTA@mail.gmail.com>
References: <CAM9w-_m5mfGiu1mUH28Hngi1riYTmTurNoxz-qWOH7g+zRFOhA@mail.gmail.com>
<CAM9w-_nNp1BAy9usd1j9xP+gKSrR-_BLMwoCUzngx0-8HcbRmw@mail.gmail.com>
<CANxoLDcAnDBA-a5577wo0QcXVq0bmk+DPKv=K7nekRiejcPXzA@mail.gmail.com>
<CA+OCxozmGJmLvH1g0vCn09OOTiUTnZbZ_nPHU0dNU1pRXYjQnA@mail.gmail.com>
<CA+OCxow-ZLN8sKETj5Bf7Y4gTWm+q7NtugfpG3_zt-KHzpvbJA@mail.gmail.com>
<CAM9w-_=fuDGpPmFLg=w--LCF1jACMuWcqGb5BFX57AhE-Vm4xQ@mail.gmail.com>
<CA+OCxoxKgZFwtqhc89Pu3T_aPWkTmt4_rO32WuewaDLqoLM7wg@mail.gmail.com>
<CAM9w-_=OHmdrWRJWnwN5_cfNPfak+34=MwbiHpez9HBUtk2ZzQ@mail.gmail.com>
<CAM9w-_kma2zGbk-3dr68z2O4ZvfJEmt5i8y9tgQwcMOvshWtaw@mail.gmail.com>
<CAM9w-_=M1G-m-vb_7j1G1LtEis6aT8KakHmWGxJmRfUV-oZ5ug@mail.gmail.com>
<CAM9w-_ntcD1bJkm3h3n3S9TO+GxGxmJPY17Qi079Z87x9b_W4g@mail.gmail.com>
<CANxoLDfgiKoaZyHuDAMier0yjrmnYCc9Diht+yvhWQau1Xr05Q@mail.gmail.com>
<CA+OCxowQ_qPmaLoCwq6ca0KzojaO7U49yJna3_rNJqUp-wTYJA@mail.gmail.com>
<CAM9w-_=18dvyzS4wB=8es_dMTr9O0bnVq7VD0OC1JgxVsXJqXA@mail.gmail.com>
<CA+OCxowN-7O=LoKoDjfEUp8J_cij7zd+=rn99n4=rYbEJXbuvw@mail.gmail.com>
<CAM9w-_=iOUWtvLJ3vq=McZZYyWRkjoF_HcpDdHE8=fUE-jGMyw@mail.gmail.com>
<CA+OCxoz=TRA8UHjaQycqPcdsRmHwLz72gwBPitY2nQMuvBw3-g@mail.gmail.com>
<CAM9w-_mfFq2wKZwTvzRaEPre+Shz-ESSEhy3CA-SuFmcvNCAzQ@mail.gmail.com>
<CA+OCxoxf0maw2s1cCfdNDzDfazP_13de0AS1g3dixOZMTmBudw@mail.gmail.com>
<CAM9w-_=B-DE2F2rAZLr1uhiedLS2Fxe0v85YsPm7fKtZgVYKDg@mail.gmail.com>
<CANxoLDfx5rgaoPSPhn1EyvZcT-gpBqvJvNN+GwGnmRiSFQKRmw@mail.gmail.com>
<CAM9w-_=tKBBMaJmKSaRnhrdCWjk-D+SWd=BxwxYuHJwCv8nrmw@mail.gmail.com>
<CA+OCxow_BX1GNybfoS61Vax+d8AKynBz_eSzUvoTW3XuVWNk7Q@mail.gmail.com>
<CAM9w-_=ZhXytpL=q5mcb47HVfJeOm1f0DvhodFXwHei5H9a52w@mail.gmail.com>
<CAM9w-_=Jy6kpDyg-FGGz961-djDMKe6hKFa51A5jAbhoygKYVg@mail.gmail.com>
<CANxoLDe2JeR6DNnm+7b9TsbQ113AR1AbBb2Ab-cQV_zyDTaxTA@mail.gmail.com>
Hi Hackers,
pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run bundle"
and is copied to generated directory also. This file is required for themes
to show up.
Currently, pgadmin.themes.json file is referred
from web/pgadmin/misc/themes directory by the app. It is better to refer
from generated directory instead so that it is not missed in the pgAdmin
distribution phase. The pgAdmin 4.15 wheel distro is not having this file
in web/pgadmin/misc/themes directory and so themes are not available in it.
Attached is the patch to fix this.
On Wed, Nov 13, 2019 at 11:36 AM Akshay Joshi <[email protected]>
wrote:
> Thanks, patch applied.
>
> On Wed, Nov 13, 2019 at 10:46 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to set browser autofill color. I've used primary
>> light color to highlight autofill. Note that, this works only on webkit
>> browsers.
>> Kindly review.
>>
>> On Wed, Nov 13, 2019 at 10:03 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> On Tue, Nov 12, 2019 at 7:29 PM Dave Page <[email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Nov 12, 2019 at 1:47 PM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is the patch to customize the scrollbar styling. A new SASS
>>>>> variable added - $scrollbar-base-color is added to change the color as per
>>>>> theme.
>>>>> Please note, customization of scrollbar works only in webkit browsers
>>>>> like Chrome, Safari. Mozilla does not have any way to customize.
>>>>>
>>>>
>>>> That looks much nicer :-).
>>>>
>>>> One more issue I just spotted - I'm guessing it's specific to Alertify
>>>> dialogues:
>>>>
>>>> [image: Screenshot 2019-11-12 at 13.57.34.png]
>>>>
>>> This is your browser autofill which is changing the color and not the
>>> issue with the dialogs.
>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[image/png] Screenshot 2019-11-12 at 13.57.34.png (24.3K, 3-Screenshot%202019-11-12%20at%2013.57.34.png)
download | view image
[application/octet-stream] RM4348.part6.patch (520B, 4-RM4348.part6.patch)
download | inline diff:
diff --git a/web/pgadmin/misc/themes/__init__.py b/web/pgadmin/misc/themes/__init__.py
index 301f0f665..37559da16 100644
--- a/web/pgadmin/misc/themes/__init__.py
+++ b/web/pgadmin/misc/themes/__init__.py
@@ -4,8 +4,10 @@ from pgadmin.utils.preferences import Preferences
def get_all_themes():
+ # Themes file is copied in generated directory
theme_file_path = os.path.join(
os.path.dirname(os.path.realpath(__file__)),
+ '../../static/js/generated',
'pgadmin.themes.json'
)
view thread (31+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
In-Reply-To: <CAM9w-_kThLq0HY-oJYL3fcGzoNEtUbN9OdCjgnn6cvVJ2qCm0g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox