public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help
Date: Thu, 10 Jan 2019 12:35:17 +0530
Message-ID: <CAM9w-_m7rSty6uH9AOAp7kmD-bpV81pr41r6Q_qwkyidw-YOhA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxaggtGMhTsh-=58WLqm30Tm4rgAEsguAzVemDoYF-t_g@mail.gmail.com>
References: <CAM9w-_mawt4Df8TRXbfC7AYxZJBhJKCSu37NrU+pfHky00qvkw@mail.gmail.com>
<CA+OCxoxaggtGMhTsh-=58WLqm30Tm4rgAEsguAzVemDoYF-t_g@mail.gmail.com>
Hi Hackers,
Attached is the patch to fix jasmine test cases failures.
Kindly review.
On Thu, Jan 10, 2019 at 11:21 AM Dave Page <[email protected]> wrote:
> Thanks, applied.
>
> On Wed, Jan 9, 2019 at 6:31 PM Aditya Toshniwal
> <[email protected]> wrote:
> >
> > Hi Hackers,
> >
> > Attached is a tiny patch to fix the Postgres help for backup and restore
> dialog.
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > Software Engineer | EnterpriseDB Software Solutions | Pune
> > "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachments:
[application/octet-stream] RM3861.jstests.patch (1.7K, 3-RM3861.jstests.patch)
download | inline diff:
diff --git a/web/regression/javascript/backup/backup_dialog_wrapper_spec.js b/web/regression/javascript/backup/backup_dialog_wrapper_spec.js
index 3ac1c7e7..720ee32c 100644
--- a/web/regression/javascript/backup/backup_dialog_wrapper_spec.js
+++ b/web/regression/javascript/backup/backup_dialog_wrapper_spec.js
@@ -260,7 +260,7 @@ describe('BackupDialogWrapper', () => {
'dialog_help',
'http://someurl',
pgBrowser.Nodes['server'],
- serverTreeNode,
+ serverTreeNode.getHtmlIdentifier(),
'some label'
);
});
@@ -303,7 +303,7 @@ describe('BackupDialogWrapper', () => {
'object_help',
'http://someurl',
pgBrowser.Nodes['server'],
- serverTreeNode,
+ serverTreeNode.getHtmlIdentifier(),
'some label'
);
});
diff --git a/web/regression/javascript/restore/restore_dialog_wrapper_spec.js b/web/regression/javascript/restore/restore_dialog_wrapper_spec.js
index a8be9295..df6b9160 100644
--- a/web/regression/javascript/restore/restore_dialog_wrapper_spec.js
+++ b/web/regression/javascript/restore/restore_dialog_wrapper_spec.js
@@ -252,7 +252,7 @@ describe('RestoreDialogWrapper', () => {
'dialog_help',
'http://someurl',
pgBrowser.Nodes['server'],
- serverTreeNode,
+ serverTreeNode.getHtmlIdentifier(),
'some label'
);
});
@@ -294,7 +294,7 @@ describe('RestoreDialogWrapper', () => {
'object_help',
'http://someurl',
pgBrowser.Nodes['server'],
- serverTreeNode,
+ serverTreeNode.getHtmlIdentifier(),
'some label'
);
});
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help
In-Reply-To: <CAM9w-_m7rSty6uH9AOAp7kmD-bpV81pr41r6Q_qwkyidw-YOhA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox