public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help 4+ messages / 2 participants [nested] [flat]
* [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help @ 2019-01-09 13:00 Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2019-01-09 13:00 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Attached is a tiny patch to fix the Postgres help for backup and restore dialog. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" Attachments: [application/octet-stream] backup_restore_help.patch (1.2K, 3-backup_restore_help.patch) download | inline diff: diff --git a/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js b/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js index d25fb717..931d0a02 100644 --- a/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js +++ b/web/pgadmin/tools/backup/static/js/backup_dialog_wrapper.js @@ -114,7 +114,7 @@ export class BackupDialogWrapper extends DialogWrapper { event.button.element.name, event.button.element.getAttribute('url'), node, - selectedTreeNode, + selectedTreeNode.getHtmlIdentifier(), event.button.element.getAttribute('label') ); return; diff --git a/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js b/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js index 1ed88b96..0d211aec 100644 --- a/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js +++ b/web/pgadmin/tools/restore/static/js/restore_dialog_wrapper.js @@ -114,7 +114,7 @@ export class RestoreDialogWrapper extends DialogWrapper { event.button.element.name, event.button.element.getAttribute('url'), node, - selectedTreeNode, + selectedTreeNode.getHtmlIdentifier(), event.button.element.getAttribute('label') ); return; ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help @ 2019-01-10 05:51 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Dave Page @ 2019-01-10 05:51 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Thanks, applied. On Wed, Jan 9, 2019 at 6:31 PM Aditya Toshniwal <[email protected]> wrote: > > Hi Hackers, > > Attached is a tiny patch to fix the Postgres help for backup and restore dialog. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help @ 2019-01-10 07:05 Aditya Toshniwal <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2019-01-10 07:05 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Hi Hackers, Attached is the patch to fix jasmine test cases failures. Kindly review. On Thu, Jan 10, 2019 at 11:21 AM Dave Page <[email protected]> wrote: > Thanks, applied. > > On Wed, Jan 9, 2019 at 6:31 PM Aditya Toshniwal > <[email protected]> wrote: > > > > Hi Hackers, > > > > Attached is a tiny patch to fix the Postgres help for backup and restore > dialog. > > > > -- > > Thanks and Regards, > > Aditya Toshniwal > > Software Engineer | EnterpriseDB Software Solutions | Pune > > "Don't Complain about Heat, Plant a tree" > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" Attachments: [application/octet-stream] RM3861.jstests.patch (1.7K, 3-RM3861.jstests.patch) download | inline diff: diff --git a/web/regression/javascript/backup/backup_dialog_wrapper_spec.js b/web/regression/javascript/backup/backup_dialog_wrapper_spec.js index 3ac1c7e7..720ee32c 100644 --- a/web/regression/javascript/backup/backup_dialog_wrapper_spec.js +++ b/web/regression/javascript/backup/backup_dialog_wrapper_spec.js @@ -260,7 +260,7 @@ describe('BackupDialogWrapper', () => { 'dialog_help', 'http://someurl', pgBrowser.Nodes['server'], - serverTreeNode, + serverTreeNode.getHtmlIdentifier(), 'some label' ); }); @@ -303,7 +303,7 @@ describe('BackupDialogWrapper', () => { 'object_help', 'http://someurl', pgBrowser.Nodes['server'], - serverTreeNode, + serverTreeNode.getHtmlIdentifier(), 'some label' ); }); diff --git a/web/regression/javascript/restore/restore_dialog_wrapper_spec.js b/web/regression/javascript/restore/restore_dialog_wrapper_spec.js index a8be9295..df6b9160 100644 --- a/web/regression/javascript/restore/restore_dialog_wrapper_spec.js +++ b/web/regression/javascript/restore/restore_dialog_wrapper_spec.js @@ -252,7 +252,7 @@ describe('RestoreDialogWrapper', () => { 'dialog_help', 'http://someurl', pgBrowser.Nodes['server'], - serverTreeNode, + serverTreeNode.getHtmlIdentifier(), 'some label' ); }); @@ -294,7 +294,7 @@ describe('RestoreDialogWrapper', () => { 'object_help', 'http://someurl', pgBrowser.Nodes['server'], - serverTreeNode, + serverTreeNode.getHtmlIdentifier(), 'some label' ); }); ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help @ 2019-01-10 09:33 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Dave Page @ 2019-01-10 09:33 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Thanks - applied. On Thu, Jan 10, 2019 at 12:35 PM Aditya Toshniwal <[email protected]> wrote: > > Hi Hackers, > > Attached is the patch to fix jasmine test cases failures. > Kindly review. > > On Thu, Jan 10, 2019 at 11:21 AM Dave Page <[email protected]> wrote: >> >> Thanks, applied. >> >> On Wed, Jan 9, 2019 at 6:31 PM Aditya Toshniwal >> <[email protected]> wrote: >> > >> > Hi Hackers, >> > >> > Attached is a tiny patch to fix the Postgres help for backup and restore dialog. >> > >> > -- >> > Thanks and Regards, >> > Aditya Toshniwal >> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree" >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2019-01-10 09:33 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-01-09 13:00 [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help Aditya Toshniwal <[email protected]> 2019-01-10 05:51 ` Dave Page <[email protected]> 2019-01-10 07:05 ` Aditya Toshniwal <[email protected]> 2019-01-10 09:33 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox