Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)
Date: Thu, 30 May 2019 14:10:05 +0530
Message-ID: <CAM9w-_ms1QP0+mkhKKbhibCRjcKwPHCOVske5co5NxuXLUFk2g@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoy-oycK69WNBLT0AC1=CpMt1HKvYz2_qmb1MxmwdJnXZQ@mail.gmail.com>
References: <CAM9w-_=e8+iiEP0+pTv0htRHhUjupfK6N9dFS1wQNG6MBCq4Vw@mail.gmail.com>
	<CA+OCxoz+C3JKXMu2u7taYGSsSVAEQh20w2mDyxqLSKbbFq=21g@mail.gmail.com>
	<CAM9w-_khKH+yqMZA2AnJABEV1ntaXvMsYsAX_Jy30oSN=MnoDw@mail.gmail.com>
	<CAM9w-_mLi-NzgBBH1gbve4Xqg6-gjOLpVvh_zkMzfqai=se-pw@mail.gmail.com>
	<CA+OCxoyGY0SVN8CQBkXRjh+Tx=+Z8ekZfaFH2+eUY1uC5fQj9Q@mail.gmail.com>
	<CAM9w-_m7jeih1dF-8mfCe1OREW2WcHmnn5nM1D2SgfLFkDwwrg@mail.gmail.com>
	<CA+OCxoy-oycK69WNBLT0AC1=CpMt1HKvYz2_qmb1MxmwdJnXZQ@mail.gmail.com>

Hi,

On Thu, May 30, 2019 at 1:38 AM Dave Page <[email protected]> wrote:

> Hi
>
> On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi,
>>
>> On Thu, May 23, 2019 at 1:31 PM Dave Page <[email protected]> wrote:
>>
>>> Hi,
>>>
>>> On further testing, this doesn't seem to be working as expected.
>>> Alt+Shift+] or [ in the query tool are typing ’ and ” and not changing the
>>> tab. If I switch to a non-input tab (e.g. History), they still don't work.
>>>
>> I am not able to simulate the quotes problem, but I have made a few
>> corrections to fix the switching.
>> Attached is the updated patch, kindly review.
>>
>
> Alt+Shift+[ (or ]) don[t work at all for me now :-(
>
Did you restart the server after applying the patch ?  What shortcut does
preferences show ?

>
>
>>
>>> Alt+Shift+Tab changes the panel successfully though, and does cause the
>>> flash as expected.
>>>
>>> I'm using Chrome 74.0.3729.131 on Mojave.
>>>
>>> On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> Attached is the updated patch with doc changes.
>>>>
>>>> On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> On Tue, May 21, 2019 at 5:32 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Hackers,
>>>>>>>
>>>>>>> Attached is the patch to fix the accessibility issue in query tool.
>>>>>>>
>>>>>>> The query tool can be completely restructured unlike previously
>>>>>>> where query tool used to stick at top and other tabs in the bottom.
>>>>>>> - I have added a new shortcut to switch between frames if in query
>>>>>>> tool the tab positions are changed. On switching the frames, the frame will
>>>>>>> blink to show it is focussed.
>>>>>>> - In the frame, you can switch tab same as previous. The tabs in SQL
>>>>>>> editor are cyclic now, which means if you execute shortcut to go right on
>>>>>>> the last tab then it will cycle to first tab.
>>>>>>> - I have also changed the default shortcut to switch between tabs
>>>>>>> from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we have in
>>>>>>> browser tabs.
>>>>>>> - Similar changes done for debugger also.
>>>>>>>
>>>>>>
>>>>>> Shouldn't there be documentation changes to go with this?
>>>>>>
>>>>> Yes, definitely :P
>>>>> Will send the updated patch.
>>>>>
>>>>>>
>>>>>> Otherwise, it seems to work :-)
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thanks and Regards,
>>>>> Aditya Toshniwal
>>>>> Software Engineer | EnterpriseDB India | Pune
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)
  In-Reply-To: <CAM9w-_ms1QP0+mkhKKbhibCRjcKwPHCOVske5co5NxuXLUFk2g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox