Re: Require suggestions for Issue #2874

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Rohit Bhati <[email protected]>
Cc: Dave Page <[email protected]>
Cc: [email protected]
Subject: Re: Require suggestions for Issue #2874
Date: Thu, 12 Sep 2024 09:13:03 +0530
Message-ID: <CAM9w-_n28JTZ9JP9e30qVoYiExF+i6LsEWA-dVtad+AsMz2gWg@mail.gmail.com> (raw)
In-Reply-To: <CABscKVi4N--wGb3ToFpFZuQtiRFNrxZ2zGSB9X1dG8ODpv0PAg@mail.gmail.com>
References: <CABscKVgnoB8=KcYSa0tp8LAwdw4Gq4-G5ywcmWz353jtH8RH1A@mail.gmail.com>
	<CABscKVg+1gh1CjPPX8k4_9A407hzfd8DTbP7e0U+-jcoO7awQg@mail.gmail.com>
	<CA+OCxoxiy6xc9V9qUOP0f5LSA22PwHyNFWXjMvBT10EHjF5F+g@mail.gmail.com>
	<CABscKViG4=vECzrEhQNKbwGKJwPrWDn3isw-mPA5fNphw-G6=Q@mail.gmail.com>
	<CA+OCxoxOzUKjPF8pC=z4vjVKegBzNUDtGtwc5tewmtz2MfMhMw@mail.gmail.com>
	<CABscKViS50079irxJfgL5ARtd5g4D86z+OwJ7huY7nRJbB2rLQ@mail.gmail.com>
	<CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com>
	<CA+OCxoy5Mz53vyebx+2V0U3KH9f+Pd-p-HWoM7dMnUYNrjP-nw@mail.gmail.com>
	<CAFOhELcYWCYdQ9jF6sV=PkZJ-hkF7Pxt-a3Gi61JzFx=AoGb6w@mail.gmail.com>
	<CABscKViGC-C6dBx6c=M3TQvCXrM+KGXWED7cj9BX2uB7qNb0Tg@mail.gmail.com>
	<CA+OCxoxc1uu5yddUc8SOrkj8-O5ZY4HUtJCjqXt2H292ema1nQ@mail.gmail.com>
	<CABscKVihMj687AzJh3mWt6Dt+EiO=qanhp3bQUtQmqqv3Hg07g@mail.gmail.com>
	<CA+OCxoxNJuNuqhcOpzQUdDFTsirGpZKHGp0ooc0LxpkrCXU21Q@mail.gmail.com>
	<CABscKVhYEkFCuF+MT0XBumbVn9NsNseBLjKS=mxiMenv1sRxwA@mail.gmail.com>
	<CA+OCxowY_26iwaOrXE2wmuEOA_cSwNB=0PzVhTYS1hDgGoEXDw@mail.gmail.com>
	<CABscKVgffuiD1dVoaBoqMnbF_j=SpWC6c1+aCbvBzHzGK9MO0w@mail.gmail.com>
	<CABscKVizf-FPqHjmvmF9cfvPCuNpRgR5858-tyyCeK0B_rYRbA@mail.gmail.com>
	<CA+OCxozmHg0gK1DsYpp5RTsiF+sfxYPXJaTnAMVepDWCXUb67g@mail.gmail.com>
	<CABscKVjrvCDfwgzkRh8z_2ekcR5gYimV5FKxXsa=pC4Jnn3i=Q@mail.gmail.com>
	<CA+OCxoybr4ER-Y8s2p07CQ8oiuSA4AsZN=5FkbOHmdeVKWuoOg@mail.gmail.com>
	<CABscKVi4N--wGb3ToFpFZuQtiRFNrxZ2zGSB9X1dG8ODpv0PAg@mail.gmail.com>

Hi Rohit,

It is actually the same as existing with only difference is alternate row
backgrounds. If later we remove the alternate bg using preferences then
issue of distinguishing row numbers will remain un-fixed.

On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <[email protected]>
wrote:

> Ok, I am applying that.
>
> Thanks for the suggestions.
>
> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>>
>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi Dave,
>>>
>>> I have made some changes and made the header and serial number row
>>> column color the same.
>>>
>>> Please once check the attached images.
>>>
>>
>> I think that looks much better!
>>
>> Thanks.
>>
>>
>>>
>>> Thanks
>>>
>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> Shadow is more visible, but it doesn't really follow the material UI
>>>> styling which is flat rather than 3D.
>>>>
>>>> I think Anil's idea is worth exploring; remove the alternating colour
>>>> for the row number column, and use a different background shade for it
>>>> entirely.
>>>>
>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> I have added shadow to make the text more distinct and attached
>>>>> screenshots based on themes.
>>>>> Please once check and let me know if we can go ahead with this or
>>>>> provide suggestions if need to make changes.
>>>>>
>>>>> Thanks & Regards
>>>>> Rohit Bhati
>>>>>
>>>>>
>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> I already set weight to 900.
>>>>>> If we need to be more distinct then I think we can have some shadow
>>>>>> or if anything else please suggest.
>>>>>>
>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> I have made changes as per your suggestions.
>>>>>>>> I have attached screenshots showing how the updates look across all
>>>>>>>> themes for your reference.
>>>>>>>>
>>>>>>>> If the current changes does not fit well with the theme or if you
>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>
>>>>>>>
>>>>>>> The colours etc. look correct now (ie. there are no weird borders),
>>>>>>> but I still don't think the row number looks visually distinct from the
>>>>>>> rest of the data. The bold text simply isn't very bold - I think it still
>>>>>>> needs more weight.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>> Rohit Bhati
>>>>>>>> EnterpriseDB
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Yeah, that looks weird again, specifically on the selected rows. I
>>>>>>>>> believe the issue is that we should not highlight the row number column
>>>>>>>>> when a row is selected at all. That makes sense, as we should only be
>>>>>>>>> highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>> anyway.
>>>>>>>>>
>>>>>>>>> Also, the bold still doesn't look bold. I think the weight needs
>>>>>>>>> to be increased.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>> all themes.
>>>>>>>>>>
>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi
>>>>>>>>>>>
>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>> I have removed the border and background color, just made the row
>>>>>>>>>>>> numbers bold.
>>>>>>>>>>>>
>>>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>>>> all themes.
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> That doesn't look bold at all to me - and I think we still need
>>>>>>>>>>> some other visual distinction, such as the column background colour.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> If the current color does not fit well with the theme or if
>>>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all the
>>>>>>>>>>>>>> time. Thoughts?
>>>>>>>>>>>>>>
>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't look
>>>>>>>>>>>>> good to me.
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Dave Page
>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>
>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>
>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>
>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>
>>>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"

view thread (33+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Require suggestions for Issue #2874
  In-Reply-To: <CAM9w-_n28JTZ9JP9e30qVoYiExF+i6LsEWA-dVtad+AsMz2gWg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox