Re: Regarding feature #6841 - Aditya Toshniwal

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Dave Page <[email protected]>
Cc: Anil Sahoo <[email protected]>
Cc: [email protected]
Subject: Re: Regarding feature #6841
Date: Fri, 19 Apr 2024 19:15:05 +0530
Message-ID: <CAM9w-_n9i5fZSzRRNywJiCGv7TSRbSHLv+LVEBR=qn3zczrAxg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozJpVhOTkPMv3_+EoEto+v+EeL=p1-dxjHFEvJM1EMBEQ@mail.gmail.com>
References: <CAO+oWtBxAaDxdPOkcf=bTU0D6sDogX_az4SgN-5zKZt-9G=2xQ@mail.gmail.com>
	<CA+OCxozieNmgfoGFq0G0Mxy+bu2Ct6hK9goZA3xtVJm9EaK6HA@mail.gmail.com>
	<CAO+oWtA13KM+jmWm+MkGbmLps2dh3B06mEZu6-PQjZ0ip7+G6g@mail.gmail.com>
	<CA+OCxoxMdX9Lsyugx7=_CZ3Z6K9jxHVTOBu4q=5_1cwgXsP7LQ@mail.gmail.com>
	<CAM9w-_mdXSmj2xv9W2k6hdmdY+3V8rfi4gnjBA_Jy28ZYkza2Q@mail.gmail.com>
	<CA+OCxozSdrD1ziKmfd_xLh72P031vdEo60wZxniyYP9sBLoM7Q@mail.gmail.com>
	<CAM9w-_=tRn_zM6C8Pm6B5w6du8BjdtrRnb1XxX1qyEcaSx4kEg@mail.gmail.com>
	<CA+OCxoz30kYxbska9TFHDKO3kXoervwY6OYE2kcY6b-k6-iYvg@mail.gmail.com>
	<CAM9w-_kjmG0rthcqss2TL+eFtC93qn_5ts_5=Fkqes82VG_EMg@mail.gmail.com>
	<CA+OCxozJpVhOTkPMv3_+EoEto+v+EeL=p1-dxjHFEvJM1EMBEQ@mail.gmail.com>

Hi Dave,

On Fri, Apr 19, 2024 at 7:05 PM Dave Page <[email protected]> wrote:

> Hi
>
> On Fri, 19 Apr 2024 at 14:32, Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> On Fri, Apr 19, 2024 at 6:22 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Fri, 19 Apr 2024 at 11:56, Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>>
>>>>> Even if you put the cursor on the "SELECT"? If so, that would imply
>>>>> the parser understands the string quoting; e.g. in this case, the Python
>>>>> multiline string. Presumably then it would also understand regular single
>>>>> and double quotes - what about (for example) a heredoc in a pl/sh function?
>>>>>
>>>> Yes, the parser understands all the aspects of a SQL query and so it
>>>> understands what type of token the cursor is based on which it does the
>>>> syntax highlighting I believe.
>>>>
>>>
>>> Does it? Even EPAS extensions?
>>>
>> I mean only standard SQL grammar.
>>
>
> Standard SQL grammar doesn't help us much - PostgreSQL is probably the
> most standard compliant dialect there is, but if it deviates from the
> standard in a few cases, and has a ton of syntax that isn't even in the
> standard. However, I suspect you mean PostgreSQL-standard, as we are using
> the PostgreSQL dialect in CodeMirror. But, pgAdmin also supports EPAS....
>
We'll have to test different scenarios to know exactly what works and what
doesn't.

>
>
>>
>>>
>>>
>>>>
>>>>> It sounds like Thom has similar concerns, and I know him well enough
>>>>> to know he wouldn't chime in without good reason.
>>>>>
>>>> There are limitations and it won't work correctly apart from standard
>>>> SQL queries. Like I said, we're adding it as a new button without touching
>>>> the existing working. If a user chooses to use the new button, he knows
>>>> that pgAdmin will try to find the query on its own. This is an optional
>>>> feature.
>>>> Additionally, what we could do is when the user hits the button we will
>>>> show a warning and the user can opt for not showing it again.
>>>>
>>>
>>> Ten minutes later they will have forgotten that warning.
>>>
>>> I'm currently thinking that we should display the current query all the
>>> time somehow (though I'm not sure how, without taking up a lot of space).
>>>
>> Can't we add some kind of tooltip or popover on hover over the execute
>> query button?
>>
>
> Possibly :-). Let's try a PoC.
>
OK. I'll ask Anil to create some samples.

>
>
>>
>>> BTW, if we do figure out a way of doing this that we all agree is safe,
>>> I'm going to want to see a bunch of automated tests against valid EPAS and
>>> PG queries, as weird and bizarre as we can think of.
>>>
>> I agree.
>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
>

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Regarding feature #6841
  In-Reply-To: <CAM9w-_n9i5fZSzRRNywJiCGv7TSRbSHLv+LVEBR=qn3zczrAxg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox