public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin][Patch] RM 6306 - UI issue in Delete records form data output table.
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][Patch] RM 6306 - UI issue in Delete records form data output table.
@ 2021-04-12 05:27 Yogesh Mahajan <[email protected]>
  2021-04-12 06:16 ` Re: [pgAdmin][Patch] RM 6306 - UI issue in Delete records form data output table. Akshay Joshi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Yogesh Mahajan @ 2021-04-12 05:27 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

Please find the attached patch which fixes the error while selecting the
row which was deleted just before selection operation.


Thanks,
Yogesh Mahajan
EnterpriseDB


Attachments:

  [application/octet-stream] RM6306_v1.patch (661B, 3-RM6306_v1.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/selection/active_cell_capture.js b/web/pgadmin/static/js/selection/active_cell_capture.js
index 442766ce0..c183cf1ef 100644
--- a/web/pgadmin/static/js/selection/active_cell_capture.js
+++ b/web/pgadmin/static/js/selection/active_cell_capture.js
@@ -108,7 +108,7 @@ define([
         }
 
         if (isClickingLastClickedHeader(rowClicked, 1)) {
-          if (isSingleRangeSelected()) {
+          if (isSingleRangeSelected() || grid.getSelectionModel().getSelectedRanges().length === 0) {
             grid.resetActiveCell();
           } else {
             grid.setActiveCell(retrievePreviousSelectedRange().fromRow, 1);


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][Patch] RM 6306 - UI issue in Delete records form data output table.
  2021-04-12 05:27 [pgAdmin][Patch] RM 6306 - UI issue in Delete records form data output table. Yogesh Mahajan <[email protected]>
@ 2021-04-12 06:16 ` Akshay Joshi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2021-04-12 06:16 UTC (permalink / raw)
  To: Yogesh Mahajan <[email protected]>; +Cc: pgadmin-hackers

Thanks, patch applied.

On Mon, Apr 12, 2021 at 10:58 AM Yogesh Mahajan <
[email protected]> wrote:

> Hi,
>
> Please find the attached patch which fixes the error while selecting the
> row which was deleted just before selection operation.
>
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2021-04-12 06:16 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 05:27 [pgAdmin][Patch] RM 6306 - UI issue in Delete records form data output table. Yogesh Mahajan <[email protected]>
2021-04-12 06:16 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox