public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Rahul Shirsat <[email protected]>
Subject: Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results
Date: Wed, 9 Dec 2020 13:53:00 +0530
Message-ID: <CANxoLDc+3YGFSJ8hvuJjVBVBTCe=yFDov_DqTGa5D30m0wKeAQ@mail.gmail.com> (raw)
In-Reply-To: <CAKtn9dPWeCXuToAyOSE3Mqdg-b0Qkx3vcRX30nuUrxabY-O-+Q@mail.gmail.com>
References: <CAKtn9dNGjVVoDCQUo0k_7hF1PKPivDmYTE1+2ds+g5wufNBgtQ@mail.gmail.com>
<CAKtn9dPWeCXuToAyOSE3Mqdg-b0Qkx3vcRX30nuUrxabY-O-+Q@mail.gmail.com>
Hi Aditya
Can you please review this patch?
On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat <[email protected]>
wrote:
> Hi Hackers,
>
> Please find the updated patch below.
>
> On Mon, Dec 7, 2020 at 2:55 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which resolves the issue of macros query
>> results download, have used async cursor to achieve this functionality,
>> where for downloading the results, cursor is scrolled back to 0 and end of
>> the records, and reset again while user scrolling on Data Output table.
>>
>> QA/Reviewer needs to observe below issues if it occurs:
>>
>> 1. If records are more like 5000 or 10000, try to fetch records by
>> scrolling at least (2000), now save the results by clicking the download
>> button, it should save the file, and now try scrolling again, the data
>> should be shown continuously and not any abrupt end or unexpected records
>> order.
>> 2. Also, the download button is now "Save results to CSV/TXT" where
>> it will only get enabled when there are valid records in the Data Output.
>>
>>
>> Also a minor fix of the add folder icon issue is also added into this
>> patch.
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results
In-Reply-To: <CANxoLDc+3YGFSJ8hvuJjVBVBTCe=yFDov_DqTGa5D30m0wKeAQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox