Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Rahul Shirsat <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results
Date: Mon, 14 Dec 2020 12:35:01 +0530
Message-ID: <CANxoLDfYi_8mWccF5MLR1NkDF_sFN2uneF_X3cZOLsjYV=j6-w@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_=pJfghTuKhy+kjUuS8dyBgWysb+chD9nx8KuOnGjX5TQ@mail.gmail.com>
References: <CAKtn9dNGjVVoDCQUo0k_7hF1PKPivDmYTE1+2ds+g5wufNBgtQ@mail.gmail.com>
	<CAKtn9dPWeCXuToAyOSE3Mqdg-b0Qkx3vcRX30nuUrxabY-O-+Q@mail.gmail.com>
	<CANxoLDc+3YGFSJ8hvuJjVBVBTCe=yFDov_DqTGa5D30m0wKeAQ@mail.gmail.com>
	<CAM9w-_nz8o7=ewwn8Qw8j7CRMi12o=vOh8yGGbNGPUBWZ=hScw@mail.gmail.com>
	<CAKtn9dMhuna1=+L8EgY-GzEKyYWw4Cut0-QBvxhukiP0HQYm-A@mail.gmail.com>
	<CAM9w-_=pJfghTuKhy+kjUuS8dyBgWysb+chD9nx8KuOnGjX5TQ@mail.gmail.com>

Thanks, patch applied.

On Mon, Dec 14, 2020 at 11:55 AM Aditya Toshniwal <
[email protected]> wrote:

> Hi Rahul,
>
> The file in the patch -
> *web/regression/javascript/sqleditor/query_tool_preferences.js* is a copy
> of *web/pgadmin/static/js/sqleditor/query_tool_preferences.js* and is not
> a test case file.
>
> @committer - Please remove the file
> *web/regression/javascript/sqleditor/query_tool_preferences.js* before
> committing.
> Apart from this, the patch looks good to me.
>
>
> On Thu, Dec 10, 2020 at 6:55 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Hi Aditya/Akshay,
>>
>> On Wed, Dec 9, 2020 at 2:59 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hello Rahul,
>>>
>>> Found below issues:
>>> 1) The data grid is not fetching more than 1000 records now, gives a
>>> console error:
>>> sqleditor.js:1264 Uncaught TypeError: self.enable_disable_download_btn
>>> is not a function
>>>     at child.fetch_next (sqleditor.js:1264)
>>>
>>  *Fixed*
>>
>>>
>>> 2) The sqleditor test cases are failing.
>>>
>>  *This has been taken care of, and added more test cases. *
>>
>>> 3) Fix pep8 issues.
>>> 4) Fix linter issues.
>>>
>>  *Sorry for these issues, last minute code changes* 😣
>>
>>> 5) Please check the doc changes again, it's not clear to me.
>>>
>>  *This has been corrected now.*
>>
>>>
>>> I didn't check but make sure the GUI tests for the sqleditor runs fine
>>> since the behaviour has changed now.
>>>
>>  *These are fixed now.*
>>
>>>
>>> On Wed, Dec 9, 2020 at 1:53 PM Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Hi Aditya
>>>>
>>>> Can you please review this patch?
>>>>
>>>> On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please find the updated patch below.
>>>>>
>>>>> On Mon, Dec 7, 2020 at 2:55 PM Rahul Shirsat <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Please find the attached patch which resolves the issue of macros
>>>>>> query results download, have used async cursor to achieve this
>>>>>> functionality, where for downloading the results, cursor is scrolled back
>>>>>> to 0 and end of the records, and reset again while user scrolling on Data
>>>>>> Output table.
>>>>>>
>>>>>> QA/Reviewer needs to observe below issues if it occurs:
>>>>>>
>>>>>>    1. If records are more like 5000 or 10000, try to fetch records
>>>>>>    by scrolling at least (2000), now save the results by clicking the download
>>>>>>    button, it should save the file, and now try scrolling again, the data
>>>>>>    should be shown continuously and not any abrupt end or unexpected records
>>>>>>    order.
>>>>>>    2. Also, the download button is now "Save results to CSV/TXT"
>>>>>>    where it will only get enabled when there are valid records in the Data
>>>>>>    Output.
>>>>>>
>>>>>>
>>>>>> Also a minor fix of the add folder icon issue is also added into this
>>>>>> patch.
>>>>>>
>>>>>> --
>>>>>> *Rahul Shirsat*
>>>>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Rahul Shirsat*
>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>> *pgAdmin Hacker | Principal Software Architect*
>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> <http://edbpostgres.com;
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

view thread (7+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results
  In-Reply-To: <CANxoLDfYi_8mWccF5MLR1NkDF_sFN2uneF_X3cZOLsjYV=j6-w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox