public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin][RM3988] Cursor disappears in Query Editor
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM3988] Cursor disappears in Query Editor
@ 2020-04-06 12:29  Aditya Toshniwal <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Toshniwal @ 2020-04-06 12:29 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached is a small patch to fix a cursor issue in the query editor.
The cursor disappears for some of the characters when zoomed out.

Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM3988.patch (574B, 3-RM3988.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/scss/_codemirror.overrides.scss b/web/pgadmin/static/scss/_codemirror.overrides.scss
index ed2541a7c..24528d166 100644
--- a/web/pgadmin/static/scss/_codemirror.overrides.scss
+++ b/web/pgadmin/static/scss/_codemirror.overrides.scss
@@ -63,8 +63,10 @@
   & .cm-hr {color: $color-editor-fg;}
   & .cm-link {color: $color-editor-fg;}
 
-  & .CodeMirror-cursor {
-    border-color: $color-editor-fg;
+  & :not(.cm-fat-cursor) .CodeMirror-cursor {
+    border-left: thin solid $color-editor-fg;;
+    border-right: none;
+    width: 0;
   }
 }
 


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM3988] Cursor disappears in Query Editor
@ 2020-04-07 08:09  Akshay Joshi <[email protected]>
  parent: Aditya Toshniwal <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2020-04-07 08:09 UTC (permalink / raw)
  To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers

Thanks, patch applied.

On Mon, Apr 6, 2020 at 5:59 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is a small patch to fix a cursor issue in the query editor.
> The cursor disappears for some of the characters when zoomed out.
>
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2020-04-07 08:09 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 12:29 [pgAdmin][RM3988] Cursor disappears in Query Editor Aditya Toshniwal <[email protected]>
2020-04-07 08:09 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox