public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Regarding codemirror upgrade and query tool autocomplete
Date: Thu, 4 Jan 2024 11:35:53 +0530
Message-ID: <CANxoLDcRZVGSeFdvtVYdXDOMEFTvV5bZnp4scmcDbtcVY=uBxA@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_kWWG+s+FG64natyv6G70himVWTW_wJ6uiUA2WUDtiz8g@mail.gmail.com>
References: <CAM9w-_=21TC-87t4qq=NyH0nNiksP9=vrLxSTQ6RQhuGzsaF7A@mail.gmail.com>
	<CAM9w-_kWWG+s+FG64natyv6G70himVWTW_wJ6uiUA2WUDtiz8g@mail.gmail.com>

Hi Aditya

On Tue, Jan 2, 2024 at 6:33 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi,
> Just to add to my previous email, double quoted table autocomplete works
> now with the latest minor version. More reasons to use the new approach.
>

   I think we should use the new approach.

>
> On Tue, Jan 2, 2024 at 4:44 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> I am working on upgrading the CodeMirror package (used by SQL input/Query
>> editor) to the latest version. One major improvement is on the autocomplete
>> part. CodeMirror provides a very versatile way of using autocomplete now.
>> One needs to pass the schema, table and columns data and it will show up in
>> intellisense on typing.
>> Right now, we send the query to the backend and the backend sends the
>> suggestions which are shown on the screen. This can be very slow for remote
>> PostgreSQL servers as it queries everytime to the server for data and
>> requires an active connection. Also, not a good user experience.
>> I was playing around with the new autocomplete and I have attached the
>> screen-recording for the same. The data from the backend is loaded once the
>> query tool opens.
>> It has a few issues though. Column suggestions don't work correctly for
>> double quoted tables aliases. It doesn't suggest "joins" which we do right
>> now.
>> I still need to figure out how we can refresh the data when new
>> tables/columns are added/removed. Overall, I find it more useful to the
>> users as it is quick and does the job what someone expects from an
>> autocomplete/intellisense.
>>
>> Thoughts/Suggestions on whether we should use it or continue with
>> existing?
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
> <https://www.enterprisedb.com/;
> "Don't Complain about Heat, Plant a TREE"
>

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Regarding codemirror upgrade and query tool autocomplete
  In-Reply-To: <CANxoLDcRZVGSeFdvtVYdXDOMEFTvV5bZnp4scmcDbtcVY=uBxA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox