public inbox for [email protected]  

help / color / mirror / Atom feed

Re: Regarding codemirror upgrade and query tool autocomplete
2+ messages / 2 participants
[nested] [flat]

* Re: Regarding codemirror upgrade and query tool autocomplete
@ 2024-01-02 13:02  Aditya Toshniwal <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Toshniwal @ 2024-01-02 13:02 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,
Just to add to my previous email, double quoted table autocomplete works
now with the latest minor version. More reasons to use the new approach.

On Tue, Jan 2, 2024 at 4:44 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> I am working on upgrading the CodeMirror package (used by SQL input/Query
> editor) to the latest version. One major improvement is on the autocomplete
> part. CodeMirror provides a very versatile way of using autocomplete now.
> One needs to pass the schema, table and columns data and it will show up in
> intellisense on typing.
> Right now, we send the query to the backend and the backend sends the
> suggestions which are shown on the screen. This can be very slow for remote
> PostgreSQL servers as it queries everytime to the server for data and
> requires an active connection. Also, not a good user experience.
> I was playing around with the new autocomplete and I have attached the
> screen-recording for the same. The data from the backend is loaded once the
> query tool opens.
> It has a few issues though. Column suggestions don't work correctly for
> double quoted tables aliases. It doesn't suggest "joins" which we do right
> now.
> I still need to figure out how we can refresh the data when new
> tables/columns are added/removed. Overall, I find it more useful to the
> users as it is quick and does the job what someone expects from an
> autocomplete/intellisense.
>
> Thoughts/Suggestions on whether we should use it or continue with existing?
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
> <https://www.enterprisedb.com/;
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Regarding codemirror upgrade and query tool autocomplete
@ 2024-01-04 06:05  Akshay Joshi <[email protected]>
  parent: Aditya Toshniwal <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2024-01-04 06:05 UTC (permalink / raw)
  To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers

Hi Aditya

On Tue, Jan 2, 2024 at 6:33 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi,
> Just to add to my previous email, double quoted table autocomplete works
> now with the latest minor version. More reasons to use the new approach.
>

   I think we should use the new approach.

>
> On Tue, Jan 2, 2024 at 4:44 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> I am working on upgrading the CodeMirror package (used by SQL input/Query
>> editor) to the latest version. One major improvement is on the autocomplete
>> part. CodeMirror provides a very versatile way of using autocomplete now.
>> One needs to pass the schema, table and columns data and it will show up in
>> intellisense on typing.
>> Right now, we send the query to the backend and the backend sends the
>> suggestions which are shown on the screen. This can be very slow for remote
>> PostgreSQL servers as it queries everytime to the server for data and
>> requires an active connection. Also, not a good user experience.
>> I was playing around with the new autocomplete and I have attached the
>> screen-recording for the same. The data from the backend is loaded once the
>> query tool opens.
>> It has a few issues though. Column suggestions don't work correctly for
>> double quoted tables aliases. It doesn't suggest "joins" which we do right
>> now.
>> I still need to figure out how we can refresh the data when new
>> tables/columns are added/removed. Overall, I find it more useful to the
>> users as it is quick and does the job what someone expects from an
>> autocomplete/intellisense.
>>
>> Thoughts/Suggestions on whether we should use it or continue with
>> existing?
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
> <https://www.enterprisedb.com/;
> "Don't Complain about Heat, Plant a TREE"
>


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2024-01-04 06:05 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-01-02 13:02 Re: Regarding codemirror upgrade and query tool autocomplete Aditya Toshniwal <[email protected]>
2024-01-04 06:05 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox