public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Sarah McAlear <[email protected]>
Cc: Joao Pedro De Almeida Pereira <[email protected]>
Cc: Robert Eckhardt <[email protected]>
Cc: Matthew Kleiman <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Dave Page <[email protected]>
Subject: Re: [patch] Dependents and Dependencies in GreenPlum
Date: Thu, 11 May 2017 11:41:11 +0530
Message-ID: <CANxoLDcS0+HMZx--k+xAwtRA0y9hqfMNvtgJgRxyWvFf3S7FqA@mail.gmail.com> (raw)
In-Reply-To: <CAGRPzo8b8zfo2rX-ecL+8qdnS-2c1UJqv2nRzed-aTei_Pr5CA@mail.gmail.com>
References: <CAE+jjam5JoMt9+Ue-O_qpgEJO_wAGJfGoaLCJg-1VzVc+AqB_w@mail.gmail.com>
<CA+OCxoxOaYKi6j5dwgwEP7VtP-8XDiee101kjnO3e6SJc4Mp1g@mail.gmail.com>
<CAG7mmoyg2nbVHtYJVd1RA4e2orMv6nsaPoSbUeupy9akrz-z_w@mail.gmail.com>
<CAE+jja=8s-x82BVuBD4THq5V=07F_rJn0+Sa8vUGc=rOtxwWLA@mail.gmail.com>
<CAE+jja=dpFAAxavzJupBjcKQNZjox+grCiqd53AC2EO2G-FGdg@mail.gmail.com>
<CAGRPzo-pSDrQwXOHcy1aPbe==nNqRQpJeK6h2qr8_rsGiidRHg@mail.gmail.com>
<CAAtBm9V77+cbV5fbOkwrPg6JNDuVxQq5=ug7vdChAuTDY0Wj8Q@mail.gmail.com>
<CA+OCxozvcTmYOBrdXMi=b3w4f3LaBSYUMyJiTaUhz-uLuOAWiA@mail.gmail.com>
<CA+OCxozwGCNHJ1d58Huoc=zWGkvH3yWhrzRE9kE7oKm-LdQdYQ@mail.gmail.com>
<CANxoLDfcwCnw8ZRaVzT8TO4be1tmT1XSfOUrD=zMiud-cHLybA@mail.gmail.com>
<CANxoLDfGtTEyfwb=2snvRYN5qAr_CiC5s4J-_NMeSY8hUk8M7A@mail.gmail.com>
<CA+OCxoySRBh0YRRxOo-Osn3WOViPkcO-2Qt55iBjByzEb=bhtQ@mail.gmail.com>
<CAGRPzo9rkT+ehf-ShMvzU_TGyXT5eCek=jQDeSk5pnaMoQgzuQ@mail.gmail.com>
<CANxoLDc-j1rVx4Ke+Qjxpi82Nj4FfbhiYhriVY3ekNbtKBF2qQ@mail.gmail.com>
<CAGRPzo_ATD7Erwz=5Eay1GDfXnDq4DvEinYvfsSGQbVBmcxrNg@mail.gmail.com>
<CANxoLDfeJOiFKpsNa6aWU0Kui_3Pz6nswW=8uUE==8FUYJ3WoQ@mail.gmail.com>
<CAGRPzo95Yy4u-CQHFXXX=49Thci3mgdMvm3hxuJKNc0MhZU8tg@mail.gmail.com>
<CANxoLDcvq+eG482KkLzUY7sERM-y=KUeRUnuvskL600AvOkFdQ@mail.gmail.com>
<CAGRPzo8b8zfo2rX-ecL+8qdnS-2c1UJqv2nRzed-aTei_Pr5CA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Sarah
On Thu, May 11, 2017 at 2:30 AM, Sarah McAlear <[email protected]> wrote:
> Hi Ashkay!
>
> TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with
>> below error:
>> .....\test_role_dependencies_sql.py\", line 41, in assertions\n
>> self.assertEqual(1, len(fetch_result))\nAssertionError: 1 != 0
>
>
> We experienced a similar problem when we started developing this patch. We
> noticed that we were connecting to the database with the super user (the db
> owner user), which did not create the role we are expecting when a table is
> created. To ensure that this role is created, we had to create a new user
> and use it to execute all the tests. After we made this change, the tests
> passed.
>
> Can you try to create a new user and use it to execute your tests?
>
I did that and it works. I have created new user 'test' with superuser
privileges and update parameter db_username="test" in test_config.json
file. But still I am unable to understand why it doesn't work with
'postgres' (default) user?
>
> Thanks,
> João & Sarah
>
> On Wed, May 10, 2017 at 1:56 PM, Akshay Joshi <
> [email protected]> wrote:
>
>>
>>
>> On May 10, 2017 19:07, "Sarah McAlear" <[email protected]> wrote:
>>
>> Hi Akshay!
>>
>> Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our
>> tests pass.
>>
>>
>> On both 9.6 and 10.0. Query returned 0 rows which is compared against
>> 1 in assert statement.
>>
>>
>> Thanks!
>> João & Sarah
>>
>> On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Sarah
>>>
>>> On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear <[email protected]>
>>> wrote:
>>>
>>>> Hi Akshay!
>>>>
>>>>
>>>>> Some test file names ended with "*_sql_template.py*" do we need to
>>>>> add that string ?
>>>>
>>>> we added this suffix after moving the tests up a level to tables/tests
>>>> to clarify what subject they applied to. we changed the suffix to "_sql.py"
>>>>
>>>> - Files "test_column_acl_sql_template.py" and "test_column_properties_
>>>>> sql_template.py" should be moved from tables->tests to
>>>>> tables->column->tests. As it's related to column.
>>>>> - Files "test_trigger_get_oid_sql_template.py" and "
>>>>> test_trigger_nodes_sql_template.py" should be moved from
>>>>> tables->tests to tables->triggers->tests. As its related to triggers.
>>>>
>>>> these tests are related to the sql files in tables/templates/column,
>>>> not tables/column, so moving them into tables/column would be more
>>>> confusing.
>>>>
>>>> Following test cases are failing
>>>>
>>>> Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql
>>>> doesn't fail in your environment?
>>>>
>>>
>>> TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed
>>> with below error:
>>> .....\test_role_dependencies_sql.py\", line 41, in assertions\n
>>> self.assertEqual(1, len(fetch_result))\nAssertionError: 1 != 0
>>>
>>>
>>>> Thanks,
>>>> George & Sarah
>>>>
>>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>>
>>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (27+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [patch] Dependents and Dependencies in GreenPlum
In-Reply-To: <CANxoLDcS0+HMZx--k+xAwtRA0y9hqfMNvtgJgRxyWvFf3S7FqA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox