public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary
@ 2020-03-31 05:51 Aditya Toshniwal <[email protected]>
2020-04-01 09:50 ` Re: [pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Toshniwal @ 2020-03-31 05:51 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is a tiny patch to fix SQL generated when any token in FTS
Configuration or any option in FTS Dictionary is changed.
Please review.
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM5268.patch (1.6K, 3-RM5268.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js
index ab4838ea5..ba13f498a 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/static/js/fts_configuration.js
@@ -19,6 +19,7 @@ define('pgadmin.node.fts_configuration', [
// Model for tokens control
var TokenModel = pgAdmin.Browser.Node.Model.extend({
+ idAttribute: 'token',
defaults: {
token: undefined,
dictname: undefined,
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/static/js/fts_dictionary.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/static/js/fts_dictionary.js
index 91f1d23fa..08666e80c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/static/js/fts_dictionary.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_dictionaries/static/js/fts_dictionary.js
@@ -19,8 +19,9 @@ define('pgadmin.node.fts_dictionary', [
// Extend the browser's node model class to create a option/value pair
var OptionLabelModel = pgAdmin.Browser.Node.Model.extend({
+ idAttribute: 'option',
defaults: {
- options: undefined,
+ option: undefined,
value: undefined,
},
// Define the schema for the Options
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary
2020-03-31 05:51 [pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary Aditya Toshniwal <[email protected]>
@ 2020-04-01 09:50 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2020-04-01 09:50 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Tue, Mar 31, 2020 at 11:22 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is a tiny patch to fix SQL generated when any token in FTS
> Configuration or any option in FTS Dictionary is changed.
>
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2020-04-01 09:50 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31 05:51 [pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary Aditya Toshniwal <[email protected]>
2020-04-01 09:50 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox