public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM-3827]: In Query History tab, query details should be scrollable
4+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable
@ 2021-09-16 08:51 Nikhil Mohite <[email protected]>
2021-09-17 15:37 ` Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Akshay Joshi <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Nikhil Mohite @ 2021-09-16 08:51 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find the attached patch for
<https://redmine.postgresql.org/issues/6672>RM-3827:
<https://redmine.postgresql.org/issues/3827; In Query History tab, query
details should be scrollable
--
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/;
*Mob.No: +91-7798364578.*
Attachments:
[application/octet-stream] RM-3827.patch (773B, 3-RM-3827.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/static/scss/_history.scss b/web/pgadmin/tools/sqleditor/static/scss/_history.scss
index fe9ef8ea..cbb7b029 100644
--- a/web/pgadmin/tools/sqleditor/static/scss/_history.scss
+++ b/web/pgadmin/tools/sqleditor/static/scss/_history.scss
@@ -96,6 +96,7 @@
.query-detail {
height: 100%;
width: 100%;
+ min-height: 19em;
display: flex;
flex-direction: column;
background-color: $color-bg;
@@ -156,7 +157,7 @@
flex: 5;
margin-left: 10px;
margin-right: 10px;
- height: 0;
+ min-height: 1em;
position: relative;
.copy-all, .was-copied, .copy-to-editor {
@@ -196,6 +197,7 @@
flex: 2;
display: flex;
padding: 0 20px;
+ min-height: 6em;
.message {
flex: 2 2 0%;
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable
2021-09-16 08:51 [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Nikhil Mohite <[email protected]>
@ 2021-09-17 15:37 ` Akshay Joshi <[email protected]>
2021-09-30 17:21 ` Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Nikhil Mohite <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Akshay Joshi @ 2021-09-17 15:37 UTC (permalink / raw)
To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers
Thanks, the patch applied.
On Thu, Sep 16, 2021 at 2:21 PM Nikhil Mohite <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached patch for
> <https://redmine.postgresql.org/issues/6672>RM-3827:
> <https://redmine.postgresql.org/issues/3827; In Query History tab, query
> details should be scrollable
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable
2021-09-16 08:51 [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Nikhil Mohite <[email protected]>
2021-09-17 15:37 ` Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Akshay Joshi <[email protected]>
@ 2021-09-30 17:21 ` Nikhil Mohite <[email protected]>
2021-10-01 07:31 ` Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Akshay Joshi <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Nikhil Mohite @ 2021-09-30 17:21 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers
Hi Akshay,
please find the attached updated patch for RM-3827 (v2)
On Fri, Sep 17, 2021 at 9:07 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, the patch applied.
>
> On Thu, Sep 16, 2021 at 2:21 PM Nikhil Mohite <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for
>> <https://redmine.postgresql.org/issues/6672>RM-3827:
>> <https://redmine.postgresql.org/issues/3827; In Query History tab, query
>> details should be scrollable
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/;
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachments:
[application/octet-stream] RM-3827_v2.patch (1.4K, 3-RM-3827_v2.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/sqleditor/history/query_history.js b/web/pgadmin/static/js/sqleditor/history/query_history.js
index c171f7fb..76a7aca9 100644
--- a/web/pgadmin/static/js/sqleditor/history/query_history.js
+++ b/web/pgadmin/static/js/sqleditor/history/query_history.js
@@ -73,6 +73,8 @@ export default class QueryHistory {
cursor: 'ew-resize',
});
+ $histDetails.css('overflow', 'auto');
+
this.queryHistDetails = new QueryHistoryDetails($histDetails);
this.queryHistDetails.setEditorPref(this.editorPref);
this.queryHistDetails.onCopyToEditorClick(this.onCopyToEditorHandler);
diff --git a/web/pgadmin/tools/sqleditor/static/scss/_history.scss b/web/pgadmin/tools/sqleditor/static/scss/_history.scss
index cbb7b029..fbb81782 100644
--- a/web/pgadmin/tools/sqleditor/static/scss/_history.scss
+++ b/web/pgadmin/tools/sqleditor/static/scss/_history.scss
@@ -88,7 +88,7 @@
.sql-editor-history-container {
height: 100%;
- overflow: auto;
+ overflow: hidden;
background-color: $negative-bg;
}
@@ -97,6 +97,7 @@
height: 100%;
width: 100%;
min-height: 19em;
+ overflow: auto;
display: flex;
flex-direction: column;
background-color: $color-bg;
@@ -157,7 +158,7 @@
flex: 5;
margin-left: 10px;
margin-right: 10px;
- min-height: 1em;
+ min-height: 4em;
position: relative;
.copy-all, .was-copied, .copy-to-editor {
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable
2021-09-16 08:51 [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Nikhil Mohite <[email protected]>
2021-09-17 15:37 ` Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Akshay Joshi <[email protected]>
2021-09-30 17:21 ` Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Nikhil Mohite <[email protected]>
@ 2021-10-01 07:31 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Akshay Joshi @ 2021-10-01 07:31 UTC (permalink / raw)
To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers
Thanks, the patch applied.
On Thu, Sep 30, 2021 at 10:51 PM Nikhil Mohite <
[email protected]> wrote:
> Hi Akshay,
>
> please find the attached updated patch for RM-3827 (v2)
>
> On Fri, Sep 17, 2021 at 9:07 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks, the patch applied.
>>
>> On Thu, Sep 16, 2021 at 2:21 PM Nikhil Mohite <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for
>>> <https://redmine.postgresql.org/issues/6672>RM-3827:
>>> <https://redmine.postgresql.org/issues/3827; In Query History tab,
>>> query details should be scrollable
>>>
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* <https://www.enterprisedb.com/;
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2021-10-01 07:31 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 08:51 [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable Nikhil Mohite <[email protected]>
2021-09-17 15:37 ` Akshay Joshi <[email protected]>
2021-09-30 17:21 ` Nikhil Mohite <[email protected]>
2021-10-01 07:31 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox