public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Date: Tue, 12 Nov 2019 19:40:41 +0530
Message-ID: <CANxoLDdroW4RKX0xZNKewJ5WZdHY+16G4uCbrn+GnkuDXMXZdg@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_=tKBBMaJmKSaRnhrdCWjk-D+SWd=BxwxYuHJwCv8nrmw@mail.gmail.com>
References: <CAM9w-_m5mfGiu1mUH28Hngi1riYTmTurNoxz-qWOH7g+zRFOhA@mail.gmail.com>
<CAM9w-_nNp1BAy9usd1j9xP+gKSrR-_BLMwoCUzngx0-8HcbRmw@mail.gmail.com>
<CANxoLDcAnDBA-a5577wo0QcXVq0bmk+DPKv=K7nekRiejcPXzA@mail.gmail.com>
<CA+OCxozmGJmLvH1g0vCn09OOTiUTnZbZ_nPHU0dNU1pRXYjQnA@mail.gmail.com>
<CA+OCxow-ZLN8sKETj5Bf7Y4gTWm+q7NtugfpG3_zt-KHzpvbJA@mail.gmail.com>
<CAM9w-_=fuDGpPmFLg=w--LCF1jACMuWcqGb5BFX57AhE-Vm4xQ@mail.gmail.com>
<CA+OCxoxKgZFwtqhc89Pu3T_aPWkTmt4_rO32WuewaDLqoLM7wg@mail.gmail.com>
<CAM9w-_=OHmdrWRJWnwN5_cfNPfak+34=MwbiHpez9HBUtk2ZzQ@mail.gmail.com>
<CAM9w-_kma2zGbk-3dr68z2O4ZvfJEmt5i8y9tgQwcMOvshWtaw@mail.gmail.com>
<CAM9w-_=M1G-m-vb_7j1G1LtEis6aT8KakHmWGxJmRfUV-oZ5ug@mail.gmail.com>
<CAM9w-_ntcD1bJkm3h3n3S9TO+GxGxmJPY17Qi079Z87x9b_W4g@mail.gmail.com>
<CANxoLDfgiKoaZyHuDAMier0yjrmnYCc9Diht+yvhWQau1Xr05Q@mail.gmail.com>
<CA+OCxowQ_qPmaLoCwq6ca0KzojaO7U49yJna3_rNJqUp-wTYJA@mail.gmail.com>
<CAM9w-_=18dvyzS4wB=8es_dMTr9O0bnVq7VD0OC1JgxVsXJqXA@mail.gmail.com>
<CA+OCxowN-7O=LoKoDjfEUp8J_cij7zd+=rn99n4=rYbEJXbuvw@mail.gmail.com>
<CAM9w-_=iOUWtvLJ3vq=McZZYyWRkjoF_HcpDdHE8=fUE-jGMyw@mail.gmail.com>
<CA+OCxoz=TRA8UHjaQycqPcdsRmHwLz72gwBPitY2nQMuvBw3-g@mail.gmail.com>
<CAM9w-_mfFq2wKZwTvzRaEPre+Shz-ESSEhy3CA-SuFmcvNCAzQ@mail.gmail.com>
<CA+OCxoxf0maw2s1cCfdNDzDfazP_13de0AS1g3dixOZMTmBudw@mail.gmail.com>
<CAM9w-_=B-DE2F2rAZLr1uhiedLS2Fxe0v85YsPm7fKtZgVYKDg@mail.gmail.com>
<CANxoLDfx5rgaoPSPhn1EyvZcT-gpBqvJvNN+GwGnmRiSFQKRmw@mail.gmail.com>
<CAM9w-_=tKBBMaJmKSaRnhrdCWjk-D+SWd=BxwxYuHJwCv8nrmw@mail.gmail.com>
Thanks, patch applied.
On Tue, Nov 12, 2019 at 7:17 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the patch to customize the scrollbar styling. A new SASS
> variable added - $scrollbar-base-color is added to change the color as per
> theme.
> Please note, customization of scrollbar works only in webkit browsers like
> Chrome, Safari. Mozilla does not have any way to customize.
>
> Kindly review.
>
> On Tue, Nov 12, 2019 at 5:55 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks, patch applied.
>>
>> On Tue, Nov 12, 2019 at 3:41 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>>
>>>
>>> On Tue, Nov 12, 2019 at 3:25 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Tue, Nov 12, 2019 at 9:50 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>>
>>>>>> Attached. It may just be that it looks a little sharp because it's a
>>>>>> long line. Maybe we should just make it a darker shade entirely.
>>>>>>
>>>>>> [image: Screenshot 2019-11-12 at 09.09.42.png]
>>>>>>
>>>>>
>>>>> Why can't I see it :/
>>>>> Maybe it got fixed along with the dark drop down for no limit. Could
>>>>> you please check again.
>>>>> [image: image.png]
>>>>>
>>>>
>>>> Nope, it's definitely still there:
>>>>
>>> I checked on 2-3 systems. It looks fine. May be the permanent enabled
>>> scrollbar causing it look like that.
>>>
>>>>
>>>> [image: Screenshot 2019-11-12 at 09.53.02.png]
>>>>
>>>>
>>>>
>>>>> BTW, what was the reason for removing the styling from the scroll bars?
>>>>>>
>>>>> We had given gray shades to scrollbar which were not clearly visible
>>>>> for some tables. Plus, for systems were scrollbar is not always enabled was
>>>>> showing scrollbar. It should appear only on scroll on those systems.
>>>>>
>>>>
>>>> And you're working on that? We can't keep the ugly grey scroll bars!
>>>>
>>> OK. I'll take it as priority.
>>>
>>>>
>>>> Thanks!
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
Attachments:
[image/png] Screenshot 2019-11-12 at 09.09.42.png (23.5K, 3-Screenshot%202019-11-12%20at%2009.09.42.png)
download | view image
[image/png] image.png (60.7K, 4-image.png)
download | view image
[image/png] Screenshot 2019-11-12 at 09.53.02.png (36.7K, 5-Screenshot%202019-11-12%20at%2009.53.02.png)
download | view image
view thread (31+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
In-Reply-To: <CANxoLDdroW4RKX0xZNKewJ5WZdHY+16G4uCbrn+GnkuDXMXZdg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox