public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin][RM6935] Wrong SQL generated when modifying existing table in table dialog
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM6935] Wrong SQL generated when modifying existing table in table dialog
@ 2021-10-19 09:13  Aditya Toshniwal <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Toshniwal @ 2021-10-19 09:13 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached patch fixes the issue where wrong SQL is generated when deleting
and renaming table columns together.
Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM6935.patch (815B, 3-RM6935.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/SchemaView/index.jsx b/web/pgadmin/static/js/SchemaView/index.jsx
index 1f326f0da..5f3833d54 100644
--- a/web/pgadmin/static/js/SchemaView/index.jsx
+++ b/web/pgadmin/static/js/SchemaView/index.jsx
@@ -176,7 +176,7 @@ function getChangedData(topSchema, viewHelperProps, sessData, stringify=false, i
 
                 /* If the id attr value is present, then only changed keys can be passed.
                 Otherwise, passing all the keys is useful */
-                let idAttrValue = _.get(origVal, [field.id, rowIndx, field.schema.idAttribute]);
+                let idAttrValue = _.get(sessVal, [field.id, rowIndx, field.schema.idAttribute]);
                 if(_.isUndefined(idAttrValue)) {
                   change['changed'].push({
                     ...changedRow,


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM6935] Wrong SQL generated when modifying existing table in table dialog
@ 2021-10-19 11:54  Akshay Joshi <[email protected]>
  parent: Aditya Toshniwal <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2021-10-19 11:54 UTC (permalink / raw)
  To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers

Thanks, the patch applied.

On Tue, Oct 19, 2021 at 2:43 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached patch fixes the issue where wrong SQL is generated when deleting
> and renaming table columns together.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2021-10-19 11:54 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 09:13 [pgAdmin][RM6935] Wrong SQL generated when modifying existing table in table dialog Aditya Toshniwal <[email protected]>
2021-10-19 11:54 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox