public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Libor M. <[email protected]>
Subject: Re: pgAdmin 4 - gettext usage fixes
Date: Mon, 23 Mar 2020 16:00:21 +0530
Message-ID: <CANxoLDdxMRw_DZOjTrkTQwUau0VQ+wwMpezQkzAdUsZNeBJO2w@mail.gmail.com> (raw)
In-Reply-To: <CAMavuw3D1u7QCxL3rfKHBzykjDZ5N+tqq1aeOwAnSP=nW8-4Vg@mail.gmail.com>
References: <CAMavuw3D1u7QCxL3rfKHBzykjDZ5N+tqq1aeOwAnSP=nW8-4Vg@mail.gmail.com>
Hi Aditya
Can you please review this?
On Mon, Mar 23, 2020 at 5:00 AM Libor M. <[email protected]> wrote:
> Hello,
> I fixed using gettext function and add more usages for translations,
> specifically:
>
> - fixed usage gettext('') instead of _('') in javascript files
> - fixed usage gettext('') instead of `${gettext('')}` in javascript
> files, because "pybabel extract" not support extracting from this
> syntax
> - added a lot of gettext for support translations
>
> Diff file is attached.
>
> Best regards,
>
> Libor M.
>
> E-mail: [email protected]
> GitHub: https://github.com/liborm85
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 - gettext usage fixes
In-Reply-To: <CANxoLDdxMRw_DZOjTrkTQwUau0VQ+wwMpezQkzAdUsZNeBJO2w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox