public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Libor M. <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 - gettext usage fixes
Date: Tue, 24 Mar 2020 11:15:27 +0530
Message-ID: <CANxoLDe8H3DTqL24kY_2QY6rd-OBZFrv8_yk=2D9rz48VxDWFw@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_n0GfyfkeZf=S1bJRJX-UJtnigFRv9HEj4uhPPEf20MWg@mail.gmail.com>
References: <CAMavuw3D1u7QCxL3rfKHBzykjDZ5N+tqq1aeOwAnSP=nW8-4Vg@mail.gmail.com>
<CANxoLDdxMRw_DZOjTrkTQwUau0VQ+wwMpezQkzAdUsZNeBJO2w@mail.gmail.com>
<CAM9w-_kCE8r94knekGPXy+2Y1b_PAK=XJH_fWRyxhk1U0cXz-w@mail.gmail.com>
<CAM9w-_n0GfyfkeZf=S1bJRJX-UJtnigFRv9HEj4uhPPEf20MWg@mail.gmail.com>
Thanks, patch applied.
On Tue, Mar 24, 2020 at 11:06 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the updated patch with pep8, linter issues fixed.
>
>
> On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Libor,
>>
>> Thank you for the patch. It is good clean up patch.
>> I've made a few changes in the patch. You've imported sprintf which was
>> not required since gettext also works as sprintf directly.
>> I've also created a housekeeping redmine ticket to track it -
>> https://redmine.postgresql.org/issues/5284
>>
>> The messages compile fine. The patch can be committed.
>> Please find the attached updated patch.
>>
>>
>>
>> On Mon, Mar 23, 2020 at 4:00 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please review this?
>>>
>>> On Mon, Mar 23, 2020 at 5:00 AM Libor M. <[email protected]> wrote:
>>>
>>>> Hello,
>>>> I fixed using gettext function and add more usages for translations,
>>>> specifically:
>>>>
>>>> - fixed usage gettext('') instead of _('') in javascript files
>>>> - fixed usage gettext('') instead of `${gettext('')}` in javascript
>>>> files, because "pybabel extract" not support extracting from this
>>>> syntax
>>>> - added a lot of gettext for support translations
>>>>
>>>> Diff file is attached.
>>>>
>>>> Best regards,
>>>>
>>>> Libor M.
>>>>
>>>> E-mail: [email protected]
>>>> GitHub: https://github.com/liborm85
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 - gettext usage fixes
In-Reply-To: <CANxoLDe8H3DTqL24kY_2QY6rd-OBZFrv8_yk=2D9rz48VxDWFw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox