public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others
3+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others
@ 2019-11-05 09:17 Rahul Shirsat <[email protected]>
2019-11-05 10:06 ` Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others Akshay Joshi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Rahul Shirsat @ 2019-11-05 09:17 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is the patch to move "Delete/Drop" menu option away from
"Disconnect Servers" for server node.
Additionally, I have renamed the "Delete/Drop" menu option to "Remove
Server" for server node against issue RM3859.
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation | Pune.
Attachments:
[application/octet-stream] RM3279_3859.patch (1.1K, 3-RM3279_3859.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/static/js/node.js b/web/pgadmin/browser/static/js/node.js
index 292d60c0d..3588bf9d3 100644
--- a/web/pgadmin/browser/static/js/node.js
+++ b/web/pgadmin/browser/static/js/node.js
@@ -142,8 +142,8 @@ define('pgadmin.browser.node', [
module: self,
applies: ['object', 'context'],
callback: 'delete_obj',
- priority: 2,
- label: gettext('Delete/Drop'),
+ priority: self.get_menu_item_priority(self.type, 2),
+ label: self.change_menu_label(self.type, gettext('Delete/Drop')),
data: {
'url': 'drop',
},
@@ -1742,6 +1742,18 @@ define('pgadmin.browser.node', [
return this.parent_type;
}
},
+ get_menu_item_priority: function(type, default_priority) {
+ if(type && type === 'server') {
+ return 997;
+ }
+ return default_priority;
+ },
+ change_menu_label: function(type, default_label) {
+ if(type && type === 'server') {
+ return gettext('Remove Server');
+ }
+ return default_label;
+ },
});
return pgAdmin.Browser.Node;
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others
2019-11-05 09:17 [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others Rahul Shirsat <[email protected]>
@ 2019-11-05 10:06 ` Akshay Joshi <[email protected]>
2019-11-07 07:42 ` Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others Akshay Joshi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Akshay Joshi @ 2019-11-05 10:06 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Hi Rahul
Following are the review comments:
- Priority should be set to 5 instead of 997, as the 'Remove Server'
menu goes very down with that priority. 'Remove Server' menu should be near
to 'Connect Server' and 'Disconnect Server'. I have tested it with 5 and it
looks fine. Refer the below screenshot
[image: Screenshot 2019-11-05 at 3.27.22
PM.png] [image: Screenshot 2019-11-05 at 3.27.38 PM.png]
- As we have renamed the menu from 'Drop Server' to 'Remove Server' we
should also change the same for the below dialog when the user clicks on
the menu:
[image: Screenshot 2019-11-05 at 3.16.55
PM.png]
- Please check the documentation as we renamed the menu, so we may need
to change the docs.
On Tue, Nov 5, 2019 at 2:48 PM Rahul Shirsat <[email protected]>
wrote:
> Hi Hackers,
>
> Attached is the patch to move "Delete/Drop" menu option away from
> "Disconnect Servers" for server node.
>
> Additionally, I have renamed the "Delete/Drop" menu option to "Remove
> Server" for server node against issue RM3859.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation | Pune.
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
Attachments:
[image/png] Screenshot 2019-11-05 at 3.27.22 PM.png (23.3K, 3-Screenshot%202019-11-05%20at%203.27.22%20PM.png)
download | view image
[image/png] Screenshot 2019-11-05 at 3.27.38 PM.png (52.1K, 4-Screenshot%202019-11-05%20at%203.27.38%20PM.png)
download | view image
[image/png] Screenshot 2019-11-05 at 3.16.55 PM.png (31.9K, 5-Screenshot%202019-11-05%20at%203.16.55%20PM.png)
download | view image
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others
2019-11-05 09:17 [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others Rahul Shirsat <[email protected]>
2019-11-05 10:06 ` Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others Akshay Joshi <[email protected]>
@ 2019-11-07 07:42 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Akshay Joshi @ 2019-11-07 07:42 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Wed, Nov 6, 2019 at 6:17 PM Rahul Shirsat <[email protected]>
wrote:
> Hi Akshay,
>
> Please find below comments and the attached patch for your reference.
>
> On Tue, Nov 5, 2019 at 3:36 PM Akshay Joshi <[email protected]>
> wrote:
>
>> Hi Rahul
>>
>> Following are the review comments:
>>
>> - Priority should be set to 5 instead of 997, as the 'Remove Server'
>> menu goes very down with that priority. 'Remove Server' menu should be near
>> to 'Connect Server' and 'Disconnect Server'. I have tested it with 5 and it
>> looks fine. Refer the below screenshot - *Fixed*
>>
>> [image: Screenshot 2019-11-05 at
>> 3.27.22 PM.png] [image: Screenshot 2019-11-05 at 3.27.38 PM.png]
>>
>> - As we have renamed the menu from 'Drop Server' to 'Remove Server'
>> we should also change the same for the below dialog when the user clicks on
>> the menu - *Fixed*
>>
>> [image: Screenshot 2019-11-05 at
>> 3.16.55 PM.png]
>>
>> - Please check the documentation as we renamed the menu, so we may
>> need to change the docs - *Fixed*
>>
>>
>>
>>
>> On Tue, Nov 5, 2019 at 2:48 PM Rahul Shirsat <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to move "Delete/Drop" menu option away from
>>> "Disconnect Servers" for server node.
>>>
>>> Additionally, I have renamed the "Delete/Drop" menu option to "Remove
>>> Server" for server node against issue RM3859.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation | Pune.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
Attachments:
[image/png] Screenshot 2019-11-05 at 3.27.22 PM.png (23.3K, 3-Screenshot%202019-11-05%20at%203.27.22%20PM.png)
download | view image
[image/png] Screenshot 2019-11-05 at 3.27.38 PM.png (52.1K, 4-Screenshot%202019-11-05%20at%203.27.38%20PM.png)
download | view image
[image/png] Screenshot 2019-11-05 at 3.16.55 PM.png (31.9K, 5-Screenshot%202019-11-05%20at%203.16.55%20PM.png)
download | view image
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-11-07 07:42 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 09:17 [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others Rahul Shirsat <[email protected]>
2019-11-05 10:06 ` Akshay Joshi <[email protected]>
2019-11-07 07:42 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox