public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Pradip Parkale <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.
Date: Thu, 24 Jun 2021 19:55:57 +0530
Message-ID: <CANxoLDe0Wq9cNE5qMEJQXoTHuVW_fPS-78PJhGRNyoV8xQujtg@mail.gmail.com> (raw)
In-Reply-To: <CAJ9T6SsW9VB+J8UAbMXtpapuA_Dx8qX25BOdTLrkq=O+zCbVqw@mail.gmail.com>
References: <CAJ9T6St7o5QTO1R2KSsvZAviCw0jK0u6MWsgUAtRzpkDQQpA+A@mail.gmail.com>
<CANxoLDe9U1a6oOxJ+xy6cBHyghmCKgMpv6X7fqj9knSUU4FjBw@mail.gmail.com>
<CAJ9T6SsW9VB+J8UAbMXtpapuA_Dx8qX25BOdTLrkq=O+zCbVqw@mail.gmail.com>
Hi Pradip
I have seen that we have duplicated code for resize_the_queryTool,
resize_the_erdtool, resize_the_psql, and in debugger_ui.js file. I would
suggest making a common function somewhere in the utils and call that
function. In the future, if we need to change the code we will have to
change it in four different places.
Please resend the patch after fixing the above issue.
On Thu, Jun 24, 2021 at 7:00 PM Pradip Parkale <
[email protected]> wrote:
> Hi Akshay,
>
> Please find attached for debugger and ERD tool which was missing in
> my previous patch.
>
> On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks, the patch applied.
>>
>> On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for #6398.Detaching query editor panel
>>> gives a blank white panel.
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.
In-Reply-To: <CANxoLDe0Wq9cNE5qMEJQXoTHuVW_fPS-78PJhGRNyoV8xQujtg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox