public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
Date: Thu, 15 Mar 2018 16:14:17 +0530
Message-ID: <CANxoLDeJK05HLZfxC7GanritfE9Kao9eM71_bW9q2yY_OsMaDg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQRm4xwt60MzV8uMc10-_SaRVbnb0kyMFzf7wq=PcmUZQ@mail.gmail.com>
References: <[email protected]>
<CAKKotZQRm4xwt60MzV8uMc10-_SaRVbnb0kyMFzf7wq=PcmUZQ@mail.gmail.com>
Thanks patch applied
On Thu, Mar 15, 2018 at 4:03 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi Akshay,
>
> Given commit introduce PEP8 issue, PFA minor patch to fix the issue.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi <
> [email protected]> wrote:
>
>> Sporadically crashes on Windows when exit. Fixes #3177
>> 1) Shutdown the python server properly.
>> 2) Disabled "Shutdown server" menu till server is not successfully
>> started.
>>
>> Initial patch sent by Maxim, modified by Akshay Joshi.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=54b1a79cb6f90ac9b26db57e616dc750fb2c6b54
>> Author: Maxim Zakharov <[email protected]>
>>
>> Modified Files
>> --------------
>> runtime/Server.cpp | 11 +++++++++++
>> runtime/Server.h | 3 +++
>> runtime/TrayIcon.cpp | 11 +++++++++++
>> runtime/TrayIcon.h | 4 ++++
>> runtime/pgAdmin4.cpp | 46 ++++++++++++++++++++++++++++++
>> ++++++++++++++
>> runtime/pgAdmin4.h | 1 +
>> web/pgadmin/misc/__init__.py | 16 ++++++++++++++-
>> 7 files changed, 91 insertions(+), 1 deletion(-)
>>
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
In-Reply-To: <CANxoLDeJK05HLZfxC7GanritfE9Kao9eM71_bW9q2yY_OsMaDg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox