public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
Date: Thu, 15 Mar 2018 16:03:32 +0530
Message-ID: <CAKKotZQRm4xwt60MzV8uMc10-_SaRVbnb0kyMFzf7wq=PcmUZQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Hi Akshay,
Given commit introduce PEP8 issue, PFA minor patch to fix the issue.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi <[email protected]
> wrote:
> Sporadically crashes on Windows when exit. Fixes #3177
> 1) Shutdown the python server properly.
> 2) Disabled "Shutdown server" menu till server is not successfully
> started.
>
> Initial patch sent by Maxim, modified by Akshay Joshi.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 54b1a79cb6f90ac9b26db57e616dc750fb2c6b54
> Author: Maxim Zakharov <[email protected]>
>
> Modified Files
> --------------
> runtime/Server.cpp | 11 +++++++++++
> runtime/Server.h | 3 +++
> runtime/TrayIcon.cpp | 11 +++++++++++
> runtime/TrayIcon.h | 4 ++++
> runtime/pgAdmin4.cpp | 46 ++++++++++++++++++++++++++++++
> ++++++++++++++
> runtime/pgAdmin4.h | 1 +
> web/pgadmin/misc/__init__.py | 16 ++++++++++++++-
> 7 files changed, 91 insertions(+), 1 deletion(-)
>
>
Attachments:
[application/octet-stream] fix_PEP8.diff (462B, 3-fix_PEP8.diff)
download | inline diff:
diff --git a/web/pgadmin/misc/__init__.py b/web/pgadmin/misc/__init__.py
index 848e6ee..19e1828 100644
--- a/web/pgadmin/misc/__init__.py
+++ b/web/pgadmin/misc/__init__.py
@@ -117,6 +117,7 @@ def explain_js():
mimetype="application/javascript"
)
+
##########################################################################
# A special URL used to shutdown the server
##########################################################################
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
In-Reply-To: <CAKKotZQRm4xwt60MzV8uMc10-_SaRVbnb0kyMFzf7wq=PcmUZQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox