public inbox for [email protected]
help / color / mirror / Atom feed[patch][pgAdmin] RM6949 When user Clicking on Reassign/Drop owned no dialog box opens
2+ messages / 2 participants
[nested] [flat]
* [patch][pgAdmin] RM6949 When user Clicking on Reassign/Drop owned no dialog box opens
@ 2021-10-22 08:35 Rahul Shirsat <[email protected]>
2021-10-25 06:19 ` Re: [patch][pgAdmin] RM6949 When user Clicking on Reassign/Drop owned no dialog box opens Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Shirsat @ 2021-10-22 08:35 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find the attached patch which resolves the issue of not opening a
reassign/drop owned dialog box.
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM6949.patch (1.1K, 3-RM6949.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
index c18e7c2c1..1d343012d 100644
--- a/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
+++ b/web/pgadmin/browser/server_groups/servers/roles/static/js/role.js
@@ -129,7 +129,7 @@ define('pgadmin.node.role', [
var tree = pgBrowser.tree,
_i = tree.selected(),
- _d = _i && _i.length == 1 ? tree.itemData(_i) : undefined,
+ _d = _i ? tree.itemData(_i) : undefined,
obj = this, finalUrl, old_role_name;
//RoleReassign Model (Objects like role, database)
@@ -435,7 +435,7 @@ define('pgadmin.node.role', [
// Find current/selected node
var tree = pgBrowser.tree,
_i = tree.selected(),
- _d = _i && _i.length == 1 ? tree.itemData(_i) : undefined,
+ _d = _i ? tree.itemData(_i) : undefined,
node = _d && pgBrowser.Nodes[_d._type];
finalUrl = obj.generate_url(_i, 'reassign' , _d, true);
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [patch][pgAdmin] RM6949 When user Clicking on Reassign/Drop owned no dialog box opens
2021-10-22 08:35 [patch][pgAdmin] RM6949 When user Clicking on Reassign/Drop owned no dialog box opens Rahul Shirsat <[email protected]>
@ 2021-10-25 06:19 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2021-10-25 06:19 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Thanks, the patch applied.
On Fri, Oct 22, 2021 at 2:06 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached patch which resolves the issue of not opening a
> reassign/drop owned dialog box.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-10-25 06:19 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 08:35 [patch][pgAdmin] RM6949 When user Clicking on Reassign/Drop owned no dialog box opens Rahul Shirsat <[email protected]>
2021-10-25 06:19 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox