public inbox for [email protected]  
help / color / mirror / Atom feed
[pgAdmin][RM6835]: Unable to edit publication in properties dialog.
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM6835]: Unable to edit publication in properties dialog.
@ 2021-10-04 08:03  Pradip Parkale <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Pradip Parkale @ 2021-10-04 08:03 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Please find the attached patch for 1st part of #6835.

   - Unable to edit publication in the subscription dialog.


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


Attachments:

  [application/octet-stream] RM6835.patch (882B, 3-RM6835.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py
index b3c096710..e1fbdfb5b 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py
@@ -410,10 +410,6 @@ class SubscriptionView(PGChildNodeView, SchemaDiffObjectCompare):
         )
 
         try:
-            if 'pub' in data:
-                data['pub'] = json.loads(
-                    data['pub'], encoding='utf-8'
-                )
             sql, name = self.get_sql(data, subid)
             # Most probably this is due to error
             if not isinstance(sql, str):
* Unmerged path web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.js


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM6835]: Unable to edit publication in properties dialog.
@ 2021-10-04 09:04  Akshay Joshi <[email protected]>
  parent: Pradip Parkale <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2021-10-04 09:04 UTC (permalink / raw)
  To: Pradip Parkale <[email protected]>; +Cc: pgadmin-hackers

Thanks, the patch applied.

On Mon, Oct 4, 2021 at 1:33 PM Pradip Parkale <
[email protected]> wrote:

> Hi Hackers,
>
> Please find the attached patch for 1st part of #6835.
>
>    - Unable to edit publication in the subscription dialog.
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2021-10-04 09:04 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 08:03 [pgAdmin][RM6835]: Unable to edit publication in properties dialog. Pradip Parkale <[email protected]>
2021-10-04 09:04 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox