public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion
Date: Thu, 14 Jun 2018 14:36:12 +0530
Message-ID: <CANxoLDfGSOb7mEGT38DOmVBGOdBS1-dOtA7WGhYr-bx9nSX45w@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxox1t8LR7byMFmNSexxxoVhLw6n6o3AbAoSV46ci8mDPuA@mail.gmail.com>
References: <CANxoLDecb+ArijBx+cvz4fNEiWYyOcBA4mbFXk3X=wMeJGoOzQ@mail.gmail.com>
<CA+OCxox1t8LR7byMFmNSexxxoVhLw6n6o3AbAoSV46ci8mDPuA@mail.gmail.com>
On Thu, Jun 14, 2018 at 1:14 PM, Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for the Feature #2686 Property to switch
>> lower/upper case auto completion. I have added new preferences settings
>> "Keywords in uppercase" if it is set to True then all the keywords are
>> shown in upper case in auto completion.
>>
>> I have also implemented the second request in the RM to change the
>> selected text to upper/lower case. For that I have added new keyboard
>> shortcut "Toggle case of selected text" in preferences dialog. Default
>> key is "Ctrl + Shift + u".
>>
>> Please review it.
>>
>
> I don't see any doc updates in the patch - seems like that was forgotten?
>
You mean to say ".rst" files? If yes, then sorry I forgot to update
that. Will do it and send the modified patch.
>
> Any opportunities to re-factor the code in that area into more testable
> functions?
>
I have modified the files which are already re-factored. I haven't seen
any logic that can be re-factored.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion
In-Reply-To: <CANxoLDfGSOb7mEGT38DOmVBGOdBS1-dOtA7WGhYr-bx9nSX45w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox