public inbox for [email protected]
help / color / mirror / Atom feedThe target connection was wrong in function check_version_compatibility()
2+ messages / 2 participants
[nested] [flat]
* The target connection was wrong in function check_version_compatibility()
@ 2021-01-12 05:32 Huang, Jun <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Huang, Jun @ 2021-01-12 05:32 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
The target connection was made by source connection manager(it should be made by target connection manager)
in function check_version_compatibility(web\pgadmin\tools\schema_diff\__init__.py).
Attached patch adds the changes.
Regrads,
Huang
Attachments:
[application/octet-stream] 0001-Target-connection-was-wrong-in-function.patch (1002B, 2-0001-Target-connection-was-wrong-in-function.patch)
download | inline diff:
From ae6dbbd16cb39189f4e2597d1d9e4e6dbd6dbd14 Mon Sep 17 00:00:00 2001
From: "huangj.fnst" <[email protected]>
Date: Tue, 12 Jan 2021 13:13:27 +0800
Subject: [PATCH] Target connection was wrong in function
check_version_compatibility(),fix it.
---
web/pgadmin/tools/schema_diff/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/pgadmin/tools/schema_diff/__init__.py b/web/pgadmin/tools/schema_diff/__init__.py
index ecf55967e..7ca19d2d2 100644
--- a/web/pgadmin/tools/schema_diff/__init__.py
+++ b/web/pgadmin/tools/schema_diff/__init__.py
@@ -709,7 +709,7 @@ def check_version_compatibility(sid, tid):
tar_server = Server.query.filter_by(id=tid).first()
tar_manager = driver.connection_manager(tar_server.id)
- target_conn = src_manager.connection()
+ target_conn = tar_manager.connection()
if not (src_conn.connected() and target_conn.connected()):
return False, gettext('Server(s) disconnected.')
--
2.23.0.windows.1
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: The target connection was wrong in function check_version_compatibility()
@ 2021-01-12 09:40 Akshay Joshi <[email protected]>
parent: Huang, Jun <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2021-01-12 09:40 UTC (permalink / raw)
To: Huang, Jun <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Tue, Jan 12, 2021 at 11:03 AM Huang, Jun <[email protected]>
wrote:
> Hi,
> The target connection was made by source connection manager(it should be
> made by target connection manager)
> in function
> check_version_compatibility(web\pgadmin\tools\schema_diff\__init__.py).
> Attached patch adds the changes.
>
> Regrads,
> Huang
>
>
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-01-12 09:40 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 05:32 The target connection was wrong in function check_version_compatibility() Huang, Jun <[email protected]>
2021-01-12 09:40 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox