public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab
@ 2019-01-14 08:57  Aditya Toshniwal <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Toshniwal @ 2019-01-14 08:57 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix incomplete SQL for Foreign tables in SQL tab.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


Attachments:

  [application/octet-stream] RM3453.patch (894B, 3-RM3453.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
index ddb31e79..2d206bff 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py
@@ -1209,10 +1209,6 @@ class ForeignTableView(PGChildNodeView, DataTypeReader):
         if db_variables is not None:
             for row in db_variables:
                 var_name, var_value = row.split("=")
-                # Because we save as boolean string in db so it needs
-                # conversion
-                if var_value == 'false' or var_value == 'off':
-                    var_value = False
 
                 var_dict = {'option': var_name, 'value': var_value}
 


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab
@ 2019-01-16 07:05  Akshay Joshi <[email protected]>
  parent: Aditya Toshniwal <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2019-01-16 07:05 UTC (permalink / raw)
  To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers

Thanks patch applied.

On Mon, Jan 14, 2019 at 2:28 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is the patch to fix incomplete SQL for Foreign tables in SQL tab.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2019-01-16 07:05 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 08:57 [pgAdmin4][RM3453] Incomplete SQL for Foreign tables in SQL tab Aditya Toshniwal <[email protected]>
2019-01-16 07:05 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox