public inbox for [email protected]
help / color / mirror / Atom feed pgAdmin 4 commit: 1) Added email id validation on the login page.
3+ messages / 2 participants
[nested] [flat]
* pgAdmin 4 commit: 1) Added email id validation on the login page.
@ 2020-09-11 14:37 Akshay Joshi <[email protected]>
2020-09-16 09:22 ` Re: pgAdmin 4 commit: 1) Added email id validation on the login page. Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Akshay Joshi @ 2020-09-11 14:37 UTC (permalink / raw)
To: [email protected]
1) Added email id validation on the login page.
2) Added validation for the file manager.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b82e6dbdb8646de0bd35c7297f81a32dee5d...
Author: Aditya Toshniwal <[email protected]>
Modified Files
--------------
web/pgadmin/authenticate/internal.py | 15 +++++++----
web/pgadmin/misc/file_manager/__init__.py | 37 ++++++++++++---------------
web/pgadmin/setup/user_info.py | 10 +++-----
web/pgadmin/tools/user_management/__init__.py | 22 +++++++++++-----
web/pgadmin/utils/paths.py | 19 +++++++++++---
web/pgadmin/utils/validation_utils.py | 26 +++++++++++++++++++
6 files changed, 86 insertions(+), 43 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgAdmin 4 commit: 1) Added email id validation on the login page.
2020-09-11 14:37 pgAdmin 4 commit: 1) Added email id validation on the login page. Akshay Joshi <[email protected]>
@ 2020-09-16 09:22 ` Murtuza Zabuawala <[email protected]>
2020-09-17 14:53 ` Re: pgAdmin 4 commit: 1) Added email id validation on the login page. Akshay Joshi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Murtuza Zabuawala @ 2020-09-16 09:22 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Hi Team,
PFA patch to fix typo introduced with this patch.
--
Regards,
Murtuza Zabuawala
*EDB*
*POWER TO POSTGRES*
https://www.edbpostgres.com
On Fri, Sep 11, 2020 at 8:07 PM Akshay Joshi <[email protected]>
wrote:
> 1) Added email id validation on the login page.
> 2) Added validation for the file manager.
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b82e6dbdb8646de0bd35c7297f81a32dee5d...
> Author: Aditya Toshniwal <[email protected]>
>
> Modified Files
> --------------
> web/pgadmin/authenticate/internal.py | 15 +++++++----
> web/pgadmin/misc/file_manager/__init__.py | 37
> ++++++++++++---------------
> web/pgadmin/setup/user_info.py | 10 +++-----
> web/pgadmin/tools/user_management/__init__.py | 22 +++++++++++-----
> web/pgadmin/utils/paths.py | 19 +++++++++++---
> web/pgadmin/utils/validation_utils.py | 26 +++++++++++++++++++
> 6 files changed, 86 insertions(+), 43 deletions(-)
>
>
Attachments:
[application/octet-stream] typo.diff (492B, 3-typo.diff)
download | inline diff:
diff --git a/web/pgadmin/utils/paths.py b/web/pgadmin/utils/paths.py
index 30bbcfa47..04522528b 100644
--- a/web/pgadmin/utils/paths.py
+++ b/web/pgadmin/utils/paths.py
@@ -37,7 +37,7 @@ def get_storage_directory():
def _preprocess_username(un):
ret_un = un
if len(ret_un) == 0 or ret_un[0].isdigit():
- ret_un = 'pga_user_' + username
+ ret_un = 'pga_user_' + un
ret_un = ret_un.replace('@', '_')\
.replace('/', 'slash')\
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgAdmin 4 commit: 1) Added email id validation on the login page.
2020-09-11 14:37 pgAdmin 4 commit: 1) Added email id validation on the login page. Akshay Joshi <[email protected]>
2020-09-16 09:22 ` Re: pgAdmin 4 commit: 1) Added email id validation on the login page. Murtuza Zabuawala <[email protected]>
@ 2020-09-17 14:53 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Akshay Joshi @ 2020-09-17 14:53 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Thanks, patch applied.
On Wed, Sep 16, 2020 at 2:52 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi Team,
>
> PFA patch to fix typo introduced with this patch.
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>
>
> On Fri, Sep 11, 2020 at 8:07 PM Akshay Joshi <
> [email protected]> wrote:
>
>> 1) Added email id validation on the login page.
>> 2) Added validation for the file manager.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b82e6dbdb8646de0bd35c7297f81a32dee5d...
>> Author: Aditya Toshniwal <[email protected]>
>>
>> Modified Files
>> --------------
>> web/pgadmin/authenticate/internal.py | 15 +++++++----
>> web/pgadmin/misc/file_manager/__init__.py | 37
>> ++++++++++++---------------
>> web/pgadmin/setup/user_info.py | 10 +++-----
>> web/pgadmin/tools/user_management/__init__.py | 22 +++++++++++-----
>> web/pgadmin/utils/paths.py | 19 +++++++++++---
>> web/pgadmin/utils/validation_utils.py | 26 +++++++++++++++++++
>> 6 files changed, 86 insertions(+), 43 deletions(-)
>>
>>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2020-09-17 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 14:37 pgAdmin 4 commit: 1) Added email id validation on the login page. Akshay Joshi <[email protected]>
2020-09-16 09:22 ` Re: pgAdmin 4 commit: 1) Added email id validation on the login page. Murtuza Zabuawala <[email protected]>
2020-09-17 14:53 ` Re: pgAdmin 4 commit: 1) Added email id validation on the login page. Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox