public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nikhil Mohite <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React
Date: Wed, 24 Nov 2021 17:09:14 +0530
Message-ID: <CAOBg0APs0i7EHtaDhzW3njEXTMiwni36kgktwkosr3=DqOJy4w@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDd7AUzqxK4QDwUROhrZeiSBf8AL7F0dhiR_uDk6hcQQyg@mail.gmail.com>
References: <CAOBg0AP5qPSeQTszGraKxJ9DLt5-Qd7ikuU8oa1OJTpnmX4MPA@mail.gmail.com>
<CANxoLDe5mEx_pM85YarO_qeSa+_wOvThOuvPbtMfA3_3b4XhKw@mail.gmail.com>
<CAOBg0ANzqyWtUDzQ=bteGwrg5z1RE8UDu+akjFN8DR1wx+JHOw@mail.gmail.com>
<CANxoLDd7AUzqxK4QDwUROhrZeiSBf8AL7F0dhiR_uDk6hcQQyg@mail.gmail.com>
Hi Akshay,
Please find the updated patch:
1. Resolved issue if the binary patch is not present/ not correct, then
show error notification to add/ correct the binary path.
Regards,
Nikhil Mohite
On Mon, Nov 22, 2021 at 11:22 AM Akshay Joshi <[email protected]>
wrote:
> Thanks, the patch applied.
>
> On Mon, Nov 22, 2021 at 10:48 AM Nikhil Mohite <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> Please find the updated patch.
>>
>> On Wed, Nov 17, 2021 at 6:34 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Nikhil
>>>
>>> Following are the review comments:
>>>
>>> GUI:
>>>
>>> - Dialog size should be increased.
>>> - Remove the first blank element from the Encoding dropdown.
>>> - When opening the file dialog header should have the title 'Select
>>> file'.
>>> - 'Backup server' title should be changed to 'Backup Server'.
>>> - When taking the backup of any object like database, schema, etc..
>>> the title on the dialog header should be "Backup (Database/Schema ..."
>>> instead of "Backup (database/schema ..."
>>>
>>>
>>> Code:
>>>
>>> - Jasmine test cases are failing.
>>> - Remove warnBeforeChangesLost function not needed for Utilities.
>>> (Remove Alertify as well)
>>> - The naming convention should be identical, in some cases, you used
>>> camel case and in some cases used with an underscore.
>>> - Remove the commented code from all the files.
>>> - Take all the screenshots again with a width of 681.
>>>
>>> Resolved all review comments.
>>
>>> Note: I haven't tested it thoroughly with all combinations.
>>>
>>> On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached patch for RM-6884:
>>>> <https://redmine.postgresql.org/issues/6984; Port Backup Global,
>>>> Backup Server, and Backup object dialog in React
>>>>
>>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Senior Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/;
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachments:
[application/octet-stream] RM-6984_v3.patch (869B, 3-RM-6984_v3.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/backup/static/js/backup.js b/web/pgadmin/tools/backup/static/js/backup.js
index ffe4ec28..6a01eab4 100644
--- a/web/pgadmin/tools/backup/static/js/backup.js
+++ b/web/pgadmin/tools/backup/static/js/backup.js
@@ -174,7 +174,14 @@ define([
this.showBackupDialog(schema, treeItem, j, data, panel, typeOfDialog, serverIdentifier, extraData);
},
saveCallBack: function(data, dialog) {
- pgBrowser.Events.trigger('pgadmin-bgprocess:created', dialog);
+ if(data.errormsg) {
+ alertify.alert(
+ gettext('Utility not found'),
+ gettext(data.errormsg)
+ );
+ } else {
+ pgBrowser.Events.trigger('pgadmin-bgprocess:created', dialog);
+ }
},
showBackupDialog: function(schema, item, j, data, panel, typeOfDialog, serverIdentifier, extraData) {
if(schema) {
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React
In-Reply-To: <CAOBg0APs0i7EHtaDhzW3njEXTMiwni36kgktwkosr3=DqOJy4w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox