public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin III commit: Resolved an issue related enable/disable menu items
5+ messages / 2 participants
[nested] [flat]
* pgAdmin III commit: Resolved an issue related enable/disable menu items
@ 2015-09-22 07:56 Ashesh Vashi <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Ashesh Vashi @ 2015-09-22 07:56 UTC (permalink / raw)
To: pgadmin-hackers
Resolved an issue related enable/disable menu items in Query Editor
specifically for Unity Desktop Environment.
wxWidgets was not able to identify the current focused control in some
cases, during certain event generation. And, that was resulting into
disabling the wrong menu items.
i.e.
Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
In order to resolve the issue, we will not consider the events
generated, but - no control gets focused, while enabling/disabling the
menus.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9b...
Modified Files
--------------
CHANGELOG | 3 +++
pgadmin/frm/frmQuery.cpp | 59 +++++++++++++++++++++++++++-------------------
2 files changed, 38 insertions(+), 24 deletions(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgAdmin III commit: Resolved an issue related enable/disable menu items
@ 2015-09-23 04:53 J.F. Oster <[email protected]>
parent: Ashesh Vashi <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: J.F. Oster @ 2015-09-23 04:53 UTC (permalink / raw)
To: Ashesh Vashi <[email protected]>; +Cc: pgadmin-hackers
Hi Ashesh,
Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
items are disabled all the time (seen on Ubuntu, Kubuntu).
Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
AV> Resolved an issue related enable/disable menu items in Query Editor
AV> specifically for Unity Desktop Environment.
AV> wxWidgets was not able to identify the current focused control in some
AV> cases, during certain event generation. And, that was resulting into
AV> disabling the wrong menu items.
AV> i.e.
AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
AV> In order to resolve the issue, we will not consider the events
AV> generated, but - no control gets focused, while enabling/disabling the
AV> menus.
AV> Branch
AV> ------
AV> master
AV> Details
AV> -------
AV> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9b...
AV> Modified Files
AV> --------------
AV> CHANGELOG | 3 +++
AV> pgadmin/frm/frmQuery.cpp | 59
AV> +++++++++++++++++++++++++++-------------------
AV> 2 files changed, 38 insertions(+), 24 deletions(-)
--
Best regards,
J.F.
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgAdmin III commit: Resolved an issue related enable/disable menu items
@ 2015-09-23 04:57 Ashesh Vashi <[email protected]>
parent: J.F. Oster <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Ashesh Vashi @ 2015-09-23 04:57 UTC (permalink / raw)
To: J.F. Oster <[email protected]>; +Cc: pgadmin-hackers
On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster <[email protected]> wrote:
> Hi Ashesh,
>
> Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
> items are disabled all the time (seen on Ubuntu, Kubuntu).
>
I've tested the patch couple of times on Ubuntu, and OSX both before
committing the changes.
Do you have time to look into it?
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
>
> Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
>
> AV> Resolved an issue related enable/disable menu items in Query Editor
> AV> specifically for Unity Desktop Environment.
>
> AV> wxWidgets was not able to identify the current focused control in some
> AV> cases, during certain event generation. And, that was resulting into
> AV> disabling the wrong menu items.
> AV> i.e.
> AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
>
> AV> In order to resolve the issue, we will not consider the events
> AV> generated, but - no control gets focused, while enabling/disabling the
> AV> menus.
>
> AV> Branch
> AV> ------
> AV> master
>
> AV> Details
> AV> -------
> AV>
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9b...
>
> AV> Modified Files
> AV> --------------
> AV> CHANGELOG | 3 +++
> AV> pgadmin/frm/frmQuery.cpp | 59
> AV> +++++++++++++++++++++++++++-------------------
> AV> 2 files changed, 38 insertions(+), 24 deletions(-)
>
>
>
>
>
> --
> Best regards,
> J.F.
>
>
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgAdmin III commit: Resolved an issue related enable/disable menu items
@ 2015-09-23 05:06 Ashesh Vashi <[email protected]>
parent: Ashesh Vashi <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Ashesh Vashi @ 2015-09-23 05:06 UTC (permalink / raw)
To: J.F. Oster <[email protected]>; +Cc: pgadmin-hackers
On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi <
[email protected]> wrote:
> On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster <[email protected]> wrote:
>
>> Hi Ashesh,
>>
>> Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
>> items are disabled all the time (seen on Ubuntu, Kubuntu).
>>
> I've tested the patch couple of times on Ubuntu, and OSX both before
> committing the changes.
>
> Do you have time to look into it?
>
Got the reason.
Thanks for the report.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com;
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi;
>
>>
>> Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
>>
>> AV> Resolved an issue related enable/disable menu items in Query Editor
>> AV> specifically for Unity Desktop Environment.
>>
>> AV> wxWidgets was not able to identify the current focused control in some
>> AV> cases, during certain event generation. And, that was resulting into
>> AV> disabling the wrong menu items.
>> AV> i.e.
>> AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
>>
>> AV> In order to resolve the issue, we will not consider the events
>> AV> generated, but - no control gets focused, while enabling/disabling the
>> AV> menus.
>>
>> AV> Branch
>> AV> ------
>> AV> master
>>
>> AV> Details
>> AV> -------
>> AV>
>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9b...
>>
>> AV> Modified Files
>> AV> --------------
>> AV> CHANGELOG | 3 +++
>> AV> pgadmin/frm/frmQuery.cpp | 59
>> AV> +++++++++++++++++++++++++++-------------------
>> AV> 2 files changed, 38 insertions(+), 24 deletions(-)
>>
>>
>>
>>
>>
>> --
>> Best regards,
>> J.F.
>>
>>
>
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgAdmin III commit: Resolved an issue related enable/disable menu items
@ 2015-09-23 05:11 Ashesh Vashi <[email protected]>
parent: Ashesh Vashi <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Ashesh Vashi @ 2015-09-23 05:11 UTC (permalink / raw)
To: J.F. Oster <[email protected]>; +Cc: pgadmin-hackers
On Wed, Sep 23, 2015 at 10:36 AM, Ashesh Vashi <
[email protected]> wrote:
>
> On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi <
> [email protected]> wrote:
>
>> On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster <[email protected]> wrote:
>>
>>> Hi Ashesh,
>>>
>>> Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
>>> items are disabled all the time (seen on Ubuntu, Kubuntu).
>>>
>> I've tested the patch couple of times on Ubuntu, and OSX both before
>> committing the changes.
>>
>> Do you have time to look into it?
>>
> Got the reason.
> Thanks for the report.
>
Thanks once again.
Please check now.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com;
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi;
>
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi;
>>
>>>
>>> Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
>>>
>>> AV> Resolved an issue related enable/disable menu items in Query Editor
>>> AV> specifically for Unity Desktop Environment.
>>>
>>> AV> wxWidgets was not able to identify the current focused control in
>>> some
>>> AV> cases, during certain event generation. And, that was resulting into
>>> AV> disabling the wrong menu items.
>>> AV> i.e.
>>> AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
>>>
>>> AV> In order to resolve the issue, we will not consider the events
>>> AV> generated, but - no control gets focused, while enabling/disabling
>>> the
>>> AV> menus.
>>>
>>> AV> Branch
>>> AV> ------
>>> AV> master
>>>
>>> AV> Details
>>> AV> -------
>>> AV>
>>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9b...
>>>
>>> AV> Modified Files
>>> AV> --------------
>>> AV> CHANGELOG | 3 +++
>>> AV> pgadmin/frm/frmQuery.cpp | 59
>>> AV> +++++++++++++++++++++++++++-------------------
>>> AV> 2 files changed, 38 insertions(+), 24 deletions(-)
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Best regards,
>>> J.F.
>>>
>>>
>>
>
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2015-09-23 05:11 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2015-09-22 07:56 pgAdmin III commit: Resolved an issue related enable/disable menu items Ashesh Vashi <[email protected]>
2015-09-23 04:53 ` J.F. Oster <[email protected]>
2015-09-23 04:57 ` Ashesh Vashi <[email protected]>
2015-09-23 05:06 ` Ashesh Vashi <[email protected]>
2015-09-23 05:11 ` Ashesh Vashi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox