public inbox for [email protected]  
help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: Fixed below review comments
Date: Fri, 06 May 2016 12:15:44 +0000
Message-ID: <[email protected]> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Fixed below review comments
- Removed the "lineWrapping" option from the codemirror textarea because
  it was creating issue in the code folding.
- Handle the values while depositing during debugging.
- Properly handle the Array values while saving it to sqlite database
  and displayed in input dialog.
- SQL code folding was not supported in codemirror so added the same.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=149c59aa4fc8a01c9211662f8c16a7cc099f4...
Author: Neel Patel <[email protected]>

Modified Files
--------------
web/pgadmin/static/js/backgrid/backgrid.pgadmin.js |  6 +-
.../codemirror/addon/fold/pgadmin-sqlfoldcode.js   | 83 ++++++++++++++++++++++
web/pgadmin/tools/debugger/__init__.py             | 76 ++++++++++++--------
web/pgadmin/tools/debugger/static/css/debugger.css | 31 +++++++-
.../debugger/templates/debugger/js/debugger_ui.js  | 36 ++++++++--
.../tools/debugger/templates/debugger/js/direct.js | 80 +++++++++++++--------
.../templates/debugger/sql/execute_edbspl.sql      |  6 +-
.../templates/debugger/sql/execute_plpgsql.sql     |  4 +-
8 files changed, 248 insertions(+), 74 deletions(-)


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: pgAdmin 4 commit: Fixed below review comments
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox