public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Fixed below review comments
2+ messages / 1 participants
[nested] [flat]
* pgAdmin 4 commit: Fixed below review comments
@ 2016-05-06 12:15 Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2016-05-06 12:15 UTC (permalink / raw)
To: pgadmin-hackers
Fixed below review comments
- Removed the "lineWrapping" option from the codemirror textarea because
it was creating issue in the code folding.
- Handle the values while depositing during debugging.
- Properly handle the Array values while saving it to sqlite database
and displayed in input dialog.
- SQL code folding was not supported in codemirror so added the same.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=149c59aa4fc8a01c9211662f8c16a7cc099f4...
Author: Neel Patel <[email protected]>
Modified Files
--------------
web/pgadmin/static/js/backgrid/backgrid.pgadmin.js | 6 +-
.../codemirror/addon/fold/pgadmin-sqlfoldcode.js | 83 ++++++++++++++++++++++
web/pgadmin/tools/debugger/__init__.py | 76 ++++++++++++--------
web/pgadmin/tools/debugger/static/css/debugger.css | 31 +++++++-
.../debugger/templates/debugger/js/debugger_ui.js | 36 ++++++++--
.../tools/debugger/templates/debugger/js/direct.js | 80 +++++++++++++--------
.../templates/debugger/sql/execute_edbspl.sql | 6 +-
.../templates/debugger/sql/execute_plpgsql.sql | 4 +-
8 files changed, 248 insertions(+), 74 deletions(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgAdmin 4 commit: Fixed below review comments for QueryTool
@ 2016-05-06 12:41 Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2016-05-06 12:41 UTC (permalink / raw)
To: pgadmin-hackers
Fixed below review comments for QueryTool
- The button bar be moved out into an HTML template
- create.sql should perhaps be renamed to insert.sql
- The "Add Row" button only works if you're on the last page of the resultset.
- Use one wcDocker instead of two
- Added support of code folding
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=894002b06df53d84c735eb8969e98ec4c6b4a...
Modified Files
--------------
.../tools/datagrid/templates/datagrid/index.html | 114 ++++++++-
web/pgadmin/tools/sqleditor/command.py | 2 +-
.../tools/sqleditor/static/css/sqleditor.css | 39 +++-
.../sqleditor/templates/sqleditor/js/sqleditor.js | 254 ++++++---------------
.../templates/sqleditor/sql/9.1_plus/create.sql | 8 -
.../templates/sqleditor/sql/9.1_plus/insert.sql | 8 +
6 files changed, 219 insertions(+), 206 deletions(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-05-06 12:41 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-05-06 12:15 pgAdmin 4 commit: Fixed below review comments Akshay Joshi <[email protected]>
2016-05-06 12:41 pgAdmin 4 commit: Fixed below review comments for QueryTool Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox