public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Added support to download utility files at the client
3+ messages / 2 participants
[nested] [flat]
* pgAdmin 4 commit: Added support to download utility files at the client
@ 2020-10-23 11:47 Akshay Joshi <[email protected]>
2020-10-26 12:54 ` Re: pgAdmin 4 commit: Added support to download utility files at the client Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Akshay Joshi @ 2020-10-23 11:47 UTC (permalink / raw)
To: [email protected]
Added support to download utility files at the client-side. Fixes #3318
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2ad97d0ab761ad57cf98b192ffe75e9a0d2...
Author: Rahul Shirsat <[email protected]>
Modified Files
--------------
docs/en_US/release_notes_4_28.rst | 1 +
web/pgadmin/misc/bgprocess/processes.py | 58 +++-
.../misc/bgprocess/static/css/bgprocess.css | 4 +
.../misc/bgprocess/static/img/storage_manager.svg | 13 +
web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 44 ++-
web/pgadmin/misc/file_manager/__init__.py | 17 +-
.../misc/file_manager/static/js/file_manager.js | 6 +-
.../misc/file_manager/static/js/select_dialogue.js | 3 +-
.../file_manager/static/js/storage_dialogue.js | 45 +++
web/pgadmin/misc/file_manager/static/js/utility.js | 76 ++++-
web/pgadmin/tools/backup/__init__.py | 5 +
.../tools/backup/tests/test_backup_message.py | 34 +-
web/pgadmin/tools/import_export/__init__.py | 93 ++++--
.../import_export/tests/test_batch_process.py | 244 ++++++++++++++
.../import_export/tests/test_create_export_job.py | 149 +++++++++
.../import_export/tests/test_create_import_job.py | 241 ++++++++++++++
.../test_import_export_create_job_unit_test.py | 353 +++++++++++++++++++++
.../tests/test_import_export_message.py | 135 ++++++++
.../tests/test_import_export_utils.py | 194 +++++++++++
web/pgadmin/tools/storage_manager/__init__.py | 75 +++++
.../storage_manager/static/js/storage_manager.js | 93 ++++++
.../javascript/file_manager/file_manager_specs.js | 18 ++
web/webpack.config.js | 1 +
web/webpack.shim.js | 1 +
24 files changed, 1842 insertions(+), 61 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgAdmin 4 commit: Added support to download utility files at the client
2020-10-23 11:47 pgAdmin 4 commit: Added support to download utility files at the client Akshay Joshi <[email protected]>
@ 2020-10-26 12:54 ` Murtuza Zabuawala <[email protected]>
2020-10-27 05:46 ` Re: pgAdmin 4 commit: Added support to download utility files at the client Akshay Joshi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Murtuza Zabuawala @ 2020-10-26 12:54 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Hi,
PFA minor patch to remove dead code which was introduced with this patch.
--
Regards,
Murtuza Zabuawala
*EDB*
*POWER TO POSTGRES*
https://www.edbpostgres.com
On Fri, Oct 23, 2020 at 5:17 PM Akshay Joshi <[email protected]>
wrote:
> Added support to download utility files at the client-side. Fixes #3318
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2ad97d0ab761ad57cf98b192ffe75e9a0d2...
> Author: Rahul Shirsat <[email protected]>
>
> Modified Files
> --------------
> docs/en_US/release_notes_4_28.rst | 1 +
> web/pgadmin/misc/bgprocess/processes.py | 58 +++-
> .../misc/bgprocess/static/css/bgprocess.css | 4 +
> .../misc/bgprocess/static/img/storage_manager.svg | 13 +
> web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 44 ++-
> web/pgadmin/misc/file_manager/__init__.py | 17 +-
> .../misc/file_manager/static/js/file_manager.js | 6 +-
> .../misc/file_manager/static/js/select_dialogue.js | 3 +-
> .../file_manager/static/js/storage_dialogue.js | 45 +++
> web/pgadmin/misc/file_manager/static/js/utility.js | 76 ++++-
> web/pgadmin/tools/backup/__init__.py | 5 +
> .../tools/backup/tests/test_backup_message.py | 34 +-
> web/pgadmin/tools/import_export/__init__.py | 93 ++++--
> .../import_export/tests/test_batch_process.py | 244 ++++++++++++++
> .../import_export/tests/test_create_export_job.py | 149 +++++++++
> .../import_export/tests/test_create_import_job.py | 241 ++++++++++++++
> .../test_import_export_create_job_unit_test.py | 353
> +++++++++++++++++++++
> .../tests/test_import_export_message.py | 135 ++++++++
> .../tests/test_import_export_utils.py | 194 +++++++++++
> web/pgadmin/tools/storage_manager/__init__.py | 75 +++++
> .../storage_manager/static/js/storage_manager.js | 93 ++++++
> .../javascript/file_manager/file_manager_specs.js | 18 ++
> web/webpack.config.js | 1 +
> web/webpack.shim.js | 1 +
> 24 files changed, 1842 insertions(+), 61 deletions(-)
>
>
Attachments:
[application/octet-stream] remove_dead_code.diff (1.3K, 3-remove_dead_code.diff)
download | inline diff:
diff --git a/web/pgadmin/tools/import_export/__init__.py b/web/pgadmin/tools/import_export/__init__.py
index d119e979f..1f6204e81 100644
--- a/web/pgadmin/tools/import_export/__init__.py
+++ b/web/pgadmin/tools/import_export/__init__.py
@@ -136,27 +136,6 @@ class IEMessage(IProcessDesc):
_type_desc = _("Import - ") if self.is_import else _("Export - ")
return _type_desc + _("Copying table data")
- # @property
- # def current_storage_dir(self):
- #
- # if config.SERVER_MODE:
- # path = os.path.realpath(self.bfile)
- # if get_storage_directory() < path:
- # storage_directory = os.path.basename(get_storage_directory())
- # start = path.index(storage_directory)
- # end = start + (len(storage_directory))
- #
- # last_dir = os.path.dirname(path[end:])
- # else:
- # last_dir = '\\'
- #
- # else:
- # last_dir = os.path.dirname(self.bfile) \
- # if os.path.isfile(self.bfile) \
- # else self.bfile
- #
- # return None if self.is_import else last_dir
-
def details(self, cmd, args):
# Fetch the server details like hostname, port, roles etc
name, host, port = self.get_server_details()
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgAdmin 4 commit: Added support to download utility files at the client
2020-10-23 11:47 pgAdmin 4 commit: Added support to download utility files at the client Akshay Joshi <[email protected]>
2020-10-26 12:54 ` Re: pgAdmin 4 commit: Added support to download utility files at the client Murtuza Zabuawala <[email protected]>
@ 2020-10-27 05:46 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Akshay Joshi @ 2020-10-27 05:46 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Thanks, patch applied.
On Mon, Oct 26, 2020 at 6:24 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA minor patch to remove dead code which was introduced with this patch.
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>
>
> On Fri, Oct 23, 2020 at 5:17 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Added support to download utility files at the client-side. Fixes #3318
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2ad97d0ab761ad57cf98b192ffe75e9a0d2...
>> Author: Rahul Shirsat <[email protected]>
>>
>> Modified Files
>> --------------
>> docs/en_US/release_notes_4_28.rst | 1 +
>> web/pgadmin/misc/bgprocess/processes.py | 58 +++-
>> .../misc/bgprocess/static/css/bgprocess.css | 4 +
>> .../misc/bgprocess/static/img/storage_manager.svg | 13 +
>> web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 44 ++-
>> web/pgadmin/misc/file_manager/__init__.py | 17 +-
>> .../misc/file_manager/static/js/file_manager.js | 6 +-
>> .../misc/file_manager/static/js/select_dialogue.js | 3 +-
>> .../file_manager/static/js/storage_dialogue.js | 45 +++
>> web/pgadmin/misc/file_manager/static/js/utility.js | 76 ++++-
>> web/pgadmin/tools/backup/__init__.py | 5 +
>> .../tools/backup/tests/test_backup_message.py | 34 +-
>> web/pgadmin/tools/import_export/__init__.py | 93 ++++--
>> .../import_export/tests/test_batch_process.py | 244 ++++++++++++++
>> .../import_export/tests/test_create_export_job.py | 149 +++++++++
>> .../import_export/tests/test_create_import_job.py | 241 ++++++++++++++
>> .../test_import_export_create_job_unit_test.py | 353
>> +++++++++++++++++++++
>> .../tests/test_import_export_message.py | 135 ++++++++
>> .../tests/test_import_export_utils.py | 194 +++++++++++
>> web/pgadmin/tools/storage_manager/__init__.py | 75 +++++
>> .../storage_manager/static/js/storage_manager.js | 93 ++++++
>> .../javascript/file_manager/file_manager_specs.js | 18 ++
>> web/webpack.config.js | 1 +
>> web/webpack.shim.js | 1 +
>> 24 files changed, 1842 insertions(+), 61 deletions(-)
>>
>>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2020-10-27 05:46 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-10-23 11:47 pgAdmin 4 commit: Added support to download utility files at the client Akshay Joshi <[email protected]>
2020-10-26 12:54 ` Murtuza Zabuawala <[email protected]>
2020-10-27 05:46 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox