public inbox for [email protected]  

help / color / mirror / Atom feed

oauth2 patch
4+ messages / 3 participants
[nested] [flat]

* oauth2 patch
@ 2021-05-07 15:41 Florian Sabonchi <[email protected]>
  2021-05-10 05:29 ` Re: oauth2 patch Akshay Joshi <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Florian Sabonchi @ 2021-05-07 15:41 UTC (permalink / raw)
  To: pgadmin-hackers

Hello in this patch I have implemented OAuth2. Unfortunately I wasn't 
sure how the test should look like, because I couldn't find anything in 
the developer documentation, so I decided not to write one for now.

The configuration has to look like this here is an example for github:

OAUTH2_NAME = 'github'
OAUTH2_CLIENT_ID = 'secret'
OAUTH2_CLIENT_SECRET = 'secret'
OAUTH2_TOKEN_URL = 'https://github.com/login/oauth/access_token';
OAUTH2_AUTHORIZATION_URL = 'https://github.com/login/oauth/authorize';
OAUTH2_API_BASE_URL = 'https://api.github.com/';
OAUTH2_USERINFO_ENDPOINT = 'https://api.github.com/user';
OAUTH_ENDPOINT_NAME = 'user'




^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: oauth2 patch
  2021-05-07 15:41 oauth2 patch Florian Sabonchi <[email protected]>
@ 2021-05-10 05:29 ` Akshay Joshi <[email protected]>
  2021-05-10 10:32   ` Re: oauth2 patch Khushboo Vashi <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Akshay Joshi @ 2021-05-10 05:29 UTC (permalink / raw)
  To: Florian Sabonchi <[email protected]>; Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers

Hi Khushboo

Can you please review the patch?

On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi <[email protected]> wrote:

> Hello in this patch I have implemented OAuth2. Unfortunately I wasn't
> sure how the test should look like, because I couldn't find anything in
> the developer documentation, so I decided not to write one for now.
>
> The configuration has to look like this here is an example for github:
>
> OAUTH2_NAME = 'github'
> OAUTH2_CLIENT_ID = 'secret'
> OAUTH2_CLIENT_SECRET = 'secret'
> OAUTH2_TOKEN_URL = 'https://github.com/login/oauth/access_token';
> OAUTH2_AUTHORIZATION_URL = 'https://github.com/login/oauth/authorize';
> OAUTH2_API_BASE_URL = 'https://api.github.com/';
> OAUTH2_USERINFO_ENDPOINT = 'https://api.github.com/user';
> OAUTH_ENDPOINT_NAME = 'user'
>
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: oauth2 patch
  2021-05-07 15:41 oauth2 patch Florian Sabonchi <[email protected]>
  2021-05-10 05:29 ` Re: oauth2 patch Akshay Joshi <[email protected]>
@ 2021-05-10 10:32   ` Khushboo Vashi <[email protected]>
  2021-05-25 05:48     ` Re: oauth2 patch Khushboo Vashi <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Khushboo Vashi @ 2021-05-10 10:32 UTC (permalink / raw)
  To: Akshay Joshi <[email protected]>; +Cc: Florian Sabonchi <[email protected]>; pgadmin-hackers

On Mon, May 10, 2021 at 10:59 AM Akshay Joshi <[email protected]>
wrote:

> Hi Khushboo
>
> Can you please review the patch?
>
On it.

>
> On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi <[email protected]>
> wrote:
>
>> Hello in this patch I have implemented OAuth2. Unfortunately I wasn't
>> sure how the test should look like, because I couldn't find anything in
>> the developer documentation, so I decided not to write one for now.
>>
>> The configuration has to look like this here is an example for github:
>>
>> OAUTH2_NAME = 'github'
>> OAUTH2_CLIENT_ID = 'secret'
>> OAUTH2_CLIENT_SECRET = 'secret'
>> OAUTH2_TOKEN_URL = 'https://github.com/login/oauth/access_token';
>> OAUTH2_AUTHORIZATION_URL = 'https://github.com/login/oauth/authorize';
>> OAUTH2_API_BASE_URL = 'https://api.github.com/';
>> OAUTH2_USERINFO_ENDPOINT = 'https://api.github.com/user';
>> OAUTH_ENDPOINT_NAME = 'user'
>>
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: oauth2 patch
  2021-05-07 15:41 oauth2 patch Florian Sabonchi <[email protected]>
  2021-05-10 05:29 ` Re: oauth2 patch Akshay Joshi <[email protected]>
  2021-05-10 10:32   ` Re: oauth2 patch Khushboo Vashi <[email protected]>
@ 2021-05-25 05:48     ` Khushboo Vashi <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: Khushboo Vashi @ 2021-05-25 05:48 UTC (permalink / raw)
  To: Florian Sabonchi <[email protected]>; +Cc: pgadmin-hackers

Hi Florian,

I have reviewed your patch, some modifications are required as below. I
have started working on top of your patch to accommodate the required
changes.

- Proper handling of Master Password in Server Mode as it was
introduced only in Desktop mode.
- Encryption/Decryption of the server password if Master Password is
disabled, currently if I disable the master password, I could not connect
the server with your patch.
- Proper documentation, comments.
- Minor UI modifications, like introducing a configurable icon with the
Oauth login button etc.

You can track the progress, ref https://redmine.postgresql.org/issues/5940,
I have attached your initial patch in the RM itself.

Thanks,
Khushboo








On Mon, May 10, 2021 at 4:02 PM Khushboo Vashi <
[email protected]> wrote:

>
>
> On Mon, May 10, 2021 at 10:59 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Khushboo
>>
>> Can you please review the patch?
>>
> On it.
>
>>
>> On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi <[email protected]>
>> wrote:
>>
>>> Hello in this patch I have implemented OAuth2. Unfortunately I wasn't
>>> sure how the test should look like, because I couldn't find anything in
>>> the developer documentation, so I decided not to write one for now.
>>>
>>> The configuration has to look like this here is an example for github:
>>>
>>> OAUTH2_NAME = 'github'
>>> OAUTH2_CLIENT_ID = 'secret'
>>> OAUTH2_CLIENT_SECRET = 'secret'
>>> OAUTH2_TOKEN_URL = 'https://github.com/login/oauth/access_token';
>>> OAUTH2_AUTHORIZATION_URL = 'https://github.com/login/oauth/authorize';
>>> OAUTH2_API_BASE_URL = 'https://api.github.com/';
>>> OAUTH2_USERINFO_ENDPOINT = 'https://api.github.com/user';
>>> OAUTH_ENDPOINT_NAME = 'user'
>>>
>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

end of thread, other threads:[~2021-05-25 05:48 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 15:41 oauth2 patch Florian Sabonchi <[email protected]>
2021-05-10 05:29 ` Akshay Joshi <[email protected]>
2021-05-10 10:32   ` Khushboo Vashi <[email protected]>
2021-05-25 05:48     ` Khushboo Vashi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox