pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2070: feat: support two-table cross-shard JOINs (JOIN, LEFT JOIN, CROSS JOIN, NATURAL JOIN)
Date: Thu, 19 Nov 2026 13:13:59 +0000
Message-ID: <gh-pgdogdev-pgdog-2070-c7010172297@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2070@github.com>
References: <gh-pgdogdev-pgdog-2070@github.com>

<!-- metal-bench -->

**Metal bench (arm64) failed.** 3 of 520 measures outside bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 19.04 (+0.1% ± 0.8%) | 18,345 (+0.6% ± 0.5%) | 31,429 (+0.0% ± 0.2%) | 30,439 (-0.2% ± 1.5%) | 51,064 (-0.1% ± 0.4%) |  |
| lb |  | 19.53 (+0.3% ± 0.2%) | 18,803 (+0.9% ± 1.2%) | 32,326 (-0.1% ± 0.1%) | 30,930 (-0.0% ± 1.0%) | 52,175 (-0.1% ± 0.5%) |  |
| sharding-w2 |  | 34.49 (+2.2% ± 0.7%) | 46,548 (+1.8% ± 1.4%) | 94,982 (+0.0% ± 0.02%) | 44,086 (+4.1% ± 2.9%) | 53,628 (-0.1% ± 0.3%) | 1.534 (-0.6% ± 0.5%) |
| sharding-w8 | 237,441 (-1.1% ± 1.3%) | 30.29 (+1.4% ± 1.4%) | 45,994 (+0.9% ± 1.5%) | 50,572 (+0.1% ± 0.05%) | 37,709 (+2.1% ± 1.4%) | 42,403 (-0.0% ± 0.1%) | 0.1614 (-2.2% ± 1.9%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,940 (+1.1% ± 1.1%) | 2,727 (+0.7% ± 0.6%) |  |
| lb | 8,113 (+1.8% ± 2.9%) | 2,758 (+1.0% ± 1.1%) |  |
| sharding-w2 | 21,536 (+5.0% ± 4.0%) | 4,500 (+2.1% ± 2.9%) |  |
| sharding-w8 | 22,732 (+3.2% ± 4.5%) | 4,360 (+0.8% ± 2.3%) |  |
</details>

| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| full_extended_cached::aggregate | instructions | 145,762 | 144,115 | **+1.14% ± 0.00%** | +1% |
| full_extended_cached::cte | instructions | 101,085 | 99,590 | **+1.50% ± 0.00%** | +1% |
| full_named_cached::aggregate | instructions | 137,191 | 134,706 | **+1.84% ± 0.00%** | +1% |

Microbench: 504 of 507 measures within bounds.

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 115.8 KB | 114.3 KB | **-1.5 KB** |
| sharding-w2 | 168.9 KB | 169.9 KB | **+1.0 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.3 KB | 20.2 KB | -0.1 KB |
| tokio | 18.6 KB | 18.3 KB | -0.2 KB |
| pgdog::backend::pool | 17.7 KB | 17.4 KB | -0.2 KB |
| aws-lc (TLS crypto) | 10.4 KB | 10.2 KB | -0.2 KB |
| rustls (TLS) | 8.4 KB | 8.4 KB | +0.0 KB |
| pgdog::frontend (other) | 8.0 KB | 8.0 KB | +0.0 KB |
| pgdog::backend::server | 7.8 KB | 7.9 KB | +0.1 KB |
| other | 6.6 KB | 6.3 KB | -0.2 KB |
| everything else | 18.1 KB | 17.5 KB | -0.6 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.7 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | +0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.2 KB | 29.2 KB | -0.1 KB |
| pgdog::frontend::client::query_engine | 21.6 KB | 21.6 KB | +0.0 KB |
| tokio | 18.5 KB | 18.9 KB | +0.4 KB |
| pgdog::backend::pool | 18.1 KB | 18.2 KB | +0.2 KB |
| aws-lc (TLS crypto) | 13.3 KB | 13.4 KB | +0.1 KB |
| other | 10.3 KB | 10.1 KB | -0.2 KB |
| pgdog::frontend (other) | 8.9 KB | 8.9 KB | +0.0 KB |
| rustls (TLS) | 8.2 KB | 8.2 KB | -0.1 KB |
| everything else | 40.8 KB | 41.4 KB | +0.6 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.0 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.8 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.3 KB | -0.1 KB |

</details>

<details><summary>lb flamegraph vs 61e9a90b</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...).
</details>
<details><summary>microbench flamegraph vs 61e9a90b</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...).
</details>
<details><summary>pooler flamegraph vs 61e9a90b</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...).
</details>
<details><summary>sharding-w2 flamegraph vs 61e9a90b</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...).
</details>
<details><summary>sharding-w8 flamegraph vs 61e9a90b</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-cross-shard-joins-core-v2/0b9dec694d88f5e838ac...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-cross-shard-joins-co...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-cross-shard-joins-co...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-cross-shard-joins-co...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-cross-shard-joins-co...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-cross-shard-joins-co...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-cross-shard-joins-co...)
</details>

Compared 0b9dec69 with 61e9a90b on m8gd.metal-24xl (spot).


view thread (4+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2070-c7010172297@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2070-c7010172297@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox