pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
[pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
8+ messages / 4 participants
[nested] [flat]

* [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
@ 2026-11-19 13:43 "meskill (@meskill)" <noreply+meskill@github.com>
  0 siblings, 0 replies; 8+ messages in thread

From: meskill (@meskill) @ 2026-11-19 13:43 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

New rust now show warnings about unused deps - clean them up and make lock file smaller

inline patch 1: Cargo.lock, examples/demo/Cargo.toml, integration/rust/Cargo.toml and 3 more (+12/-86 lines) download inline-1.patchdiff --git a/Cargo.lock b/Cargo.lock index f337ec7cf..fcc3b4160 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -280,7 +280,7 @@ version = "0.13.16" source = "registry+https://github.com/rust-lang/crates.io-index"; checksum = "37b00953a69b2cfb471d13d72538d2e66930832340b0f31deadd404b48c573c5" dependencies = [ - "bindgen 0.72.1", + "bindgen", "cc", "cmake", "dunce", @@ -757,26 +757,6 @@ dependencies = [ "num-traits", ] -[[package]] -name = "bindgen" -version = "0.71.1" -source = "registry+https://github.com/rust-lang/crates.io-index"; -checksum = "5f58bf3d7db68cfbac37cfc485a8d711e87e064c3d0fe0435b92f7a407f9d6b3" -dependencies = [ - "bitflags 2.11.1", - "cexpr", - "clang-sys", - "itertools 0.13.0", - "log", - "prettyplease", - "proc-macro2", - "quote", - "regex", - "rustc-hash", - "shlex 1.3.0", - "syn 2.0.118", -] - [[package]] name = "bindgen" version = "0.72.1" @@ -1247,15 +1227,6 @@ version = "2.5.0" source = "registry+https://github.com/rust-lang/crates.io-index"; checksum = "217698eaf96b4a3f0bc4f3662aaa55bdf913cd54d7204591faa790070c6d0853" -[[package]] -name = "crc32c" -version = "0.6.8" -source = "registry+https://github.com/rust-lang/crates.io-index"; -checksum = "3a47af21622d091a8f0fb295b88bc886ac74efcc613efc19f5d0b21de5c89e47" -dependencies = [ - "rustc_version", -] - [[package]] name = "crc32fast" version = "1.5.0" @@ -1491,7 +1462,6 @@ version = "0.1.0" dependencies = [ "colored", "tokio", - "which", ] [[package]] @@ -1691,12 +1661,6 @@ dependencies = [ "syn 2.0.118", ] -[[package]] -name = "env_home" -version = "0.1.0" -source = "registry+https://github.com/rust-lang/crates.io-index"; -checksum = "c7f84e12ccf0a7ddc17a6c41c93326024c42920d7ee630d04950e6926645c0fe" - [[package]] name = "equivalent" version = "1.0.2" @@ -2507,10 +2471,8 @@ dependencies = [ "chrono", "chrono-tz", "futures-util", - "itertools 0.15.0", "libc", "native-tls", - "ordered-float", "parking_lot", "pg_stream", "pgdog-regress", @@ -3093,15 +3055,6 @@ dependencies = [ "vcpkg", ] -[[package]] -name = "ordered-float" -version = "4.6.0" -source = "registry+https://github.com/rust-lang/crates.io-index"; -checksum = "7bb71e1b3fa6ca1c61f383464aaf2bb0e2f8e772a1f01d486832464de363b951" -dependencies = [ - "num-traits", -] - [[package]] name = "outref" version = "0.5.2" @@ -3163,7 +3116,7 @@ name = "pg_internals" version = "0.1.0" source = "git+https://github.com/pgdogdev/pg-internals?rev=ce5c26f2501d787cdb84f610176a92880944dbcd#ce5c26f2501d78...; dependencies = [ - "bindgen 0.72.1", + "bindgen", "cc", "clang-sys", "phf 0.13.1", @@ -3181,7 +3134,7 @@ name = "pg_raw_parse" version = "0.1.0" source = "git+https://github.com/pgdogdev/pg_raw_parse.git?rev=89937b1#89937b1a9c39bbb53b679f12aba3ff7c5ab3c093...; dependencies = [ - "bindgen 0.72.1", + "bindgen", "cc", "convert_case 0.11.0", "generativity", @@ -3198,7 +3151,7 @@ name = "pg_raw_parse" version = "0.1.0" source = "git+https://github.com/pgdogdev/pg_raw_parse.git?rev=a4784fc603563d3db8e9f381347f039f39b1dd85#a4784fc603...; dependencies = [ - "bindgen 0.72.1", + "bindgen", "cc", "convert_case 0.11.0", "generativity", @@ -3244,7 +3197,6 @@ dependencies = [ "chrono", "chrono-tz", "clap", - "crc32c", "csv-core", "dashmap", "derive_builder", @@ -3371,7 +3323,6 @@ dependencies = [ name = "pgdog-plugin" version = "0.5.0" dependencies = [ - "bindgen 0.71.1", "libloading", "pg_raw_parse 0.1.0 (git+https://github.com/pgdogdev/pg_raw_parse.git?rev=89937b1)";, "pgdog-postgres-types", @@ -3400,7 +3351,6 @@ version = "0.1.0" dependencies = [ "arc-swap", "once_cell", - "parking_lot", "pg_raw_parse 0.1.0 (git+https://github.com/pgdogdev/pg_raw_parse.git?rev=89937b1)";, "pgdog-plugin", "serde", @@ -5794,18 +5744,6 @@ dependencies = [ "rustls-pki-types", ] -[[package]] -name = "which" -version = "7.0.3" -source = "registry+https://github.com/rust-lang/crates.io-index"; -checksum = "24d643ce3fd3e5b54854602a080f34fb10ab75e0b813ee32d00ca2b44fa74762" -dependencies = [ - "either", - "env_home", - "rustix", - "winsafe", -] - [[package]] name = "whoami" version = "1.6.1" @@ -6080,12 +6018,6 @@ dependencies = [ "memchr", ] -[[package]] -name = "winsafe" -version = "0.0.19" -source = "registry+https://github.com/rust-lang/crates.io-index"; -checksum = "d135d17ab770252ad95e9a872d365cf3090e3be864a34ab46f48555993efc904" - [[package]] name = "wiremock" version = "0.6.5" diff --git a/examples/demo/Cargo.toml b/examples/demo/Cargo.toml index 453331115..ff336c022 100644 --- a/examples/demo/Cargo.toml +++ b/examples/demo/Cargo.toml @@ -6,4 +6,3 @@ edition = "2024" [dependencies] colored = "3.0" tokio.workspace = true -which = "7" diff --git a/integration/rust/Cargo.toml b/integration/rust/Cargo.toml index 35e9e7df1..ba78267ce 100644 --- a/integration/rust/Cargo.toml +++ b/integration/rust/Cargo.toml @@ -8,26 +8,26 @@ test = true [dependencies] tokio-postgres = {version = "0.7.13", features = ["with-uuid-1"]} -postgres-native-tls = "0.5" native-tls = "0.2" sqlx = { version = "0.8.6", features = ["postgres", "runtime-tokio", "tls-native-tls", "bigdecimal", "chrono", "json", "rust_decimal", "uuid"]} tokio.workspace = true futures-util.workspace = true uuid.workspace = true -serial_test = "3" chrono = "0.4" parking_lot.workspace = true -reqwest.workspace = true serde_json.workspace = true -ordered-float = "4.2" -tokio-rustls = "0.26" libc = "0.2" -rand = "0.9" bytes.workspace = true rust_decimal = { version = "1.42.0", features = ["macros"] } + +[dev-dependencies] +postgres-native-tls = "0.5" +serial_test = "3" +reqwest.workspace = true +rand = "0.9" chrono-tz = "0.10.4" pgdog-stats = { path = "../../pgdog-stats" } -itertools = "0.15" pg_stream = "0.2.1" pgdog-regress = { git = "https://github.com/pgdogdev/regress.git";, rev = "22032787eeaef9bf97aaa3216735a7369f1f9125" } anyhow = "1.0.104" +tokio-rustls = "0.26" diff --git a/pgdog-plugin/Cargo.toml b/pgdog-plugin/Cargo.toml index f8f0faeae..0bb7eeed5 100644 --- a/pgdog-plugin/Cargo.toml +++ b/pgdog-plugin/Cargo.toml @@ -21,8 +21,5 @@ pgdog-postgres-types.workspace = true tracing = "0.1" tracing-subscriber = { version = "0.3", features = ["env-filter", "json"] } -[build-dependencies] -bindgen = "0.71.0" - [features] default = [] diff --git a/pgdog/Cargo.toml b/pgdog/Cargo.toml index 4ed04c0c1..62db8e3d7 100644 --- a/pgdog/Cargo.toml +++ b/pgdog/Cargo.toml @@ -75,11 +75,9 @@ aws-sdk-rds = { version = "1", default-features = false } pgdog-config = { path = "../pgdog-config" } pgdog-vector = { path = "../pgdog-vector" } pgdog-stats = { path = "../pgdog-stats" } -pgdog-macros = { path = "../pgdog-macros" } pgdog-postgres-types.workspace = true azure_identity = "1.0.0" azure_core = "1.0.0" -crc32c = "0.6.8" bit-vec = "0.8" smallvec = "1" reqwest.workspace = true @@ -108,3 +106,4 @@ brunch = "0.5" wiremock = "0.6" tokio = { workspace = true, features = ["test-util"] } divan = "0.1.21" +pgdog-macros = { path = "../pgdog-macros" } diff --git a/plugins/pgdog-primary-only-tables/Cargo.toml b/plugins/pgdog-primary-only-tables/Cargo.toml index f16b50d7f..efcd100d8 100644 --- a/plugins/pgdog-primary-only-tables/Cargo.toml +++ b/plugins/pgdog-primary-only-tables/Cargo.toml @@ -9,7 +9,6 @@ crate-type = ["cdylib"] [dependencies] pgdog-plugin.workspace = true once_cell = "1" -parking_lot = "0.12" thiserror = "2" toml = "0.8" serde = { version = "1", features = ["derive"]}
^ permalink raw [nested|flat] 8+ messages in thread

* Re: [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
@ 2026-11-19 13:46 ` "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
  6 siblings, 0 replies; 8+ messages in thread

From: codecov[bot] (bot) (@codecov[bot]) @ 2026-11-19 13:46 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

## [Codecov](https://app.codecov.io/gh/pgdogdev/pgdog/pull/2074?dropdown=coverage&src=pr&el=h1&utm_me...) Report
:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/255)

^ permalink  raw  [nested|flat] 8+ messages in thread

* Re: [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
@ 2026-11-19 14:20 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
  6 siblings, 0 replies; 8+ messages in thread

From: github-actions[bot] (bot) (@github-actions[bot]) @ 2026-11-19 14:20 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

<!-- metal-bench -->

**Metal bench (arm64) failed.** 5 of 520 measures outside bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | **19.67 (+2.2% ± 2.0%), bound +2%** | **18,366 (+2.7% ± 1.1%), bound +2%** | 31,404 (-0.0% ± 0.1%) | 32,091 (+2.6% ± 3.8%) | 50,777 (-0.2% ± 0.7%) |  |
| lb |  | **20.13 (+2.7% ± 1.4%), bound +2%** | **19,013 (+2.9% ± 1.3%), bound +2%** | 32,329 (+0.0% ± 0.04%) | 32,512 (+3.4% ± 2.0%) | 52,059 (-0.2% ± 0.3%) |  |
| sharding-w2 |  | 32.19 (+0.3% ± 1.6%) | 43,334 (+1.0% ± 1.3%) | 94,957 (+0.0% ± 0.05%) | 40,594 (-0.3% ± 2.8%) | 53,635 (-0.0% ± 0.2%) | 1.543 (-0.1% ± 0.04%) |
| sharding-w8 | 249,069 (-0.0% ± 2.4%) | 28.59 (-0.1% ± 2.2%) | 43,421 (+0.2% ± 2.6%) | 50,501 (-0.0% ± 0.05%) | 35,532 (-0.5% ± 2.2%) | 42,390 (+0.1% ± 0.2%) | 0.1732 (+1.0% ± 1.0%) |

- **pooler**: user cycles +2.7%, instructions flat. Unexplained.
- **lb**: user cycles +2.9%, instructions flat. Unexplained.

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 8,375 (+8.6% ± 3.6%) | 2,707 (+2.5% ± 1.6%) |  |
| lb | 8,784 (+8.8% ± 3.5%) | 2,769 (+2.5% ± 1.6%) |  |
| sharding-w2 | 18,518 (+2.9% ± 3.3%) | 4,216 (+1.2% ± 1.8%) |  |
| sharding-w8 | 19,672 (+1.3% ± 5.4%) | 4,080 (+1.0% ± 2.9%) |  |
</details>

| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| full_named_cached::having_distinct_limit | alloc_count | 535 | 527 | **+1.56% ± 1.30%** | +0% |

Microbench: 506 of 507 measures within bounds.

<details><summary>Microbench latency: 1 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cached::select_all_shards | 1,852 ns | 1,925 ns | -3.80% ± 0.36% | +0.00% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 114.7 KB | 114.8 KB | **+0.1 KB** |
| sharding-w2 | 168.8 KB | 167.8 KB | **-1.1 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.4 KB | 20.3 KB | -0.1 KB |
| tokio | 18.5 KB | 18.4 KB | -0.1 KB |
| pgdog::backend::pool | 17.7 KB | 17.6 KB | -0.1 KB |
| aws-lc (TLS crypto) | 10.5 KB | 10.5 KB | +0.0 KB |
| rustls (TLS) | 8.4 KB | 8.4 KB | +0.0 KB |
| pgdog::frontend (other) | 8.1 KB | 8.1 KB | +0.0 KB |
| pgdog::backend::server | 7.6 KB | 7.7 KB | +0.1 KB |
| other | 6.1 KB | 6.1 KB | +0.1 KB |
| everything else | 17.5 KB | 17.8 KB | +0.2 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.7 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | -0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.1 KB | 28.6 KB | -0.5 KB |
| pgdog::frontend::client::query_engine | 21.5 KB | 21.6 KB | +0.1 KB |
| tokio | 18.8 KB | 18.3 KB | -0.5 KB |
| pgdog::backend::pool | 18.1 KB | 18.2 KB | +0.2 KB |
| aws-lc (TLS crypto) | 12.9 KB | 12.6 KB | -0.4 KB |
| other | 10.2 KB | 10.0 KB | -0.2 KB |
| pgdog::frontend (other) | 8.8 KB | 8.8 KB | -0.1 KB |
| pgdog::backend::server | 8.0 KB | 8.4 KB | +0.4 KB |
| everything else | 41.4 KB | 41.3 KB | -0.1 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.8 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.3 KB | -0.1 KB |

</details>

<details><summary>lb flamegraph vs 6b0e24d7</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>
<details><summary>microbench flamegraph vs 6b0e24d7</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>
<details><summary>pooler flamegraph vs 6b0e24d7</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>
<details><summary>sharding-w2 flamegraph vs 6b0e24d7</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>
<details><summary>sharding-w8 flamegraph vs 6b0e24d7</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...)
</details>

Compared e64189d8 with 6b0e24d7 on m8g.metal-24xl (spot).


^ permalink  raw  [nested|flat] 8+ messages in thread

* Re: [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
@ 2026-11-19 14:21 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
  6 siblings, 0 replies; 8+ messages in thread

From: github-actions[bot] (bot) (@github-actions[bot]) @ 2026-11-19 14:21 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

<!-- metal-bench-x86 -->

**Metal bench (x86) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 34.91 (+0.5% ± 0.3%) | 23,099 (+1.2% ± 0.5%) | 32,775 (-0.0% ± 0.02%) | 58,319 (+0.4% ± 0.5%) | 38,554 (-0.0% ± 0.3%) |  |
| lb |  | 35.94 (+0.4% ± 0.3%) | 24,261 (+1.0% ± 0.6%) | 33,736 (+0.0% ± 0.02%) | 59,351 (+0.3% ± 0.4%) | 39,200 (-0.0% ± 0.09%) |  |
| sharding-w2 |  | 56.57 (-0.0% ± 1.6%) | 53,512 (-0.1% ± 2.5%) | 98,693 (-0.0% ± 0.01%) | 73,426 (+0.1% ± 2.0%) | 43,110 (+0.0% ± 0.8%) | 1.391 (+0.2% ± 0.4%) |
| sharding-w8 | 146,409 (-0.5% ± 4.5%) | 48.68 (+0.6% ± 3.3%) | 57,910 (+0.5% ± 0.6%) | 54,239 (+0.1% ± 0.3%) | 65,745 (+0.8% ± 6.0%) | 34,259 (+0.1% ± 0.3%) | 0.1749 (+0.7% ± 6.3%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 74,749 (+2.4% ± 0.7%) | 3,707 (+1.0% ± 0.2%) |  |
| lb | 78,585 (+2.7% ± 1.5%) | 3,826 (+0.9% ± 0.2%) |  |
| sharding-w2 | 166,307 (+0.4% ± 6.1%) | 6,293 (-0.6% ± 1.5%) |  |
| sharding-w8 | 128,998 (+2.1% ± 1.4%) | 5,042 (-0.0% ± 0.5%) |  |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Microbench latency: 19 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cached::delete_by_key | 2,184 ns | 2,299 ns | -5.00% ± 0.37% | +0.00% ± 0.00% |
| extended_cached::set | 1,441 ns | 1,513 ns | -4.76% ± 0.36% | +0.00% ± 0.00% |
| extended_cold::select_omni | 3,629 ns | 3,795 ns | -4.37% ± 0.86% | +0.00% ± 0.00% |
| extended_cold::select_all_shards | 4,003 ns | 4,174 ns | -4.09% ± 1.40% | +0.00% ± 0.00% |
| extended_cached::begin | 1,336 ns | 1,390 ns | -3.88% ± 0.78% | +0.00% ± 0.00% |
| extended_cold::select_by_key | 4,827 ns | 5,017 ns | -3.78% ± 0.53% | +0.00% ± 0.00% |
| extended_cached::delete_all_shards | 1,748 ns | 1,816 ns | -3.74% ± 0.72% | +0.00% ± 0.00% |
| extended_cached::select_omni | 2,024 ns | 2,102 ns | -3.71% ± 0.76% | +0.00% ± 0.00% |
| extended_cached::update_by_key | 2,368 ns | 2,456 ns | -3.58% ± 0.65% | +0.00% ± 0.00% |
| extended_cold::delete_all_shards | 2,939 ns | 3,047 ns | -3.54% ± 1.57% | +0.00% ± 0.00% |
| extended_cached::insert_returning | 2,324 ns | 2,406 ns | -3.42% ± 0.42% | +0.00% ± 0.00% |
| extended_cached::distinct | 2,376 ns | 2,460 ns | -3.41% ± 1.14% | +0.00% ± 0.00% |
| extended_cached::update_all_shards | 1,930 ns | 1,996 ns | -3.31% ± 0.55% | +0.00% ± 0.00% |
| extended_cold::insert | 6,237 ns | 6,445 ns | -3.22% ± 0.32% | +0.00% ± 0.00% |
| simple_cold::delete_all_shards | 2,841 ns | 2,931 ns | -3.07% ± 0.77% | +0.00% ± 0.00% |
| extended_cached::join | 3,856 ns | 3,978 ns | -3.06% ± 0.86% | +0.00% ± 0.00% |
| extended_cold::aggregate | 8,195 ns | 8,453 ns | -3.05% ± 0.65% | +0.00% ± 0.00% |
| extended_cached::having | 3,011 ns | 3,105 ns | -3.03% ± 0.72% | +0.00% ± 0.00% |
| extended_cold::select_in_list | 5,785 ns | 5,965 ns | -3.02% ± 0.49% | +0.00% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 107.9 KB | 110.8 KB | **+2.9 KB** |
| sharding-w2 | 167.4 KB | 169.0 KB | **+1.6 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.9 KB | 21.5 KB | +0.6 KB |
| tokio | 17.7 KB | 17.7 KB | +0.0 KB |
| pgdog::backend::pool | 16.3 KB | 16.6 KB | +0.3 KB |
| pgdog::frontend (other) | 9.3 KB | 9.5 KB | +0.2 KB |
| aws-lc (TLS crypto) | 6.6 KB | 7.7 KB | +1.1 KB |
| pgdog::backend::server | 7.1 KB | 7.2 KB | +0.1 KB |
| rustls (TLS) | 7.0 KB | 7.0 KB | +0.0 KB |
| jemalloc | 5.9 KB | 5.9 KB | +0.0 KB |
| everything else | 17.0 KB | 17.7 KB | +0.7 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.3 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.2 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | +0.3 KB |
| `tokio::runtime::task::raw::poll` | 3.5 KB | +0.0 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 27.7 KB | 28.1 KB | +0.4 KB |
| pgdog::frontend::client::query_engine | 23.6 KB | 23.8 KB | +0.1 KB |
| pgdog::backend::pool | 17.8 KB | 18.1 KB | +0.4 KB |
| tokio | 18.1 KB | 17.5 KB | -0.6 KB |
| other | 10.5 KB | 10.8 KB | +0.2 KB |
| pgdog::frontend (other) | 10.8 KB | 10.7 KB | -0.1 KB |
| aws-lc (TLS crypto) | 10.1 KB | 10.5 KB | +0.4 KB |
| jemalloc | 9.9 KB | 10.5 KB | +0.6 KB |
| everything else | 39.1 KB | 39.1 KB | +0.1 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 8.1 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.7 KB | -0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.3 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 4.0 KB | -0.1 KB |

</details>

<details><summary>lb flamegraph vs 6b0e24d7</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>
<details><summary>microbench flamegraph vs 6b0e24d7</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>
<details><summary>pooler flamegraph vs 6b0e24d7</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>
<details><summary>sharding-w2 flamegraph vs 6b0e24d7</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>
<details><summary>sharding-w8 flamegraph vs 6b0e24d7</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...)
</details>

Compared e64189d8 with 6b0e24d7 on c7a.metal-48xl (spot).


^ permalink  raw  [nested|flat] 8+ messages in thread

* Re: [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
@ 2026-11-19 17:10 ` "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>
  6 siblings, 0 replies; 8+ messages in thread

From: jkaczman (@jkaczman) @ 2026-11-19 17:10 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

@jkaczman requested a review.

^ permalink  raw  [nested|flat] 8+ messages in thread

* Re: [pgdogdev/pgdog] PR #2074 (approved): chore: remove unused dependencies
@ 2026-11-19 17:10 ` "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>
  6 siblings, 0 replies; 8+ messages in thread

From: jkaczman (@jkaczman) @ 2026-11-19 17:10 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>



^ permalink  raw  [nested|flat] 8+ messages in thread

* Re: [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
@ 2026-11-19 17:18 ` "meskill (@meskill)" <noreply+meskill@github.com>
  6 siblings, 0 replies; 8+ messages in thread

From: meskill (@meskill) @ 2026-11-19 17:18 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

@meskill closed this.

^ permalink  raw  [nested|flat] 8+ messages in thread

* Re: [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
@ 2026-11-19 17:18 ` "meskill (@meskill)" <noreply+meskill@github.com>
  6 siblings, 0 replies; 8+ messages in thread

From: meskill (@meskill) @ 2026-11-19 17:18 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

@meskill merged this (commit 5d279129e7e2).

^ permalink  raw  [nested|flat] 8+ messages in thread


end of thread, other threads:[~2026-11-19 17:18 UTC | newest]

Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 13:43 [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies "meskill (@meskill)" <noreply+meskill@github.com>
2026-11-19 13:46 ` "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
2026-11-19 14:20 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
2026-11-19 14:21 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
2026-11-19 17:10 ` "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>
2026-11-19 17:10 ` Re: [pgdogdev/pgdog] PR #2074 (approved): chore: remove unused dependencies "jkaczman (@jkaczman)" <noreply+jkaczman@github.com>
2026-11-19 17:18 ` "meskill (@meskill)" <noreply+meskill@github.com>
2026-11-19 17:18 ` "meskill (@meskill)" <noreply+meskill@github.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox