pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feed[pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
7+ messages / 3 participants
[nested] [flat]
* [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
@ 2024-04-25 16:06 "davecramer (@davecramer)" <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: davecramer (@davecramer) @ 2024-04-25 16:06 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
@ 2024-04-27 13:43 "vlsi (@vlsi)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: vlsi (@vlsi) @ 2024-04-27 13:43 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on .github/workflows/main.yml:101)
should we extract `shell` parameter to the matrix, so we use the same step without adding extra `if`?
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
@ 2024-04-27 13:44 "vlsi (@vlsi)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: vlsi (@vlsi) @ 2024-04-27 13:44 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on .github/workflows/main.yml:101)
Will it spawn Windows-based PostgreSQL or Linux-based one?
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
@ 2024-04-27 15:25 "sehrope (@sehrope)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: sehrope (@sehrope) @ 2024-04-27 15:25 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on .github/workflows/main.yml:101)
Ah that's interesting. So this would be testing some JDK running on Windows vs a Linux Postgres running in Docker?
If we're going to test against Windows (i.e. duplicate what's in AppVeyor), could have a separate branch for the server itself running on Windows. The GitHub Runner installed software list for "windows-2022" says that it already has PostgreSQL 14.x installed: https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#databases
I think we'd be kind of tied to whatever they include in the runner image, but that's not any worse than what we have in AppVeyor. With the advantage that it'd work for forks too.
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
@ 2024-04-27 18:05 "davecramer (@davecramer)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: davecramer (@davecramer) @ 2024-04-27 18:05 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on .github/workflows/main.yml:101)
> Will it spawn Windows-based PostgreSQL or Linux-based one?
Well the reason I did this was because there are no windows postgresql docker images, hence running on ubuntu
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
@ 2024-04-27 18:06 "davecramer (@davecramer)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: davecramer (@davecramer) @ 2024-04-27 18:06 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on .github/workflows/main.yml:101)
> Ah that's interesting. So this would be testing some JDK running on Windows vs a Linux Postgres running in Docker?
>
> If we're going to test against Windows (i.e. duplicate what's in AppVeyor), could have a separate branch for the server itself running on Windows. The GitHub Runner installed software list for "windows-2022" says that it already has PostgreSQL 14.x installed: https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#databases
>
> I think we'd be kind of tied to whatever they include in the runner image, but that's not any worse than what we have in AppVeyor. With the advantage that it'd work for forks too.
Yeah, well ideally we want to be able to test windows with different PostgreSQL versions. If we just want v14 then we can use whatever is there
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
@ 2026-03-18 14:28 "vlsi (@vlsi)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: vlsi (@vlsi) @ 2026-03-18 14:28 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
We use Windows-based PostgreSQL server: https://github.com/pgjdbc/pgjdbc/pull/3966
Could we probably close the PR?
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2026-03-18 14:28 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 16:06 [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker "davecramer (@davecramer)" <[email protected]>
2024-04-27 13:43 ` "vlsi (@vlsi)" <[email protected]>
2024-04-27 13:44 ` "vlsi (@vlsi)" <[email protected]>
2024-04-27 15:25 ` "sehrope (@sehrope)" <[email protected]>
2024-04-27 18:05 ` "davecramer (@davecramer)" <[email protected]>
2024-04-27 18:06 ` "davecramer (@davecramer)" <[email protected]>
2026-03-18 14:28 ` "vlsi (@vlsi)" <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox