pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct
5+ messages / 3 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct
@ 2025-04-04 20:14  "davecramer (@davecramer)" <[email protected]>
  0 siblings, 0 replies; 5+ messages in thread

From: davecramer (@davecramer) @ 2025-04-04 20:14 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>


Alternative to https://github.com/pgjdbc/pgjdbc/pull/3528


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct
@ 2025-04-08 09:40  "davecramer (@davecramer)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: davecramer (@davecramer) @ 2025-04-08 09:40 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

I did put in a check for isvalid() but looking at the rest of the code we return many functions without verifying the connection is valid.

Thoughts @vlsi @sehrope ?

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct
@ 2025-04-08 16:06  "sehrope (@sehrope)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: sehrope (@sehrope) @ 2025-04-08 16:06 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

If we're not doing it other places and have no intention of adding this check everywhere, we should not be including it here either.

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct
@ 2025-04-08 17:02  "davecramer (@davecramer)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: davecramer (@davecramer) @ 2025-04-08 17:02 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

works for me. I'll remove the checks

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct
@ 2025-04-13 08:49  "vlsi (@vlsi)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: vlsi (@vlsi) @ 2025-04-13 08:49 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

(on pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java:1270)

`"" retrieves those without a catalog`
I assume PostgreSQL does not have "procedures without a catalog", so `catalog.isEmpty()` check looks redundant here. WDYT of replacing this with `catalog != null && (catalog.isEmpty() || !catalog.equals(connection.getCatalog()))`

`!Objects.equals(catalog, connection.getCatalog())` could do as well (at a cost of one-time SQL in `getCatalog()`)

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

end of thread, other threads:[~2025-04-13 08:49 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-04-04 20:14 [pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct "davecramer (@davecramer)" <[email protected]>
2025-04-08 09:40 ` "davecramer (@davecramer)" <[email protected]>
2025-04-08 16:06 ` "sehrope (@sehrope)" <[email protected]>
2025-04-08 17:02 ` "davecramer (@davecramer)" <[email protected]>
2025-04-13 08:49 ` "vlsi (@vlsi)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox