pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feed[pgjdbc/pgjdbc] issue #3904: Should this be protected with a reentrant lock?
3+ messages / 2 participants
[nested] [flat]
* [pgjdbc/pgjdbc] issue #3904: Should this be protected with a reentrant lock?
@ 2026-01-06 13:17 "davecramer (@davecramer)" <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: davecramer (@davecramer) @ 2026-01-06 13:17 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
https://github.com/pgjdbc/pgjdbc/blob/83023f3c2ae98dc69df00a560dbbe386afafe3b1/pgjdbc/src/main/java/...
If this were called concurrently, seems like close might not be set before some operations have been done such as setting os to null
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3904: Should this be protected with a reentrant lock?
@ 2026-01-07 16:06 ` "sehrope (@sehrope)" <[email protected]>
1 sibling, 0 replies; 3+ messages in thread
From: sehrope (@sehrope) @ 2026-01-07 16:06 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Is there any expectation or guarantee that `LargeObject` is thread safe?
Outside of a couple explicit things like closing connections, assumption should be that nothing is thread safe in the driver. This is an odd one though as the body of that function interacts via both fastpath and directly to the connection.
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3904: Should this be protected with a reentrant lock?
@ 2026-01-07 16:08 ` "davecramer (@davecramer)" <[email protected]>
1 sibling, 0 replies; 3+ messages in thread
From: davecramer (@davecramer) @ 2026-01-07 16:08 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
> Is there any expectation or guarantee that `LargeObject` is thread safe?
No, but it's strange that the we keep status in there and that we don't guard the status.
I figure it doesn't hurt anything.
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-01-07 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-01-06 13:17 [pgjdbc/pgjdbc] issue #3904: Should this be protected with a reentrant lock? "davecramer (@davecramer)" <[email protected]>
2026-01-07 16:06 ` "sehrope (@sehrope)" <[email protected]>
2026-01-07 16:08 ` "davecramer (@davecramer)" <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox